On 2009-03-01, Wolfgang Glas <wolfgang.g...@ev-i.at> wrote: > 1) Unicode extra fields are written for all ZIP entries and not only > for entries, which are not encodable by the encoding set to > ZipArchiveOutputStream.
Maybe room for yet another flag? Or an enum-like option setCreateUnicodeExtraFields(NEVER | ALWAYS | NOT_ENCODABLE) ? I've commented out that part of your patch. > To overcome these shortcoming, I had to introduce a ZipEncoding > interface plus a java.nio implementation and a handcrafted > implementation for Cp437 (and cp850) and refactor all the encoding > stuff. Looks good. > The patch is attached. The new code is IMHO really better to read > and make all cp437-related stuff accessible on java-1.4 as well. Agreed, many thanks! > Stefan, might you please review the patch and eventually apply this one? some cosmetics and commented out the "only create Unicode field for non-encodable paths" part - svn revision 749342. Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
