Stefan Bodewig schrieb:
> On 2009-03-02, Stefan Bodewig <bode...@apache.org> wrote:
> 
>> some cosmetics and commented out the "only create Unicode field for
>> non-encodable paths" part - svn revision 749342.
> 
> and 749344 - you misspet encoding in Simple8BitEncoding.java and I
> didn't see it in time.

...another small patch with even more javadoc typos and superfluent imports
fixed is attached. TIA for committing,

  Wolfgang
Index: src/main/java/org/apache/commons/compress/archivers/zip/ZipEncoding.java
===================================================================
--- src/main/java/org/apache/commons/compress/archivers/zip/ZipEncoding.java	(Revision 749398)
+++ src/main/java/org/apache/commons/compress/archivers/zip/ZipEncoding.java	(Arbeitskopie)
@@ -21,7 +21,6 @@
 
 import java.io.IOException;
 import java.nio.ByteBuffer;
-import java.nio.charset.Charset;
 
 /**
  * An interface for encoders that do a pretty encoding of ZIP
@@ -35,12 +34,12 @@
  * <p>The main reason for defining an own encoding layer comes from
  * the problems with {...@link java.lang.String#getBytes(String)
  * String.getBytes}, which encodes unknown characters as ASCII
- * quotation marks ('?'), which is per definition an invalid filename
- * character under some operating systems (Windows, e.g.) leading to
- * ignored ZIP entries.</p>
+ * quotation marks ('?'). Quotation marks are per definition an
+ * invalid filename on some operating systems  like Windows, which
+ * leads to ignored ZIP entries.</p>
  * 
  * <p>All implementations should implement this interface in a
- * reentrant way.<(p>
+ * reentrant way.</p>
  */
 interface ZipEncoding {
     /**
Index: src/main/java/org/apache/commons/compress/archivers/zip/Simple8BitZipEncoding.java
===================================================================
--- src/main/java/org/apache/commons/compress/archivers/zip/Simple8BitZipEncoding.java	(Revision 749398)
+++ src/main/java/org/apache/commons/compress/archivers/zip/Simple8BitZipEncoding.java	(Arbeitskopie)
@@ -21,7 +21,6 @@
 
 import java.io.IOException;
 import java.nio.ByteBuffer;
-import java.nio.charset.Charset;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
Index: src/main/java/org/apache/commons/compress/archivers/zip/NioZipEncoding.java
===================================================================
--- src/main/java/org/apache/commons/compress/archivers/zip/NioZipEncoding.java	(Revision 749398)
+++ src/main/java/org/apache/commons/compress/archivers/zip/NioZipEncoding.java	(Arbeitskopie)
@@ -32,7 +32,7 @@
  * java.nio.charset.Charset Charset} to encode names.
  *
  * <p>This implementation works for all cases under java-1.5 or
- * later. However, in java-1.4, some charsets don't have a java-nio
+ * later. However, in java-1.4, some charsets don't have a java.nio
  * implementation, most notably the default ZIP encoding Cp437.</p>
  * 
  * <p>The methods of this class are reentrant.</p>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to