[GitHub] commons-compress issue #22: COMPRESS-390: Expose stream offsets and size

2017-04-25 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-compress/pull/22 [![Coverage Status](https://coveralls.io/builds/11244036/badge)](https://coveralls.io/builds/11244036) Coverage decreased (-0.02%) to 84.286% when pulling **2d3da5a265a42046c

[GitHub] commons-compress pull request #22: COMPRESS-390: Expose stream offsets and s...

2017-04-25 Thread kvr000
GitHub user kvr000 opened a pull request: https://github.com/apache/commons-compress/pull/22 COMPRESS-390: Expose stream offsets and size Pull request for https://issues.apache.org/jira/browse/COMPRESS-390 You can merge this pull request into a Git repository by running: $ git

Re: [11/11] [math] MATH-1284: Vector no longer extends Point. Replace/rename Vector?D classes with Coordinate?D classes which implement both Vector and Point. When there are multiple implementations o

2017-04-25 Thread Gilles
Hi Ray. On Tue, 25 Apr 2017 22:57:07 -, raydeca...@apache.org wrote: MATH-1284: Vector no longer extends Point. Replace/rename Vector?D classes with Coordinate?D classes which implement both Vector and Point. Shouldn't it be "Cartesian?D"? Regards, Gilles When there are multiple impleme

Re: commons-numbers git commit: NUMBERS-27: Replaced hand-coded hypot with Java.lang.Math hypot

2017-04-25 Thread Gilles
Hi Eric. In the code below, any reason why you use the "accessor" method rather than refer directly to the instance fields? Regards, Gilles On Tue, 25 Apr 2017 22:40:29 + (UTC), ericbarnh...@apache.org wrote: Repository: commons-numbers Updated Branches: refs/heads/hypot-change [created

Re: commons-numbers git commit: Partial work on C Standard test; pulled changes made to master

2017-04-25 Thread Gilles
Hi Eric. Some nit-picking below... On Tue, 25 Apr 2017 22:33:25 + (UTC), ericbarnh...@apache.org wrote: Repository: commons-numbers Updated Branches: refs/heads/complex-dev 410abd7fa -> 07bbda2fd Partial work on C Standard test; pulled changes made to master Project: http://git-wip-u

Re: svn commit: r1792641 - /commons/proper/jexl/trunk/pom.xml

2017-04-25 Thread sebb
On 25 April 2017 at 20:36, Emmanuel Bourg wrote: > Le 25/04/2017 à 21:20, sebb a écrit : > >> Problem is that the short form does not generate the correct relative >> links from component pages to the Commons parent site. >> Such links need an extra ../ segment. > > Where are these links generated

[lang] Boolean method names

2017-04-25 Thread Mark Dacek
Hello all - Recently, LANG-1167 was merged into commons-lang. It hit me today that one of these method names seems a little funky. The class in question is ReflectionToStringBuilder : *https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/builder/ReflectionToStri

Re: svn commit: r1792641 - /commons/proper/jexl/trunk/pom.xml

2017-04-25 Thread Emmanuel Bourg
Le 25/04/2017 à 21:20, sebb a écrit : > Problem is that the short form does not generate the correct relative > links from component pages to the Commons parent site. > Such links need an extra ../ segment. Where are these links generated? We should switch them to absolute URLs. Emmanuel Bourg

Re: svn commit: r1792641 - /commons/proper/jexl/trunk/pom.xml

2017-04-25 Thread sebb
On 25 April 2017 at 19:50, Emmanuel Bourg wrote: > Le 25/04/2017 à 20:36, s...@apache.org a écrit : > >> --- commons/proper/jexl/trunk/pom.xml (original) >> +++ commons/proper/jexl/trunk/pom.xml Tue Apr 25 18:36:28 2017 >> @@ -28,7 +28,7 @@ >> Apache Commons JEXL >> 2001 >> The Apac

Fwd: commons-io git commit: IOUtils#toByteArray: fix spelling of local variable name

2017-04-25 Thread Gary Gregory
Good one! :-) Gary -- Forwarded message -- From: Date: Apr 25, 2017 12:05 PM Subject: commons-io git commit: IOUtils#toByteArray: fix spelling of local variable name To: Cc: Repository: commons-io Updated Branches: refs/heads/master 337828003 -> 41a3e9c52 IOUtils#toByteArray

[GitHub] commons-io pull request #35: Correct error message in IOUtils

2017-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-io/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

Re: svn commit: r1792641 - /commons/proper/jexl/trunk/pom.xml

2017-04-25 Thread Emmanuel Bourg
Le 25/04/2017 à 20:36, s...@apache.org a écrit : > --- commons/proper/jexl/trunk/pom.xml (original) > +++ commons/proper/jexl/trunk/pom.xml Tue Apr 25 18:36:28 2017 > @@ -28,7 +28,7 @@ > Apache Commons JEXL > 2001 > The Apache Commons JEXL library is an implementation of the > JSTL

[GitHub] commons-compress pull request #20: COMPRESS-382

2017-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-compress/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] commons-compress pull request #21: COMPRESS-388: Fix concurrent reads perfor...

2017-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-compress/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] commons-io pull request #35: Correct error message in IOUtils

2017-04-25 Thread io7m
GitHub user io7m opened a pull request: https://github.com/apache/commons-io/pull/35 Correct error message in IOUtils This corrects the wording of the error message in IOUtils: There's no such word as "readed", and the author probably meant "expected" as opposed to "excepted"

[Commons Wiki] Update of "FrontPage" by sebbapache

2017-04-25 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The "FrontPage" page has been changed by sebbapache: https://wiki.apache.org/commons/FrontPage?action=diff&rev1=137&rev2=138 Comment: += Security Committers: CommonsPeople | Compone

[GitHub] commons-compress issue #20: COMPRESS-382

2017-04-25 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-compress/pull/20 [![Coverage Status](https://coveralls.io/builds/11230515/badge)](https://coveralls.io/builds/11230515) Coverage increased (+0.06%) to 84.294% when pulling **2247ff96013748450

[GitHub] commons-compress pull request #20: COMPRESS-382

2017-04-25 Thread tballison
Github user tballison commented on a diff in the pull request: https://github.com/apache/commons-compress/pull/20#discussion_r113181027 --- Diff: src/main/java/org/apache/commons/compress/compressors/lzma/LZMACompressorInputStream.java --- @@ -56,7 +56,7 @@ public LZMACompressorIn

[GitHub] commons-compress pull request #20: COMPRESS-382

2017-04-25 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-compress/pull/20#discussion_r113178004 --- Diff: src/main/java/org/apache/commons/compress/compressors/lzma/LZMACompressorInputStream.java --- @@ -56,7 +56,7 @@ public LZMACompressorInputS

[GitHub] commons-compress pull request #20: COMPRESS-382

2017-04-25 Thread tballison
Github user tballison commented on a diff in the pull request: https://github.com/apache/commons-compress/pull/20#discussion_r113176495 --- Diff: src/main/java/org/apache/commons/compress/compressors/lzma/LZMACompressorInputStream.java --- @@ -56,7 +56,7 @@ public LZMACompressorIn

[GitHub] commons-compress pull request #20: COMPRESS-382

2017-04-25 Thread garydgregory
Github user garydgregory commented on a diff in the pull request: https://github.com/apache/commons-compress/pull/20#discussion_r113141961 --- Diff: src/main/java/org/apache/commons/compress/compressors/lzma/LZMACompressorInputStream.java --- @@ -56,7 +56,7 @@ public LZMACompresso

[GitHub] commons-compress pull request #20: COMPRESS-382

2017-04-25 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-compress/pull/20#discussion_r113141080 --- Diff: src/main/java/org/apache/commons/compress/compressors/lzma/LZMACompressorInputStream.java --- @@ -56,7 +56,7 @@ public LZMACompressorInputS