Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-compress/pull/20#discussion_r113141080
--- Diff:
src/main/java/org/apache/commons/compress/compressors/lzma/LZMACompressorInputStream.java
---
@@ -56,7 +56,7 @@ public LZMACompressorInputStream(final InputStream
inputStream)
in = new LZMAInputStream(inputStream,
MemoryLimit.getMemoryLimitInKb());
} catch (org.tukaani.xz.MemoryLimitException e) {
//convert to commons-compress exception
- throw new MemoryLimitException("exceeded calculated memory
limit", e);
+ throw new MemoryLimitException(e.getMemoryNeeded(),
e.getMemoryLimit());
--- End diff --
Not looking further into the source code of both MemoryLimitException
classes, couldn't this hide the root cause of the exception? As the original
`e` exception is ignored?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
