Hello all -
Recently, LANG-1167 was merged into commons-lang. It hit me today that one
of these method names seems a little funky. The class in question is
ReflectionToStringBuilder :
*https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/builder/ReflectionToStringBuilder.java#L719-L729
<https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/builder/ReflectionToStringBuilder.java#L719-L729>*

I added a boolean called "excludeNullValues" - this seems fairly
straightforward, but the generic getter for this would be called
"isExcludeNullValues".

Is it acceptable/worthwhile to change the method name to something a little
more intuitive to the end-user? Maybe something like "excludesNullValues"
or "isExcludingNullValues".


Perhaps the variable name could be changed as well, but it's in line with
the others (e.g., "outputTransients", but negated).

Thanks for your consideration.

Reply via email to