Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-216751340
I am getting this error during deploy DB "Specified key was too long; max
key length is 767 bytes". I have provided another inline comment in the code
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-216785465
LGTM. Verified before and after fix and things are working as expected. The
integration test works fine and properly cleans up stuff on completion.
---
If
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r62006414
--- Diff: server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java ---
@@ -205,14 +205,21 @@ public UserVmResponse newUserVmResponse(ResponseView
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-216847988
LGTM. Verified that a configuration entry is added with default 8 as pool
size. Increased the default threadpool size, restarted MS and verified that
when
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-217082822
@serg38 LGTM. Verified on my test env.
@swill This is ready for merge.
---
If your project is set up for it, you can reply to this email and have your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-217789291
@nvazquez The test results show that it took ~20mins to complete. Why list
tests are taking so long?
Some observations:
- Tests are not tagged, please
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1497#discussion_r62456142
--- Diff: test/integration/smoke/test_list_ids_parameter.py ---
@@ -0,0 +1,293 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1497#discussion_r62456186
--- Diff: test/integration/smoke/test_list_ids_parameter.py ---
@@ -0,0 +1,293 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-217798010
Thanks @rafaelweingartner for the updated PR.
LGTM based on code review and verification of PR on simulator.
---
If your project is set up for it, you can
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-217809810
@swill This has the required LGTMs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218047244
@swill As I had mentioned in my last comment, newly added tests are not
tagged. The command you used to run these tests has tags, don't pass any tags
in
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-218048251
@swill The failures doesn't look related to this PR. This can be merged.
---
If your project is set up for it, you can reply to this email and have your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218048625
@nvazquez My bad, didn't look at the changes. Thanks for the fixing the
tests.
---
If your project is set up for it, you can reply to this email and have
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218051058
LGTM, ran the new tests.
Test listing Volumes using 'ids' parameter ... === TestName:
test_01_list_volumes | Status : SUCCESS ===
o
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r62649582
--- Diff:
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
---
@@ -638,7 +638,9 @@ protected Void
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r62651265
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java
---
@@ -79,6 +80,25 @@
VMTemplateZoneDao
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r62652337
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java
---
@@ -984,7 +984,8 @@ public
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-218129820
Looks like nfs version is only supported for VMware. If XS or KVM clusters
are added to the zone (having nfs version set on image store) will there be any
side
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1615
I think this has all the necessary LGTMs.
@karuturi @jburwell Should I go ahead and merge this?
I thing fixing #1692 is fine but I see no reason to delay other PRs for
that when
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski If the LGTMs are there, this can get merged. There are lot
of comments so difficult to go through all of them.
---
If your project is set up for it, you can reply to this
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1702
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1701
@rhtyd Will destroy router show a similar message as stop router in UI?
All services provided by this virtual router will be interrupted. Please
confirm that you want to stop this router
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1698
Sql changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1701
Since services are disrupted when VR is destroyed, I think it would be
useful to provide a message similar to stop VR. Earlier only destroying a
stopped VR was possible from UI so caller
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1701
@rhtyd You are right, the message only makes sense for destroying running
VR. So some conditional check needs to be there for displaying the proper
message.
Based on the discussion
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1701
LGTM. Small comment on the message for running VR. "Please confirm... " is
appearing twice, only one would suffice.
---
If your project is set up for it, you can reply to this
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@jburwell @karuturi I haven't heard anything so assuming that this is good
to get merged.
I checked #1692 and all fixes (test and code) are related to network
related functionalit
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Thanks for the update @jburwell. While I agree that smoke tests needs to be
stabilized, I don't quite agree to the idea of blocking master for this.
Lot of commits have already
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@jburwell Was there a discussion thread for this on dev@, didn't remember
seeing one which mentions about freezing master.
These issues of test stability are known and were r
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r83789828
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServer700Resource.java
---
@@ -0,0 +1,32
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r83790292
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServer700Resource.java
---
@@ -0,0 +1,32
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r83789402
--- Diff: scripts/vm/hypervisor/xenserver/xenserver70/patch ---
@@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1726#discussion_r84837338
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -2199,15 +2199,20 @@ public void cleanupDownloadUrls(){
if
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r84839712
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java
---
@@ -128,7 +128,7 @@ public
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r84839559
--- Diff: engine/schema/src/com/cloud/vm/snapshot/VMSnapshotVO.java ---
@@ -248,4 +252,9 @@ public void setRemoved(Date removed) {
public
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r84841375
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -639,10 +648,57 @@ else if (jobResult instanceof Throwable
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r84839190
--- Diff: core/src/com/cloud/agent/api/VMSnapshotTO.java ---
@@ -35,6 +35,7 @@
private VMSnapshotTO parent;
private List volumes
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r84841681
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -610,7 +615,11 @@ public UserVm revertToSnapshot(Long vmSnapshotId
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r84839433
--- Diff: core/src/com/cloud/agent/api/VMSnapshotTO.java ---
@@ -123,4 +125,12 @@ public boolean getQuiescevm() {
public void setQuiescevm
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1726#discussion_r84862649
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -2199,15 +2199,20 @@ public void cleanupDownloadUrls(){
if
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r85050747
--- Diff: setup/db/db/schema-4910to41000.sql ---
@@ -35,4 +35,192 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,
hypervisor_type
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1711
One small comment, rest of the code LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1726
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Can you share the details about StoragePoolTagsDaoImpl class and its super
classes? Looks like in the hierarchy a default ctor is missing.
On 03/11/16, 12:09 AM, "Nicolás Vázquez" wrote:
Hi all,
I've been having troubles creating a new DAO on cloud-engine-schema.
Specifically,
Add a default ctor for StoragePoolTagVO class.
On 03/11/16, 6:36 PM, "Nicolás Vázquez" wrote:
Sure, thanks guys. This is the link to commit I'm working on:
https://github.com/nvazquez/cloudstack/commit/62d6c0c06a1cd51b0adec5d896c45e574d2daab1
2016-11-03 8:15 GM
Config enum is legacy code. For any new configuration parameters ConfigDepot
should be used. Some of the parameters got moved from Config enum to the
appropriate manager classes (where it is getting used). But there are still lot
of them left to be moved. Feel free to submit a PR for moving some
Tel: (+354) 415 0200
j...@greenqloud.com
www.greenqloud.com
On Mon, Nov 7, 2016 at 11:15 AM, Koushik Das
wrote:
> Config enum is legacy code. For any new configuration parameters
> ConfigDepot should be used. Some of the parameters got moved from Con
Please share the code/PR if possible.
From: Syed Ahmed
Reply-To: "dev@cloudstack.apache.org"
Date: Tuesday, 8 November 2016 at 10:49 PM
To: "dev@cloudstack.apache.org"
Subject: Re: Adding a Config value to Cloudstack
Yes init is destructive. Unfortunately it was the only option that I had. Sin
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r87754997
--- Diff: scripts/vm/hypervisor/xenserver/setup_heartbeat_sr.sh ---
@@ -72,7 +72,7 @@ else
fi
rm $link -f
fi
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r87758702
--- Diff: scripts/vm/hypervisor/xenserver/setup_heartbeat_sr.sh ---
@@ -72,7 +72,7 @@ else
fi
rm $link -f
fi
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1586
Merging as all the required LGTMs are there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1640
I had already mentioned in a previous comment that there is no need for
this PR in 4.9/master. So that means a -1.
---
If your project is set up for it, you can reply to this email and
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@nvazquez Can you add use case details that will be addressed by these new
methods? Also what kind of validation will be performed on the inputs and the
state of the entity (VM or template
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1640
@marcaurele Thats correct. In case of shared/remote storage the same disk
is used to spawn a VM on another host once the VM is successfully fenced. If
the fencer has successfully fenced off
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@serg38 @nvazquez Thanks for the update. As I understand form some of the
detail parameter examples, these are tied to the lifecycle of the entity
(create/destroy or start/stop of the VM
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1727
What about custom offerings? In case of custom offerings the cpu/ram are
stored in the VM details table? How will this case be handled?
---
If your project is set up for it, you can reply
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Option 2 is definitely better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1738
Code changes LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/1812
CLOUDSTACK-9650: Allow starting VMs regardless of cpu/memory cluster.â¦
â¦disablethreshold setting
Introduced a global configuration flag 'cluster.threshold.enabled'. B
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1794#discussion_r91235138
--- Diff: setup/db/db/schema-4910to41000.sql ---
@@ -45,4 +45,48 @@ CREATE TABLE `cloud`.`vlan_details` (
`display` tinyint(1) NOT NULL
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1722#discussion_r91252945
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -260,11 +260,15 @@ public
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1722#discussion_r91252165
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -260,11 +260,15 @@ public
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1722#discussion_r91251778
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -260,11 +260,15 @@ public
Github user koushik-das closed the pull request at:
https://github.com/apache/cloudstack/pull/1812
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user koushik-das reopened a pull request:
https://github.com/apache/cloudstack/pull/1812
CLOUDSTACK-9650: Allow starting VMs regardless of cpu/memory cluster.â¦
â¦disablethreshold setting
Introduced a global configuration flag 'cluster.threshold.enabled
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/1825
CLOUDSTACK-9660: NPE while destroying volumes during 1000 VMs deploy â¦
â¦and destroy tests
NPE is seen as VM destroy and storage cleanup threads try to remove the
same root
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1812
OOM on HV won't happen, only cluster threshold check is skipped in case of
starting a stopped VM
---
If your project is set up for it, you can reply to this email and have your
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1829
@syed Please check #672. There was a discussion sometimes back on dev@ and
this PR was mentioned. I feel that fix is slightly better than removing the
check altogether.
---
If your
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1829
Changes LGTM. As @syed mentioned there is a workaround, so won't qualify as
a blocker.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1711
Code changes are good. In the last test run I am seeing
test_01_primary_storage_iscsi is failing. Do we know the reason for that?
---
If your project is set up for it, you can reply to
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1856#discussion_r93603576
--- Diff: core/src/com/cloud/agent/api/SetHostParamsCommand.java ---
@@ -0,0 +1,43 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1881
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1841
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1850
Code changes LGTM. Can you add some unit/marvin tests for the scenario that
you have mentioned?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1844
LGTM. Unit tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1861#discussion_r94206888
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -839,7 +840,12 @@ private int
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1861#discussion_r94206618
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -230,6 +230,7 @@
import
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1861#discussion_r94206556
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
---
@@ -123,12 +125,14 @@
import
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1882
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1829
@pdube The description mentions about a way to workaround the problem,
thats the reason for not calling it a blocker. If you think the issue is
important for the current 4.9 release, please
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1886#discussion_r94721965
--- Diff: core/src/com/cloud/network/resource/TrafficSentinelResource.java
---
@@ -228,6 +239,7 @@ private DirectNetworkUsageAnswer
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1812
Looks like this is ready for merge. None of the test failures are related
to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/1899
CLOUDSTACK-9650: Allow starting VMs regardless of cpu/memory cluster.â¦
â¦disablethreshold setting
Fixed the scope of configuration flag 'cluster.threshold.enabled'
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1899
@ustcweizhou please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1812
@rhtyd Sure will let you know if trillian tests are needed. In this case XS
test results were already there from @cloudmonger. I used the git-pr script but
not sure why the merge commit
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95514039
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -350,6 +368,24 @@ public VMSnapshot allocVMSnapshot(Long vmId, String
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95515374
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -338,10 +354,12 @@ public VMSnapshot allocVMSnapshot(Long vmId, String
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95517419
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95517522
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -643,6 +679,65 @@ else if (jobResult instanceof Throwable
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95514745
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95517926
--- Diff: setup/db/db/schema-490to4910.sql ---
@@ -71,3 +71,17 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95516498
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95516609
--- Diff: engine/schema/src/com/cloud/vm/UserVmDetailVO.java ---
@@ -80,4 +80,8 @@ public boolean isDisplay() {
return display
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1899
Merging this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1899
@rhtyd Tests are present in #1812
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1892
@sureshanaparti please post a screen shot of the UI change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1899
@rhtyd If you had checked #1812 you wouldn't have asked these questions :)
This config was introduced in #1812 and the scope was incorrectly put as
zone, the config is meant to
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1852
@rashmidixit Code LGTM. Please provide screenshots of the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1848
@rashmidixit Please provide screenshots for UI changes (better if you also
provide screenshot prior to the fix). Also for a cluster enabled/disabled and
managed/unmanaged are different
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1889#discussion_r95973392
--- Diff: ui/scripts/ui-custom/migrate.js ---
@@ -0,0 +1,127 @@
+// Licensed to the Apache Software Foundation (ASF) under one
--- End diff
801 - 900 of 926 matches
Mail list logo
