Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r62651265
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java
---
@@ -79,6 +80,25 @@
VMTemplateZoneDao _vmTemplateZoneDao;
@Inject
AlertManager _alertMgr;
+ @Inject
+ ImageStoreDetailsDao _imageStoreDetailsDao;
+
+ private static final String NFS_VERSION_DETAILS_KEY = "nfs.version";
--- End diff --
I know this was added as part of a previous commit, but not sure if this
the right place to put nfs version related details. What if the image store
type is not NFS but SWIFT/S3/CIFS? I think there needs to be a better
abstraction of the properties based on store type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
