Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95517419
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long
vmSnapshotId) throws Insuffici
throw new InvalidParameterValueException("There is other
active vm snapshot tasks on the instance, please try again later");
}
+ revertUserVmDetailsFromVmSnapshot(userVm, vmSnapshotVo);
+
try {
VMSnapshotStrategy strategy =
findVMSnapshotStrategy(vmSnapshotVo);
strategy.revertVMSnapshot(vmSnapshotVo);
+ updateUserVmServiceOffering(userVm, vmSnapshotVo);
--- End diff --
Service offering and details update should be done in a transaction once
the snapshot revert completes successfully provided there is no agent call
happening as part of _userVmManager.upgradeVirtualMachine()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
