Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1861#discussion_r94206556
  
    --- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ---
    @@ -123,12 +125,14 @@
     import com.cloud.utils.ssh.SshHelper;
     import com.cloud.vm.DomainRouterVO;
     
    -public class VmwareManagerImpl extends ManagerBase implements 
VmwareManager, VmwareStorageMount, Listener, VmwareDatacenterService {
    +public class VmwareManagerImpl extends ManagerBase implements 
VmwareManager, VmwareStorageMount, Listener, VmwareDatacenterService, 
Configurable {
         private static final Logger s_logger = 
Logger.getLogger(VmwareManagerImpl.class);
     
         private static final int STARTUP_DELAY = 60000;                 // 60 
seconds
         private static final long DEFAULT_HOST_SCAN_INTERVAL = 600000;     // 
every 10 minutes
     
    +    public static final ConfigKey<Long> s_vmwareNicHotplugWaitTimeout = 
new ConfigKey<Long>("Advanced", Long.class, "vmware.nic.hotplug.wait.timeout", 
"20000",
    --- End diff --
    
    Earlier the hardcoded wait was 15000 ms, now you have made the default as 
20000 ms. Is this intended?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to