Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43043433
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -114,7 +115,9 @@ public Network design
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43043984
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -129,66 +132,93 @@ public Network design
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43044473
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -358,19 +441,22 @@ private String
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43044620
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -201,51 +234,82 @@ public NicProfile
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43045509
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -409,8 +472,8 @@ private HostVO
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43046732
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -67,25 +74,76 @@
import
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43048038
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43050493
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43050571
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43050603
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43050866
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43050959
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43051815
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43052201
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43052276
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43052507
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43052473
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43053203
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -170,20 +169,18 @@ public boolean configure
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43053334
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -191,36 +188,26 @@ public boolean configure
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43053663
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java
---
@@ -19,28 +19,101 @@
package
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43053698
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java
---
@@ -19,28 +19,101 @@
package
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43053678
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java
---
@@ -19,28 +19,101 @@
package
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43053099
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -112,8 +111,8 @@ public boolean configure
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43052957
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -348,6 +866,6 @@ public String
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-151287245
@KrisSterckx @nlivens overall, this PR is looking good. I found a few
more items. and we have a few outstanding bits of feedback to complete. Also,
don't f
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-152150034
@wido we can burn the IPv6 bridge when the time comes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/commit/2783cf540b15323b9fc1e0ced0ad850f694ed479#commitcomment-14123311
In server/src/com/cloud/vm/UserVmManagerImpl.java:
In server/src/com/cloud/vm/UserVmManagerImpl.java on line 1367
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/commit/2a2d4364e14903d51cdc3d3a7b4e2eb979a60445#commitcomment-14123387
In
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
In
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153051926
@KrisSterckx I will re-review late today or early tomorrow. Also, please
bear in mind that master is current frozen. Therefore, approval of this PR
will simply
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153351842
@remibergsma agree regarding the rebase effort. However, I am not going to
spend time testing now knowing that it will need to be retested when master is
unfrozen
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153369716
@KrisSterckx this plugin is part of the code that is the responsibility of
the community. Therefore, we need to verify its operation in addition to the
core
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153418530
@KrisSterckx it not a matter of trust. By contributing this code to our
community, we are responsible for its long-term support and maintenance.
Therefore, we
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153473377
@ustcweizhou @remibergsma this is a massive technical debt that we are
carrying with other plugins, and I think we need to stop to expanding that
debt. In some
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153822915
I agree with @runseb that we need to move this discussion to dev@, and
re-assess accepting the maintenance responsibly for code that cannot be tested
and verified
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-154200225
:+1: LGTM
@nlivens excellent work -- much appreciate the hard work.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-157709261
@PaulAngus the change looks reasonable. Have you checked upgrading the RPM
to ensure that the any modified logrotate configuration files are left alone?
---
If
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1089#issuecomment-157899791
Assuming Jenkin passes, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack-www/pull/20#issuecomment-159575622
@karuturi the repos currently listed on the [Downloads
page](http://cloudstack.apache.org/downloads.html) are not under community
control. Furthermore, the
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack-www/pull/20#issuecomment-159578241
@karuturi reference to the vote/agreement regarding apt-get.eu repositories
being agreed as some sort of "official" distribution. I do not recall the
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-160941719
@remibergsma I think all PRs should be squashed. This one is no exception.
;)
---
If your project is set up for it, you can reply to this email and have your
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-160978288
@remibergsma we have fixed a few additional defects and UI design cleanup
which are currently being verified. My hope is that we get everything squared
away in
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1159#issuecomment-161876783
Master is now 4.7.0. Therefore, these database changes should be in
``schema-460to470.sql`` and ``schema-461to470.sql`` files.
---
If your project is set up for
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1152#discussion_r46649429
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/user/ListKeysCmd.java ---
@@ -0,0 +1,72 @@
+// Licensed to the Apache Software Foundation
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1152#discussion_r46649508
--- Diff: api/src/com/cloud/user/AccountService.java ---
@@ -136,4 +140,6 @@ void checkAccess(Account account, AccessType
accessType, boolean sameOwner
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1108#issuecomment-161877685
@rafaelweingartner I agree. The use of "_" has no place in modern Java
code. Constants should be all caps with _ separators. Everything else
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1142#discussion_r46650119
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1276,6 +1277,53 @@ public String toString
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1142#discussion_r46650221
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1276,6 +1277,53 @@ public String toString
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-161975241
@PaulAngus sounds like a reasonable solution to preserve custom logrotate
configurations on update. Can you push update the PR to remove commit ec698f5?
---
If
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162211091
I will review the code later today/this evening. I will also verify that
all of our known issues have been addressed.
> On Dec 4, 2015, at 6:13 PM, R
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46777687
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java
---
@@ -111,6 +111,30 @@ public Long getProjectId
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46777696
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java
---
@@ -111,6 +111,30 @@ public Long getProjectId
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r4622
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade461to470.java ---
@@ -51,8 +53,23 @@ public boolean supportsRollingUpgrade
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r4624
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade461to470.java ---
@@ -51,8 +53,23 @@ public boolean supportsRollingUpgrade
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r4638
--- Diff: engine/schema/src/com/cloud/usage/UsageVO.java ---
@@ -328,4 +339,48 @@ public Date getStartDate() {
public Date getEndDate
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r4633
--- Diff: engine/schema/src/com/cloud/usage/UsageVO.java ---
@@ -328,4 +339,48 @@ public Date getStartDate() {
public Date getEndDate
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46777893
--- Diff: framework/db/src/com/cloud/utils/db/Transaction.java ---
@@ -35,18 +35,15 @@
if (currentTxn != null) {
databaseId
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46782245
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java ---
@@ -0,0 +1,408 @@
+//Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46782964
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/QuotaStatementImpl.java ---
@@ -0,0 +1,376 @@
+//Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46782968
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/QuotaStatementImpl.java ---
@@ -0,0 +1,376 @@
+//Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46783089
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaConfig.java ---
@@ -0,0 +1,53 @@
+//Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46783125
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaConfig.java ---
@@ -0,0 +1,53 @@
+//Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46783314
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java ---
@@ -0,0 +1,131 @@
+//Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46783388
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/QuotaUsageVO.java ---
@@ -0,0 +1,177 @@
+//Licensed to the Apache Software Foundation
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46783384
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/QuotaUsageVO.java ---
@@ -0,0 +1,177 @@
+//Licensed to the Apache Software Foundation
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46783406
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/QuotaUsageVO.java ---
@@ -0,0 +1,177 @@
+//Licensed to the Apache Software Foundation
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784092
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaStatementTest.java ---
@@ -0,0 +1,248 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784117
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaStatementTest.java ---
@@ -0,0 +1,248 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784126
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaStatementTest.java ---
@@ -0,0 +1,248 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784145
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaStatementTest.java ---
@@ -0,0 +1,248 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784176
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaStatementTest.java ---
@@ -0,0 +1,248 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784185
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaStatementTest.java ---
@@ -0,0 +1,248 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784229
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784268
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784283
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784327
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784388
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784395
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784408
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784435
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784536
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -0,0 +1,125 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784547
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -0,0 +1,125 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784552
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -0,0 +1,125 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784560
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -0,0 +1,125 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784609
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,141 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784622
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,141 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784639
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,141 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784674
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,141 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784709
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,141 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784756
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffListCmd.java
---
@@ -0,0 +1,95 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784764
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffUpdateCmd.java
---
@@ -0,0 +1,102 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784798
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffUpdateCmd.java
---
@@ -0,0 +1,102 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784827
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaBalanceResponse.java
---
@@ -0,0 +1,153 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784820
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaBalanceResponse.java
---
@@ -0,0 +1,153 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784850
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaBalanceResponse.java
---
@@ -0,0 +1,153 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784880
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaBalanceResponse.java
---
@@ -0,0 +1,153 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784930
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java
---
@@ -111,6 +111,30 @@ public Long getProjectId
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784960
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,516 @@
+//Licensed to the
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784966
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,516 @@
+//Licensed to the
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46785050
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaStatementResponse.java
---
@@ -0,0 +1,130 @@
+//Licensed to the Apache
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162403577
@remibergsma I have reviewed the code. I found a couple of minor issues.
Namely, that dates are not being defensively copied in a variety of places.
These fixes
201 - 300 of 1884 matches
Mail list logo
