Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162403577
@remibergsma I have reviewed the code. I found a couple of minor issues.
Namely, that dates are not being defensively copied in a variety of places.
These fixes are very simple to implement. The only other items I noticed were
a number of unit test methods with no asserts. Hopefully, it will be
relatively simple to add some asserts to verify correctness of the methods
being tested.
/cc @abhinandanprateek @bhaisaab
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
