Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/768#discussion_r46777733
  
    --- Diff: engine/schema/src/com/cloud/usage/UsageVO.java ---
    @@ -328,4 +339,48 @@ public Date getStartDate() {
         public Date getEndDate() {
             return endDate;
         }
    +
    +    public void setId(Long id) {
    +        this.id = id;
    +    }
    +
    +    public void setType(String type) {
    +        this.type = type;
    +    }
    +
    +    public void setStartDate(Date startDate) {
    +        this.startDate = startDate;
    --- End diff --
    
    Since Date instances are mutable, the ``this.startDate`` should be a copy 
of ``startDate`` to avoid side-effects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to