[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-08-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1638 Trillian test result (trillian-pr1638-46-kvm-centos68-cs410): Test completed. 45 look ok, 7 have errors Test | Result | Time --- | --- | --- test_01_updatevolumedetail

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

2016-08-23 Thread marcaurele
Github user marcaurele commented on the issue: https://github.com/apache/cloudstack/pull/1640 @koushik-das > If the MS is not able to determine the state of the VM, it tries fencing off the VM (using the various fencers available). If VM cannot be fenced off successfully, the sta

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

2016-08-23 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1646 code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack issue #1654: Updating pom.xml version numbers for release 4.8.2.0...

2016-08-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1654 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1654 Job ID-98 --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

2016-08-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1623 Trillian test result (trillian-pr1623-38-vmware-55u3-cs48): Test completed. 37 look ok, 12 have errors Test | Result | Time --- | --- | --- test_createRegion | Success

[GitHub] cloudstack pull request #1655: Fix ajaxviewer.js to solve console on Firefox

2016-08-23 Thread lygutas
GitHub user lygutas opened a pull request: https://github.com/apache/cloudstack/pull/1655 Fix ajaxviewer.js to solve console on Firefox Mozilla Firefox displays white tile in place of cursor. The reason - function isImageLoaded() always returns true after first load and function ch

[GitHub] cloudstack pull request #1656: CLOUDSTACK-9466: Fix fk constraint failure in...

2016-08-23 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1656 CLOUDSTACK-9466: Fix fk constraint failure in upgrade path In the 4.1.0-4.2.0 db upgrade path, it creates new tables to store secondary (nfs) storage in image_store table and volumes in volume

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 @jburwell yes that and we can also verify from packages that the version is reflected in the pkg names. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 Given we've enough reviews and tests (Travis) passing, I'll go ahead merge this and merge this fwd to master. On master, I'll send another PR that changes code version to 4.10.0.0-SNAPSHOT. ---

[GitHub] cloudstack-docs-admin issue #40: index.po and ui.po translated in FR

2016-08-23 Thread lmrv
Github user lmrv commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/40 Hi Rajani, hi Milamber My name is Antoine, I come from France. I actually work on a CloudStack plateform. I really miss a french translation of the admin doc, so I star

[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1656 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...

2016-08-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1656 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...

2016-08-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1656 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1656 Job ID-99 --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9....

2016-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1646 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1630: Add projectid to project details page

2016-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1630 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

2016-08-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1646 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1648 @jburwell sure, looks like it failed again for one of the tests (failed to cleanup domain), I'll debug this. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request #1648: test/integration: fix tearDown order in list_...

2016-08-23 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1648 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1648: test/integration: fix tearDown order in list_...

2016-08-23 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1648 test/integration: fix tearDown order in list_acl_ tests test/integration: fix tearDown order in list_acl_ tests In several of the list_acl_tests, the tests run for simulator onl

Re: Compilation error "Execution cloudstack-checklicence of goal com.mycila:license-maven-plugin:2.11:check failed"

2016-08-23 Thread Rohit Yadav
Hi B, This seems like a network issue to me, you may try changing networks and see if that works, or identify if there are any firewall policies in your network barring you to access those url resources. Regards. From: B Prakash Sent: 23 August 2016 10:22:45

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

2016-08-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1646 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1646 Job ID-100 --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 Fwd-merged this to master, with db version on master fixed during merge conflict to 4.10.0.0-SNAPSHOT, and db paths fixed as 4.9.0->4.9.1->4.10.0. --- If your project is set up for it, you can re

[GitHub] cloudstack issue #1655: Fix ajaxviewer.js to solve console on Firefox

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1655 LGTM. @lygutas can you share a screenshot, before/after? @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cloudstack issue #1655: Fix ajaxviewer.js to solve console on Firefox

2016-08-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1655 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

2016-08-23 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1623 It's been amended and rebased. I still haven't had time to add a new DAO method to the IP address DAO. I can work on that now though. When is the RC being cut? --- If your project is set u

[GitHub] cloudstack issue #1655: Fix ajaxviewer.js to solve console on Firefox

2016-08-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1655 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1655 Job ID-101 --- If your project is set up for it, you can reply to this email a

Re: Eliminating Support for Ubuntu 12.04

2016-08-23 Thread Rohit Yadav
Historically, CloudStack's debian/deb packages/repositories have never been supported by the initial authors. For example, initial ACS version and all CCP releases never shipped deb packages, nor in our (old and recent) documentation we promote installation/running CloudStack on Debian/Ubuntu. A

[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1599 Due to changes in marvin, specifically the code generator that runs during build-time and is not used with either Travis or otherwise, manual tests have confirmed the functionality working. With e

[GitHub] cloudstack pull request #1599: Marvin: Fix codegenerator to work with API di...

2016-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1634: [blocker] CLOUDSTACK-9452: add python-argparse depen...

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1634 @jburwell thanks - I've fixed the markdown issues -- see this for example -- https://github.com/apache/cloudstack/pull/1638#issuecomment-241644475 - I'll fix the sorting issues, to so

[GitHub] cloudstack issue #1634: [blocker] CLOUDSTACK-9452: add python-argparse depen...

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1634 We've enough LGTMs and test result (with vmware), I'll fire another Trillian job with KVM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: Eliminating Support for Ubuntu 12.04

2016-08-23 Thread Wido den Hollander
> Op 23 augustus 2016 om 11:38 schreef Rohit Yadav : > > > Historically, CloudStack's debian/deb packages/repositories have never been > supported by the initial authors. For example, initial ACS version and all > CCP releases never shipped deb packages, nor in our (old and recent) > document

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1593 @serg38 sorry the `test` keyword is restricted to RMs and few other people for now. There are failure that causes initial setup to fail. Can you confirm if this (mgmt server and usage server) work

[GitHub] cloudstack pull request #1656: CLOUDSTACK-9466: Fix fk constraint failure in...

2016-08-23 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1656 CLOUDSTACK-9466: Fix fk constraint failure in upgrade path In the 4.1.0-4.2.0 db upgrade path, it creates new tables to store secondary (nfs) storage in image_store table and volumes in volu

[GitHub] cloudstack pull request #1656: CLOUDSTACK-9466: Fix fk constraint failure in...

2016-08-23 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1656 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-08-23 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1645 It seems good, but I'm worried if the management server is also aware if this. The Answer going back to the mgmt server needs to tell it that the format became QCOW2. I don't have a test e

[GitHub] cloudstack pull request #1657: CLOUDSTACK-9467: Add symlink to key file for ...

2016-08-23 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1657 CLOUDSTACK-9467: Add symlink to key file for usage server On fresh installation, the usage server fails to start if the `key` file does not exist in its classpath. The issue is reproducible i

[GitHub] cloudstack issue #1657: CLOUDSTACK-9467: Add symlink to key file for usage s...

2016-08-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1657 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack pull request #1624: Fixes regarding VOLUME_DELETE events resultin...

2016-08-23 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1624#discussion_r75853547 --- Diff: server/test/com/cloud/user/AccountManagerImplTest.java --- @@ -231,6 +253,73 @@ public void cleanup() { CallContext.unregister(

[GitHub] cloudstack issue #1657: [lts/blocker] CLOUDSTACK-9467: Add symlink to key fi...

2016-08-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1657 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1657 Job ID-102 --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-08-23 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 Has been rebased against latest 4.8 and the `TODO` comments removed. The map was left alone though. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack issue #1657: [lts/blocker] CLOUDSTACK-9467: Add symlink to key fi...

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1657 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1657: [lts/blocker] CLOUDSTACK-9467: Add symlink to key fi...

2016-08-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1657 @rhtyd a Trillian-Jenkins test job (centos6 mgmt + vmware-55u3) has been kicked to run smoke tests against packages at http://packages.shapeblue.com/cloudstack/pr/1657 --- If your projec

[GitHub] cloudstack-docs-admin issue #40: index.po and ui.po translated in FR

2016-08-23 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/40 I'll review this PR, give me few days... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...

2016-08-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1656 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cloudstack issue #1657: [lts/blocker] CLOUDSTACK-9467: Add symlink to key fi...

2016-08-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1657 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-08-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rhtyd Confirming. No issues on usage and management servers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

2016-08-23 Thread Sergey Levitskiy
@koushik-das Actually there are 3 default VPC offerings. Default VPC offering Redundant VPC offering Nuage VSP VPC Offering The last 2 were introduced in May. VPC offering becomes default if 4th parameter is true in createVpcOffering e.g. createVpcOffering(nuageVPCOfferingName, nuageVPCOfferi

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

2016-08-23 Thread NuxRo
Github user NuxRo commented on the issue: https://github.com/apache/cloudstack/pull/1653 So, you guys kind of lost me, all I want is my VRs not to be used in DNS reflection attacks. Do we have a go or does it break things? :) --- If your project is set up for it, you can reply to

[GitHub] cloudstack issue #1591: Updating Alert codes

2016-08-23 Thread dcarbone
Github user dcarbone commented on the issue: https://github.com/apache/cloudstack/pull/1591 @jburwell: JIRA ticket created: https://issues.apache.org/jira/browse/CLOUDSTACK-9468 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-08-23 Thread nvazquez
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1593 @jburwell Sure, they are squashed now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC

2016-08-23 Thread kiwiflyer
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606 John, I'll defer to Aaron on this, as he submitted the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request #1658: Added an additional JSON diff output to the A...

2016-08-23 Thread swill
GitHub user swill opened a pull request: https://github.com/apache/cloudstack/pull/1658 Added an additional JSON diff output to the ApiXmlDocReader The original TXT diff format is very hard to work with if you are trying to programmatically use the output to generate documentation.

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-08-23 Thread kiwiflyer
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1645 For reference, here are the DB entries: ![snapshot_ref](https://cloud.githubusercontent.com/assets/17278194/17900963/086b4146-6927-11e6-9885-5f91b53f85c2.png) ![snapshot_stor

[GitHub] cloudstack issue #1634: [blocker] CLOUDSTACK-9452: add python-argparse depen...

2016-08-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1634 Trillian test result (trillian-pr1634-49-kvm-centos68-cs49): Test completed. 45 look ok, 7 have errors Test | Result | Time (s) --- | --- | --- test_04_rvpc_privat

[GitHub] cloudstack issue #1654: Updating pom.xml version numbers for release 4.8.2.0...

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1654 I think a db upgrade path is missing causing Travis failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-23 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1605 @nvazquez, Very nice proposal this one. I have only very small suggestions, which are the following: * The method “videoCardConfig”, would be better if called “configure

[GitHub] cloudstack issue #1560: CLOUDSTACK-9386: DS template copies don’t get dele...

2016-08-23 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1560 LGTM from me here ;) thanks @serg38 and @nvazquez for the hard work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-08-23 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1645 What I see to remember somehow is that the management server/code always thinks a snapshot is in the same format as the base image was. So when you try to do something with this snapshot it

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-08-23 Thread kiwiflyer
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1645 Yeah, there seems to be some black magic going on here. We'll dig into this a bit more. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-08-23 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1645 @kiwiflyer @nathanejohnson as part of your continued evaluation, can you evaluate the following test cases to ensure this new behavior is verified and regression tested: * ``smoke/test

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-23 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1605 @serg38 looking through PR #1310, I don't see any Marvin test cases to exercising this behavior. @nvazquez please add Marvin tests to exercise specifying vGPU parameters when creatin

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-08-23 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1593 @abhinandanprateek do you have time to test this PR when upgrading a a clustered usage server environment from 4.9 to master? --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1591: Updating Alert codes

2016-08-23 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1591 @dcarbone thanks for creating a JIRA ticket. Could you please prepend the headline of your commit message with the ticket ID (i.e. [CLOUDSTACK-9468])? Additionally, the Travis build is failin

[GitHub] cloudstack issue #1657: [lts/blocker] CLOUDSTACK-9467: Add symlink to key fi...

2016-08-23 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1657 @rhtyd do you see any potential conflict between this PR and PR #1593? Also, the Travis build failed. Could you please investigate? --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-08-23 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1645 @nathanejohnson could you please create JIRA ticket for this issue and prepend the commit message with the ID? --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...

2016-08-23 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1656 @rhtyd would it be possible to re-target this PR to the 4.8 branch? It seems like a good fix to include in 4.8.2.0 as well as 4.9.1.0. --- If your project is set up for it, you can reply to t

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-23 Thread nvazquez
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1605 @rafaelweingartner Thanks for your review! I'll work on your suggestions! @jburwell Sure, I'll work on it --- If your project is set up for it, you can reply to this email and have your rep

JuniperSRX firewall configure plugin source bug

2016-08-23 Thread Gust
Hi , all There is a bug in com.cloud.network.resource.JuniperSrxResource It will report syntax error when configure outgress rule to Juniper srx hardware firewall. begin line 2830 : if (type.equals(SecurityPolicyType.SECURITYPOLICY_EGRESS_DEFAULT)) {

Re: Eliminating Support for Ubuntu 12.04

2016-08-23 Thread John Burwell
Wido, My only issue is dropping for any distro between patch releases. If someone is running 4.9.0.0 on Ubuntu 12.04, and they need to update to 4.9.1.0+ (e.g. to get a CVE fix), they will be stranded. This failure seems to fail the Law of Least Surprise. While I recognize that it is unlikel

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

2016-08-23 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1653 @NuxRo this patch does not appear to break things. However, we want to add a Marvin test case to verify that the fix does not regress again. Does that make sense? @rhtyd is planning

Re: JuniperSRX firewall configure plugin source bug

2016-08-23 Thread Jayapal Uradi
Hi Gust, The changes look good please go head and raise a PR for it. Thanks, Jayapal > On Aug 24, 2016, at 8:14 AM, Gust wrote: > > Hi , all > > There is a bug in com.cloud.network.resource.JuniperSrxResource > > It will report syntax error when configure outgress rule to Juniper srx > hardwa

Re: Eliminating Support for Ubuntu 12.04

2016-08-23 Thread Makrand
Guys, I am not sure on overall developer talk, but let me understand something here. Bit about setup:- So, at my new work place, we already have 5 zones (each zone with its own management server) with management node running on Ubuntu 12.04. ACS 4.4.2 and XENserver 6.2. It was setup by someone w

Re: Eliminating Support for Ubuntu 12.04

2016-08-23 Thread Wido den Hollander
> Op 24 augustus 2016 om 6:38 schreef John Burwell : > > > Wido, > > My only issue is dropping for any distro between patch releases. If someone > is running 4.9.0.0 on Ubuntu 12.04, and they need to update to 4.9.1.0+ (e.g. > to get a CVE fix), they will be stranded. This failure seems to

Re: Eliminating Support for Ubuntu 12.04

2016-08-23 Thread Wido den Hollander
> Op 24 augustus 2016 om 7:47 schreef Makrand : > > > Guys, > > I am not sure on overall developer talk, but let me understand something > here. > > Bit about setup:- > So, at my new work place, we already have 5 zones (each zone with its own > management server) with management node running o

[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1656 @jburwell fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1656 There are no upgrade tests to confirm the fix as all the changes are in an older 4.1.0->4.2.0 upgrade path. After this fix, here are manual test results to show that db upgrade finished cleanly wi

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1648 @jburwell can you review/lgtm now? thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack issue #1657: [lts/blocker] CLOUDSTACK-9467: Add symlink to key fi...

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1657 @jburwell no this is PR is related to packaging, while 1593 fixes something different. The Travis build failure has been fixed at #1648, the failures are unrelated to this PR. Since this is a pack

[GitHub] cloudstack issue #1634: [blocker] CLOUDSTACK-9452: add python-argparse depen...

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1634 Merging based on lgtms and test results (the failures are due to env issues, and failing tests not related to the pkging fix). --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request #1634: [blocker] CLOUDSTACK-9452: add python-argpars...

2016-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1634 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido based on the ML discussion, I've removed the specific change that removed 12.04 support. Can you send another PR for master for removing support for 12.04. --- If your project is set up fo