Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/1280#issuecomment-218381704
I don't find much value here in adding documentation as code seems to be
self explanatory. Regrading backward compatibility I have already answered in
my previou
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218398335
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
I don't have OSX, but it seems to be working on Travis and Linux env in general.
I'll send a PR that relaxes malicious client attacks, and ask you to review in
your env -- Koushik and Mike.
Regards,
Rohit Yadav
rohit.ya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1385
CLOUDSTACK-9265 cleanup around httpclient versions
some cleanup done
- replaced HttpStatus from org.apache.commons.httpclient with that from
org.apache.http
- removed unthrown Ht
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1538
NioTest: relax test counts to pass under timeout
Relaxes test count to pass under fixed test timeout (60s). With these
settings,
malicious clients can thereotically block main IO loop for a m
Please follow up on PR #1538 and comment if that fixes the issue on OSX.
Regards.
Regards,
Rohit Yadav
rohit.ya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London WC2N 4HSUK
@shapeblue
-Original Message-
From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]
Se
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819386
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819265
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819354
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819397
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819375
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218411583
I've rebased against latest master and pushed -f
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819412
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819537
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819651
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819915
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,329 @@
+// Licensed to the Apache Software Foundation (ASF) under
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62820395
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache Software Fo
Hi Will,
I am hitting an issue similar to CLOUDSTACK-9013 on master (4.9.0). Here
are the management server error logs:
2016-05-10 08:24:03,109 ERROR [c.c.n.r.VirtualNetworkApplianceManagerImpl]
(Work-Job-Executor-3:ctx-5069ea04 job-247/job-250 ctx-48a763a9)
(logid:2735b868) VR config: execution
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62824571
--- Diff: core/src/com/cloud/agent/api/routing/QuaggaConfigCommand.java ---
@@ -0,0 +1,86 @@
+//
+// Licensed to the Apache Software Fou
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218421442
@nvazquez can you check why test_03_list_snapshots failed in the Travis
run, with tearDown exception.
---
If your project is set up for it, you can reply to this ema
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62826214
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the A
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62826751
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the A
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62827143
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the A
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62827236
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the A
Prashanth,
it looks you still use the systemvm template 4.4.0. Please upload the new
systemvm template and test it again.
you can follow
http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.8.0/upgrade/upgrade-4.5.html
.
-Wei
2016-05-11 12:06 GMT+02:00 Prashanth Manthena <
pr
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62831265
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -1445,28 +1466,31 @@ public void
Hi Will,
I was able to put a break-point and debug the actual issue in the VR
(system VM template), it's a Python import error of the package "netaddr",
which can be fixed by updating the system template with the "netaddr"
package installed in it. Hopefully, it fixes this issue.
Here is the error
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62835972
--- Diff:
engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.java ---
@@ -62,7 +62,31 @@ protected VpcServiceMapDaoImpl() {
Hi Prashanth,
As Wei suggested, when you use CloudStack 4.6/4.7/4.8/4.9 you also need the
systemvm template with version 4.6.0. This does include the needed Python
modules. The 4.4 template you used won't fly. You will run into other missing
packages and changes as well.
Regards, Remi
Sent
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62837384
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -1048,4 +1052,33 @@ protected String getGuestDhcpRange(final NicPro
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-218446038
Remi,
I'm seeing some issues with this PR, related to the way the VR scripts
utilize the argv file name for other uses. We spent a fair bit of time trying
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218456049
Thank you sir. Unfortunately travis failed this time. Would you mind
trying it again. Thanks...
---
If your project is set up for it, you can reply to this email
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-218456885
@mike-tutkowski unfortunately it failed again. :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218458113
the travis logs seem to indicate that something is not working...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1280#issuecomment-218462063
@anshul1886 I think the ask is that it get extracted as a method and a test
be written for it. @pedro-martins and @alexandrelimassantana, I feel that this
might be a
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-218463825
@swill Is this claiming there's a license problem?
I can rebase and push again.
[INFO] Rat check: Summary of files. Unapproved: 1 unknown: 1 g
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-218465085
I have seen this happen periodically and it does not seem to be
consistently telling us the truth. This happens sometimes when only a single
line of code changes, so
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-218465795
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 4h 32m 05s
```
**Associ
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-218466093
I need one more code review and this one should be ready to merge.
@kiwiflyer did you have a chance to review this one?
---
If your project is set up for it, you ca
Github user serg38 commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218466672
@swill Last Travis run for this PR was a success for
test_list_ids_parameter. Which PR gives an issue?
Marvin Init Successful
=== TestName: tes
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218467920
@swill it's strange, as @serg38 says it succeeds for us and for
@koushik-das, I'll investigate. Is there any log of the failure?
---
If your project is set up for
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218468571
@rhtyd sure, I'll examine this. This tests are introduced in #1497, I'll
work on this
---
If your project is set up for it, you can reply to this email and have y
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218464050
@nvazquez this seems to have broken travis for everyone. We have this
issue showing up in pretty much all travis runs right now `ContextSuite
context=TestListIdsPara
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218469220
@serg38 I had a bunch of people re-push PRs last night and this morning to
get everything green and 3 or 4 are failing with this.
Here are a couple off the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-218467871
@swill I closed and reopened. It started building anew but is now stuck in
the archiving phase for quite some time.
```
[INFO]
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218470411
LGTM, @swill, I am being very formal but can you queue this for integration
tests?
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218472093
@marcaurele instead of force push you can close and reopen after a few
seconds. This usually works as well and seves you switching windows
browser->terminal->b
Thank you Wei & Remi !!
I will start using the latest system VM templates.
With regards,
Prashanth
On Wed, May 11, 2016 at 2:20 PM, Remi Bergsma
wrote:
> Hi Prashanth,
>
> As Wei suggested, when you use CloudStack 4.6/4.7/4.8/4.9 you also need
> the systemvm template with version 4.6.0. This d
Rohit, I have seen quite a few issues with this feature so far. The change
you made in #1538 does not change the actual code at all, it just reduces
the number of tests, so you are less likely to run into the problem, but
the problem still exists.
I am CCing in Simon Weller as well. I was talkin
Github user marcaurele closed the pull request at:
https://github.com/apache/cloudstack/pull/1532
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218473575
a timeout @swill. in travis that is not a good indication of not working. I
wouldn't know where to look. @rhtyd can you close and reopen?
---
If your project
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218473922
---
If your project is set up for it, you can re
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218473890
@rhtyd We're still seeing some odd behaviour related to the agent with this
PR (and PR1534) applied to 2 of our hardware labs. What we're seeing is 100%
cpu on th
I can't point to this PR for this, but I have noticed an increase in random
failures in my CI runs since this code has gone in. I have not tracked it
down to this, but resources are tight in those environments, so if we are
getting CPU maxing out, that could potentially account for the higher
fail
GitHub user marcaurele reopened a pull request:
https://github.com/apache/cloudstack/pull/1532
DAO: Hit the cache for entity flagged as removed too
I came along this part of the code and I don't see any reason why the cache
should not be used when fetching with the "removed" ones. I
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-218480720
That is the rat test. it is usually right. I didn't see a new file without
license though. May one of the to with a license starting with an empty comment
line
Hi,
I see in afcbd27 that we've deprecated commands.properties.in.
Is there documentation on the new way that we specify permissions for a given
API these days?
Thanks!
Mike
Github user serg38 commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218480013
The issue that it couldn't find a snaphsot because it is already cleaned by
account cleanup.
+cls._cleanup = [
+cls.disk_off
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-218483641
### CI RESULTS
```
Tests Run: 7
Skipped: 0
Failed: 4
Errors: 0
Duration: 0h 37m 50s
```
**Summary of the pr
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-218483982
The added test fails, but lots of tests failed. I will rebuild my
environment and test again to see if anything changes.
---
If your project is set up for it, you c
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218489998
Can you create a new PR to fix this and we will get it tested right away.
Thanks for being on top of this. ð
---
If your project is set up for it, you can repl
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-218489553
I think we are definitely having issues with it not cleaning correctly. I
have seen a couple cases where we get the "unable to update index" when it
tries to do a git
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62867309
--- Diff:
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreInfo.java
---
@@ -36,6 +36,7 @@
static final S
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62868269
--- Diff: engine/schema/src/com/cloud/dc/dao/ClusterDaoImpl.java ---
@@ -260,4 +268,41 @@ public boolean remove(Long id) {
sc.setParamet
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218499768
Done @swill @serg38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1539
CLOUDSTACK-9378: Fix for #1497
JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9378
After #1497 was merged, test_list_ids_parameter.py failed on Travis. It was
noticed t
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62872442
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ privat
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218500189
Thank you, I will merge it assuming Jenkins and Travis come back clean.
Thx... ð
---
If your project is set up for it, you can reply to this email and have your
I think this is the extent of the documentation at this point.
https://github.com/apache/cloudstack-docs-admin/pull/37/files
Rohit, maybe you can shed some light on this from a developer's perspective
and how we should be handling this going forward? Are there official docs
which covered how to
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62874090
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ privat
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218503116
@DaanHoogland well a timeout in combination with a connection is not being
able to be established seems relevant since it is related to the code that has
changed.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62875028
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +254,214 @@ privat
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218503981
I am testing now... ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-218505040
@DaanHoogland it finished!!! :P
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62875666
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -255,99 +473,123 @@ privat
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62876040
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225 @@ privat
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62876182
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +603,221 @@ privat
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62876283
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +603,221 @@ privat
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62878912
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -72,8 +77,10 @@
pri
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62879575
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -347,38 +395,87 @@ private S
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62880347
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -347,38 +395,87 @@ private S
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62880464
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -289,7 +291,7 @@ public boolean
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62880956
--- Diff:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
---
@@ -134,6 +146,14 @@
EndPointSelector
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62880949
--- Diff:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
---
@@ -134,6 +146,14 @@
EndPointSelector
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218514854
@rhtyd @kiwiflyer @swill a PR for fixing the problem #1539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62881152
--- Diff:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
---
@@ -554,6 +574,51 @@ protected Void
managedCop
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62881271
--- Diff:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
---
@@ -554,6 +574,51 @@ protected Void
managedCop
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218519246
@nvazquez I don't think #1539 is related to this PR. I think this one has
completely separate issues...
---
If your project is set up for it, you can reply to this
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218520519
@rhtyd @kiwiflyer @swill a PR for fixing the problem #1539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218520703
Sorry, I confused PRs. Please ignore my last comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218522071
No worries. ð I am really short on sleep, but I was pretty confident.
:P
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62885313
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -164,9 +165,12 @@
*
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62886063
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -1792,10 +1796,26 @@ protected v
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62886608
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -2351,17 +2376,52 @@ public SR g
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62890766
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java
---
@@ -665,22 +
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62890825
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java
---
@@ -692,12 +
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62891804
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -209,6 +211,8 @@
@Inject
protected HostDao _hostDao;
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62892193
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ private vo
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62892410
--- Diff: core/src/com/cloud/agent/api/StartupRoutingCommand.java ---
@@ -35,7 +35,7 @@
long memory;
long dom0MinMemory;
boole
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62892495
--- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ---
@@ -144,6 +145,8 @@
@Inject
SnapshotDataStoreDao _snap
1 - 100 of 152 matches
Mail list logo
