Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819397
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.vpc;
+
+import java.util.Map;
+
+import javax.inject.Inject;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.VPCOSPFConfigResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.log4j.Logger;
+
+import com.cloud.network.vpc.OSPFZoneConfig;
+import com.cloud.network.vpc.VpcProvisioningService;
+import com.cloud.user.Account;
+import com.cloud.utils.net.cidr.BadCIDRException;
+
+@APICommand(name = "vpcOSPFConfigUpdate", description = "Captures config
informaton for ospf zone level params", responseObject =
VPCOSPFConfigResponse.class, since = "4.9.0", requestHasSensitiveInfo = true)
+public class VPCOSPFConfigUpdateCmd extends BaseCmd {
+ public static final Logger s_logger =
Logger.getLogger(VPCOSPFConfigUpdateCmd.class);
+ private static final String s_name = "vpcospfconfigresponse";
+
+ /////////////////////////////////////////////////////
+ //////////////// API parameters /////////////////////
+ /////////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.ZONE_ID, type = CommandType.UUID,
entityType = ZoneResponse.class, required = true, description = "the ID of the
Zone")
+ private Long zoneid;
+
+ @Parameter(name = OSPFZoneConfig.s_protocol, type =
CommandType.STRING, required = false, description = "the password used to
secure inter ospf communication(default ospf)")
+ private String protocol;
+
+ @Parameter(name = OSPFZoneConfig.s_area, type = CommandType.STRING,
required = false, description = "Specify the OSPF Area ID")
+ private String area;
+
+ @Parameter(name = OSPFZoneConfig.s_helloInterval, type =
CommandType.SHORT, required = false, description = "Set number of seconds for
HelloInterval timer value.(default 10)")
+ private Short helloInterval;
+
+ @Parameter(name = OSPFZoneConfig.s_deadInterval, type =
CommandType.SHORT, required = false, description = "Set number of seconds for
RouterDeadInterval timer value used for Wait Timer and Inactivity
Timer.(default 40)")
+ private Short deadInterval;
+
+ @Parameter(name = OSPFZoneConfig.s_retransmitInterval, type =
CommandType.SHORT, required = false, description = "Set number of seconds for
RxmtInterval timer value.(default 5)")
+ private Short retransmitInterval;
+
+ @Parameter(name = OSPFZoneConfig.s_transitDelay, type =
CommandType.SHORT, required = false, description = "Set number of seconds for
InfTransDelay value.(default 1)")
+ private Short transitDelay;
+
+ @Parameter(name = OSPFZoneConfig.s_authentication, type =
CommandType.STRING, required = false, description = "Md5 or PlainText (default
MD5)")
--- End diff --
There is no default value in Parameter annotation. How will that work, like
if in request a field is empty fill it with default value if given ? I think it
may not be very useful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
