Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62824571
--- Diff: core/src/com/cloud/agent/api/routing/QuaggaConfigCommand.java ---
@@ -0,0 +1,86 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.agent.api.routing;
+
+import com.cloud.network.vpc.OSPFZoneConfig;
+import com.cloud.utils.net.cidr.CIDR;
+
+public class QuaggaConfigCommand extends NetworkElementCommand {
+
+ private String routerPublicIp;
+ private String routerName;
+ private String vpnCidr;
+ private CIDR[] tierCidrs;
+ private OSPFZoneConfig zoneConfig;
+
+ public QuaggaConfigCommand(final String routerPublicIp, final String
routerName, final String vpnCidr, final CIDR[] tierCidrs, final OSPFZoneConfig
qzc) {
--- End diff --
The tier cidrs are provided by the user. I think it would have mode more
sense if they were being generated automatically from a given cidr. So a method
that breaks a given cidr using a netmask into tiers would be a good application
of what you are suggesting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
