[GitHub] cloudstack pull request: CLOUDSTACK-8606: DB performance impacted ...

2015-07-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/553#issuecomment-117946484 Nice one! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8484 - Hosts without t...

2015-07-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/335#issuecomment-117951281 Code looks good, although I didn't test it yet. Before I do, I'd like to understand why do you want to push this to 4.5 and not to master? --- If your project i

[GitHub] cloudstack pull request: CLOUDSTACK-8439:Automation for feature CP...

2015-07-02 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/226#discussion_r33756445 --- Diff: test/integration/component/test_overcommit.py --- @@ -0,0 +1,458 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] cloudstack pull request: CLOUDSTACK-8439:Automation for feature CP...

2015-07-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/226#issuecomment-117956396 Apart from the typo it LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

IRC and Slack

2015-07-02 Thread Sebastien Goasguen
Hi folks, IRC has been mostly deserted for a while now. But there are still folks hanging out there with unanswered questions. I also know of several slack channels on cloudstack. We need to take a decision here. Shall we officially abandon IRC and out a notice there that points towards Slack.

Re: IRC and Slack

2015-07-02 Thread Erik Weber
On Thu, Jul 2, 2015 at 10:39 AM, Sebastien Goasguen wrote: > Hi folks, > > IRC has been mostly deserted for a while now. But there are still folks > hanging out there with unanswered questions. > > I also know of several slack channels on cloudstack. > > We need to take a decision here. Shall we

Re: IRC and Slack

2015-07-02 Thread Rene Moser
Hi On 02.07.2015 10:39, Sebastien Goasguen wrote: > We need to take a decision here. Shall we officially abandon IRC and out a > notice there that points towards Slack. -1 for abondon IRC. * IRC is simple and easy, well known and distributed. Not every question fits to IRC, thats ok. If it gets

[GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...

2015-07-02 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/532#issuecomment-117977659 @gauravaradhye if you answer my questions I can give a LGTM :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: This branch implements the CSV and native...

2015-07-02 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-117977973 @anshul1886 looks like it failed the tests. Can you check what's happening and correct accordingly ? --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8484 - Hosts without t...

2015-07-02 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/335#issuecomment-117978306 @sudhansu7 there is a question here from @remibergsma , can you answer it so it can get merged. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8483 - Private templat...

2015-07-02 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/334#issuecomment-117978565 @sudhansu7 can you reply to @karuturi ? thanks. Otherwise this will stay stuck waiting for your answer. --- If your project is set up for it, you can reply to this e

[GitHub] cloudstack pull request: CLOUDSTACK-8439:Automation for feature CP...

2015-07-02 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/226#issuecomment-117979269 @sanju1010 can you OK this now ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Issue:Domian admin can view templates in ...

2015-07-02 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/169#issuecomment-117979410 @manasaveloori can you address @gauravaradhye points above ? thanks --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...

2015-07-02 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/158#issuecomment-117979550 @gauravaradhye can you review this ? @srikanteswartalluri looks like Travis failed. --- If your project is set up for it, you can reply to this email and have your r

Re: [PROPOSAL] Commit to master through PR only

2015-07-02 Thread Daan Hoogland
Wilder, you are being to friendly IMHO here. I would actually -1 a PR that contains a commit that tries to do more then one thing. It is obfuscating and makes it harder to discuss implementations and fixes. in commit abcdef, in the part that fixes the NPE related to the network implementation of s

[GitHub] cloudstack pull request: CLOUDSTACK-8610. Unable to attach 7th Dis...

2015-07-02 Thread likitha
GitHub user likitha opened a pull request: https://github.com/apache/cloudstack/pull/554 CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2 … …instance. During disk attach, while trying to obtain the controller key for SCSI controller, look for device

[GitHub] cloudstack pull request: CLOUDSTACK-8608. System VM's failed to st...

2015-07-02 Thread likitha
GitHub user likitha opened a pull request: https://github.com/apache/cloudstack/pull/555 CLOUDSTACK-8608. System VM's failed to start due to permissions issue. …instance. You can merge this pull request into a Git repository by running: $ git pull https://github.com/likitha/c

[GitHub] cloudstack pull request: CLOUDSTACK-8609. [VMware] VM is not acces...

2015-07-02 Thread likitha
GitHub user likitha opened a pull request: https://github.com/apache/cloudstack/pull/556 CLOUDSTACK-8609. [VMware] VM is not accessible after a migration acro… …ss clusters. Once a VM is successfully started, don't delete the files associated with the unregistered VM, i

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...

2015-07-02 Thread Sanjeev N
if required_hardware=false means these tests can run on Simulator. On Thu, Jul 2, 2015 at 3:06 PM, runseb wrote: > Github user runseb commented on the pull request: > > https://github.com/apache/cloudstack/pull/532#issuecomment-117977659 > > @gauravaradhye if you answer my questions I ca

[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-7472: kvmclock fix for ...

2015-07-02 Thread kishankavala
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/557 BUG-ID:CLOUDSTACK-7472: kvmclock fix for LXC is not required after fixing CLOUDSTACK-8177 kvmclock fix for LXC is not required after fixing CLOUDSTACK-8177 You can merge this pull request

[DISCUSS] Release principles for Apache CloudStack

2015-07-02 Thread Remi Bergsma
Hi all, We already agreed contributions should always go via a PR and require two LGTM’s before we merge. Let me propose the next step on how I think we should do release management for 4.6 and on. I talked to several people over the past weeks and wrote this wiki article: https://cwiki.apache.

[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8483 - Private templat...

2015-07-02 Thread sudhansu7
Github user sudhansu7 commented on the pull request: https://github.com/apache/cloudstack/pull/334#issuecomment-118006807 @karuturi When a user switches to project view the ownership changes to project account. So any resource created inside project view should be mapped to proje

[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8483 - Private templat...

2015-07-02 Thread sudhansu7
Github user sudhansu7 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/334#discussion_r33769718 --- Diff: api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java --- @@ -215,33 +221,39 @@ public long getEntityOwnerId() {

[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8484 - Hosts without t...

2015-07-02 Thread sudhansu7
Github user sudhansu7 commented on the pull request: https://github.com/apache/cloudstack/pull/335#issuecomment-118007318 @remibergsma @runseb This issue exists in 4.5 , hence fixed it in 4.5. this can me merged to master as well. --- If your project is set up for it, you can r

Re: [DISCUSS] Release principles for Apache CloudStack

2015-07-02 Thread Daan Hoogland
be sure you're backed On Thu, Jul 2, 2015 at 1:46 PM, Remi Bergsma wrote: > Hi all, > > We already agreed contributions should always go via a PR and require two > LGTM’s before we merge. Let me propose the next step on how I think we should > do release management for 4.6 and on. > > I talked

Re: IRC and Slack

2015-07-02 Thread Erik Weber
On Thu, Jul 2, 2015 at 11:07 AM, Rene Moser wrote: > Hi > > On 02.07.2015 10:39, Sebastien Goasguen wrote: > > We need to take a decision here. Shall we officially abandon IRC and out > a notice there that points towards Slack. > > -1 for abondon IRC. > > * IRC is simple and easy, well known and

[GitHub] cloudstack pull request: CLOUDSTACK-8590 Refactoring NiciraNVP res...

2015-07-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/546#issuecomment-118009819 @karuturi I agree, we should only proceed after two LGTMs. Let met give the second LGTM, after the fact. --- If your project is set up for it, you can reply

RE: [DISCUSS] Release principles for Apache CloudStack

2015-07-02 Thread Kishan Kavala
Remi, Release process looks good to me. Can you also add some info about maintenance release? - After release, will the fixes go into x.y branch and merged back to master? - or bug fixes go into master and selectively merged back to x.y branch? -Original Message- From: Remi Bergsma [mai

Re: [DISCUSS] Release principles for Apache CloudStack

2015-07-02 Thread Erik Weber
How about bugfix PRs that involves refactored code between versions? Example: - 4.6.0 is released - SomeRandomFunction() is refactored - 4.7.0 is released - A bug is discovered in SomeRandomFunction() and applies to both 4.6.0 and 4.7.0 - A bugfix PR is sent to the 4.6 branch I

[GitHub] cloudstack pull request: CLOUDSTACK-8590 Refactoring NiciraNVP res...

2015-07-02 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/546#issuecomment-118011859 @remibergsma and @karuturi You are right. I believe both @bhaisaab and I forgot that. Once he said "go ahead with the merge" I just merged

Re: [DISCUSS] Release principles for Apache CloudStack

2015-07-02 Thread Remi Bergsma
Hi Erik, Kishan, Since the goal is a stable master, I’d say the bug fix should go to master first. This way we make sure all upcoming releases have the fix included. I’ll add this to the wiki. Then we should decide if the fix should go back to other release branches as wel. When we get a PR

[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8484 - Hosts without t...

2015-07-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/335#issuecomment-118020313 @sudhansu7 Let's first merge this to master, then it can go to 4.5. I just tried to merge your PR on master and that seems to work just fine so that is nice.

Re: [DISCUSS] Release principles for Apache CloudStack

2015-07-02 Thread Remi Bergsma
Thanks! Appreciate it :-) > On 02 Jul 2015, at 13:51, Daan Hoogland wrote: > > be sure you're backed > >> On Thu, Jul 2, 2015 at 1:46 PM, Remi Bergsma wrote: >> Hi all, >> >> We already agreed contributions should always go via a PR and require two >> LGTM’s before we merge. Let me propose t

[GitHub] cloudstack pull request: Vpcr Marvin test and some fixes for vprc

2015-07-02 Thread isoutham
GitHub user isoutham opened a pull request: https://github.com/apache/cloudstack/pull/558 Vpcr Marvin test and some fixes for vprc A combined commit because otherwise it would not make sense. If I commit the fixes alone there is not test to verify them If I commit the te

Re: [DISCUSS] Release principles for Apache CloudStack

2015-07-02 Thread Rene Moser
Hi Remi On 02.07.2015 13:46, Remi Bergsma wrote: > I talked to several people over the past weeks and wrote this wiki article: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack > >

[DISCUSS] LTS releases?

2015-07-02 Thread Rene Moser
Maybe a little bit off topic to the new release process, therefor a new thread... speaking about releases. I just thought about supporting LTS releases. This would mean "someone" or "we" make a commitment to add bug fixes (only) for a specified time. e.g. 2 years for a release or until the next L

Re: [DISCUSS] Release principles for Apache CloudStack

2015-07-02 Thread Remi Bergsma
Hi René, The reason is that I tried to stay close to how it is done now so we could reuse the scrips. You do have a valid point, as indeed no commits are expected (nor should be allowed) until the vote passes. Pinging @dahn to ask if he knows of other reasons to use a branch for RC and if h

Re: [DISCUSS] Release principles for Apache CloudStack

2015-07-02 Thread Daan Hoogland
On Thu, Jul 2, 2015 at 2:29 PM, Remi Bergsma wrote: > Since the goal is a stable master, I’d say the bug fix should go to master > first. Remi, this means that merge back of the branch makes no sense anymore. -- Daan

Re: [DISCUSS] LTS releases?

2015-07-02 Thread Remi Bergsma
Bug fixing in older releases is actually a lot of work. For security related issues we could maybe do it. Personally, I prefer to have a fast release cycle and smooth (tested) upgrade paths over 2-year LTS release cycle. It's more agile. As a bonus, people get the new features. The more peop

Re: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack

2015-07-02 Thread Marco Sinhoreli
Parabéns Wilder! Abs! Marco Sinhoreli Consultant Manager Phone: +55 21 2586 6390 | Fax: +55 21 2586 6002 | Mobile: +55 21 99159 4713 | Mobile: +55 21 98276 3636 Praia de Botafogo 501, bloco 1 - sala 101, Botafogo, Rio de Janeiro, RJ - Brazil - CEP 22250-040 marco.sinhor...@shapeblue.co

[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-7472: kvmclock fix for ...

2015-07-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/557#issuecomment-118099285 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

Re: [DISCUSS] Release principles for Apache CloudStack

2015-07-02 Thread Remi Bergsma
Hi Daan, Indeed. I prefer committing to master first, as it will ensure everything ends up there (unless some specific use cases). Currently, we have the risk of forgetting to include a fix to a release branch back to master. When we reverse it, some bug fix that should end up in the x.y branc

[ANNOUNCE] Karen Voung as a new PMC member of CloudStack

2015-07-02 Thread John Burwell
All, The Project Management Committee (PMC) for Apache CloudStack are pleased to announce that Karen Voung (karenv) has accepted our invitation to join the PMC. Please join me in congratulating her. On behalf of the Apache CloudStack PMC, -John Burwell --- John Burwell (@john_burwell) VP of So

Re: [ANNOUNCE] Karen Voung as a new PMC member of CloudStack

2015-07-02 Thread Remi Bergsma
Congratulations Karen! :-) > On 02 Jul 2015, at 20:15, John Burwell wrote: > > All, > > The Project Management Committee (PMC) for Apache CloudStack are pleased to > announce that Karen Voung (karenv) has accepted our invitation to join the > PMC. > > Please join me in congratulating her. >

Re: [ANNOUNCE] Karen Voung as a new PMC member of CloudStack

2015-07-02 Thread Erik Weber
Congratulations Karen :-) Erik Den torsdag 2. juli 2015 skrev John Burwell følgende: > All, > > The Project Management Committee (PMC) for Apache CloudStack are pleased > to announce that Karen Voung (karenv) has accepted our invitation to join > the PMC. > > Please join me in congratulating h

Re: [PROPOSAL] Commit to master through PR only

2015-07-02 Thread John Burwell
Daan, Having worked in an environment where PRs are required for all merges, tooling is only way to ensure it is followed without creating a tremendous human burden. The tooling is not difficult to implement (and there are a number of options beside the one I suggested), and reduces (or elimin

Re: [ANNOUNCE] Karen Voung as a new PMC member of CloudStack

2015-07-02 Thread Ahmad Emneina
Yay Karen! Great work, working tirelessly, on CloudStack stuffs. On Thu, Jul 2, 2015 at 11:24 AM, Erik Weber wrote: > Congratulations Karen :-) > > > Erik > > Den torsdag 2. juli 2015 skrev John Burwell > følgende: > > > All, > > > > The Project Management Committee (PMC) for Apache CloudStack

Re: [ANNOUNCE] Karen Voung as a new PMC member of CloudStack

2015-07-02 Thread Mike Tutkowski
Congratulations, Karen! :) On Thursday, July 2, 2015, John Burwell wrote: > All, > > The Project Management Committee (PMC) for Apache CloudStack are pleased > to announce that Karen Voung (karenv) has accepted our invitation to join > the PMC. > > Please join me in congratulating her. > > On be

Re: [PROPOSAL] Commit to master through PR only

2015-07-02 Thread John Burwell
Wilder, In the grand scheme of the entire project history (e.g. reading git log), why do I care about these discrete operations? In six months (or long), I (as the consumer of your change) want to know what motivated this change which is completely lost in those two commits. I have found thi

Re: [ANNOUNCE] Karen Voung as a new PMC member of CloudStack

2015-07-02 Thread Milamber
Congratulations and welcome Karen! On 02/07/2015 18:15, John Burwell wrote: All, The Project Management Committee (PMC) for Apache CloudStack are pleased to announce that Karen Voung (karenv) has accepted our invitation to join the PMC. Please join me in congratulating her. On behalf of t

Re: IRC and Slack

2015-07-02 Thread John Burwell
All, For me, the most significant issues with IRC is that there is no searchable history, backlog to catch up when offline, or good mobile clients (yes, mobile IRC clients exists, but work poorly in my view). While some of these solutions can be solved by running an IRC proxy such as znc or us

Re: IRC and Slack

2015-07-02 Thread Remi Bergsma
What if we use the best of both worlds, by using something like [1]? We obviously need to dive a bit into this and see how well it works. There might be alternatives. The benefit of such a solution would be that if you could see messages on IRC in Slack and v.v. that would make them more visible

Re: [DISCUSS] 4.5.2 bugfix sprint

2015-07-02 Thread Remi Bergsma
Hi Rohit, Could you see if you can add this bug fix as well? It fixes the X-Forwarded-For header in HAProxy. https://github.com/apache/cloudstack/pull/549 Thanks, Remi > On 25 jun. 2015, at 21:35, Rohit Yadav wrote: > > Hi all, > > Now that 4.4.4 has passed, I would like to start a 4.5.2 re

[GitHub] cloudstack pull request: CLOUDSTACK-8606: DB performance impacted ...

2015-07-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/553#issuecomment-118141634 @wilderrodrigues Could you please have a look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: IRC and Slack

2015-07-02 Thread Erik Weber
On Thu, Jul 2, 2015 at 9:15 PM, John Burwell wrote: > All, > > For me, the most significant issues with IRC is that there is no > searchable history, backlog to catch up when offline, or good mobile > clients (yes, mobile IRC clients exists, but work poorly in my view). > While some of these solu

[GitHub] cloudstack pull request: CLOUDSTACK-8606: DB performance impacted ...

2015-07-02 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/553#issuecomment-118159861 Just had a look. LGTM. Please proceed with the merge. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have

Re: IRC and Slack

2015-07-02 Thread Nux!
Hi, Our IRC channels seem to be dead, indeed, at least for "user support" purposes. IRC is pretty established and works great for many projects, it just requires people active then and there. Probably any form of chat will have the same fate no matter how trendy and personally -1 for anything

Re: [DISCUSS] Release principles for Apache CloudStack

2015-07-02 Thread Rajani Karuturi
I do not agree to backporting aka cherry picking. I prefer forward merges(tofu scale) 4.4 to 4.5 to master etc. That way, none of the changes will be missed and git branch --contains gives a nice view of where all the changes went. On Thu, Jul 2, 2015 at 23:16 PM, Remi Bergsma wrote: Hi Daan,

[GitHub] cloudstack pull request: CLOUDSTACK-8606: DB performance impacted ...

2015-07-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/553 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: simulator-singlerun #1332

2015-07-02 Thread jenkins
See -- Started by upstream project "build-master-simulator" build number 2149 originally caused by: Started by an SCM change Started by upstream project "build-master" build number 2443 origin

Build failed in Jenkins: build-master-jdk18 #182

2015-07-02 Thread jenkins
See Changes: [koushik] CLOUDSTACK-8606: DB performance impacted due to VM sync. -- [...truncated 500 lines...] at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)

RE: [ANNOUNCE] Karen Voung as a new PMC member of CloudStack

2015-07-02 Thread Koushik Das
Congrats Karen! -Original Message- From: John Burwell [mailto:john.burw...@shapeblue.com] Sent: Thursday, 2 July 2015 23:45 To: dev@cloudstack.apache.org Cc: Karen Vuong Subject: [ANNOUNCE] Karen Voung as a new PMC member of CloudStack All, The Project Management Committee (PMC) for Apa

[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8483 - Private templat...

2015-07-02 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/334#issuecomment-118248786 There is an API change. Should this go into master only? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-7472: kvmclock fix for ...

2015-07-02 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/557#issuecomment-118248923 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e