Jenkins build is still unstable: simulator-singlerun #313

2014-09-08 Thread jenkins
See

[GitHub] cloudstack pull request: bugfix/CLOUDSTACK-7476 for 4.4 branch.

2014-09-08 Thread lsimons
Github user lsimons commented on the pull request: https://github.com/apache/cloudstack/pull/17#issuecomment-54785217 Hey Daan, _this_ change is fine&done as-is. Like Rajani mentioned, the other changes to that file could be ported, too. I'm +0 on that -- on the one hand, it's a good

Review Request 25426: CLOUDSTACK-7370: Fixed password visible in plain text if password passed is in the end in url

2014-09-08 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25426/ --- Review request for cloudstack, Abhinandan Prateek and Devdeep Singh. Bugs: CLOU

[GitHub] cloudstack pull request: bugfix/CLOUDSTACK-7476 for 4.4 branch.

2014-09-08 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/17#issuecomment-54790328 Leo, you are right but if it is in 4.3 not putting it in 4.4 would make it a double behavioural change from a user perspective. So I will look at cherry-pic

Review Request 25427: fixed few coverity issues

2014-09-08 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25427/ --- Review request for cloudstack and Devdeep Singh. Repository: cloudstack-git D

Request to pick hotfix/4.4/CLOUDSTACK-6624 on 4.4 branch

2014-09-08 Thread Rohit Yadav
Hi Daan, Please see if you want to pick hotfix/4.4/CLOUDSTACK-6624 for 4.4 branch. Thanks. Regards, Rohit Yadav Software Architect, ShapeBlue M. +41 779015219 | rohit.ya...@shapeblue.com Blog: bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related s

Re: Review Request 25427: fixed few coverity issues

2014-09-08 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25427/ --- (Updated Sept. 8, 2014, 8:57 a.m.) Review request for cloudstack and Devdeep Si

Build failed in Jenkins: cloudstack-4.3-maven-build #583

2014-09-08 Thread jenkins
See Changes: [Rohit Yadav] appliance: fix build.sh for vmware systemvm building and exporting [Rohit Yadav] CLOUDSTACK-6624: set specifyIpRanges to true if specifyVlan is set to true ---

Review Request 25429: CLOUDSTACK-7502: UI: Host detail page - Display KVM agent version and Qemu version

2014-09-08 Thread Mihaela Stoica
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25429/ --- Review request for cloudstack, Brian Federle and Jessica Wang. Repository: clou

Re: Review Request 25429: CLOUDSTACK-7502: UI: Host detail page - Display KVM agent version and Qemu version

2014-09-08 Thread Mihaela Stoica
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25429/ --- (Updated Sept. 8, 2014, 10:13 a.m.) Review request for cloudstack, Brian Federl

RE: [VOTE] Release Apache CloudStack 4.3.1, round #2

2014-09-08 Thread Geoff Higginbottom
-1 I have tested an upgrade from a 4.3 install and whilst nearly everything I have tested works, unfortunately a bug which was introduced in 4.3.0 (CLOUDSTACK-6624) is still there. The good news however is that I raised this with one of our Devs and it has now been fixed so can be tested in th

Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

2014-09-08 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/ --- Review request for cloudstack and Koushik Das. Bugs: CLOUDSTACK-6099 https:

Re: [VOTE] Release Apache CloudStack 4.3.1, round #2

2014-09-08 Thread Rohit Yadav
Hi, I’ve fixed the UI bug that Geoff mentioned and fixed another build issue with systemvms. Now, they are building fine. You may get 4.3.1 systemvms from following links (though we need to verify if systemvms changed since 4.3.0): http://jenkins.buildacloud.org/view/4.3/job/cloudstack-4.3-syst

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

2014-09-08 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52575 --- server/src/com/cloud/server/ManagementServerImpl.java

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

2014-09-08 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52576 --- server/src/com/cloud/server/ManagementServerImpl.java

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

2014-09-08 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52577 --- engine/components-api/src/com/cloud/vm/VirtualMachineProfileImpl.ja

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

2014-09-08 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52578 --- engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.jav

Re: Request to pick hotfix/4.4/CLOUDSTACK-6624 on 4.4 branch

2014-09-08 Thread Daan Hoogland
merged On Mon, Sep 8, 2014 at 10:55 AM, Rohit Yadav wrote: > Hi Daan, > > Please see if you want to pick hotfix/4.4/CLOUDSTACK-6624 for 4.4 branch. > Thanks. > > Regards, > Rohit Yadav > Software Architect, ShapeBlue > M. +41 779015219 | rohit.ya...@shapeblue.com > Blog: bhaisaab.org | Twitter:

[ACS44] 4.4.1 rc question

2014-09-08 Thread Daan Hoogland
H, In view of our release 4.3.1, should I wait with creating a release candidate before it is out? It seems that no more work is going on and 4.4 is ready for a new release. -- Daan

Re: [ACS44] 4.4.1 rc question

2014-09-08 Thread Wido den Hollander
On 09/08/2014 12:03 PM, Daan Hoogland wrote: H, In view of our release 4.3.1, should I wait with creating a release candidate before it is out? It seems that no more work is going on and 4.4 is ready for a new release. I'd say wait for a moment. There seems to be a last minute bugfix coming

Re: [ACS44] 4.4.1 rc question

2014-09-08 Thread Francois Gaudreault
I wouldnt wait too long we are on this code base for a bit. We kinda need GA code :) FG On Sep 8, 2014 6:09 AM, "Wido den Hollander" wrote: > On 09/08/2014 12:03 PM, Daan Hoogland wrote: > >> H, >> >> In view of our release 4.3.1, should I wait with creating a release >> candidate before it

Jenkins build is still unstable: simulator-singlerun #314

2014-09-08 Thread jenkins
See

Build failed in Jenkins: build-master-simulator #547

2014-09-08 Thread jenkins
See -- [...truncated 1264 lines...] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 1 resource [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

2014-09-08 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/ --- (Updated Sept. 8, 2014, 10:52 a.m.) Review request for cloudstack and Koushik D

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

2014-09-08 Thread bharat kumar
> On Sept. 8, 2014, 9:27 a.m., Rohit Yadav wrote: > > server/src/com/cloud/server/ManagementServerImpl.java, lines 1160-1161 > > > > > > Why not fix VirtualMachineProfileImpl constructor where we're passing > > the o

Review Request 25431: CLOUDSTACK-7506: Fix base library to read hypevisor value from dictionary as opposed to only from function parameter

2014-09-08 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25431/ --- Review request for cloudstack, sanjeev n, Santhosh Edukulla, and SrikanteswaraRa

Jenkins build is still unstable: simulator-singlerun #315

2014-09-08 Thread jenkins
See

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

2014-09-08 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52581 --- Looks good, have you tested it with Xen, KVM? What was the issue cau

Re: [VOTE] Release Apache CloudStack 4.3.1, round #2

2014-09-08 Thread Rajani Karuturi
+1 based on the minimal testing I did to launch a VM and the LDAP integration. ~Rajani On Fri, Sep 5, 2014 at 9:21 PM, sebgoa wrote: > Hi All, > > I've created a 4.3.1 release, with the following artifacts up for a vote: > > Git Branch and Commit SH: > > https://git-wip-us.apache.org/repos/asf?

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

2014-09-08 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52582 --- Ship it! LGTM - Rohit Yadav On Sept. 8, 2014, 10:52 a.m., bharat

Re: Review Request 24090: Externalized the hard-coded strings from JavaScript files to resource bundles.

2014-09-08 Thread Vetrivel Chinnasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24090/ --- (Updated Sept. 8, 2014, 11:43 a.m.) Review request for cloudstack, Brian Federl

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

2014-09-08 Thread Rohit Yadav
> On Sept. 8, 2014, 11:39 a.m., Rohit Yadav wrote: > > LGTM Additional notes: this looks like there are other methods in VirtualMachineManagerImpl.java that can possibly have the same issue. One way is that we do set service offering in VirtualMachineProfileImpl() contructor from passed vm ob

Re: Review Request 25392: CLOUDSTACK-7434: Fixed VM Internal name issue in test_custom_hostname.py

2014-09-08 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25392/#review52585 --- Ship it! Ship It! - SrikanteswaraRao Talluri On Sept. 5, 2014, 3

Re: Review Request 25392: CLOUDSTACK-7434: Fixed VM Internal name issue in test_custom_hostname.py

2014-09-08 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25392/#review52587 --- pushed to master 40a537fedcbb8c088875ef222c950213909df7f8 - Srikant

Jenkins build is back to normal : build-master-simulator #548

2014-09-08 Thread jenkins
See

Review Request 25433: CLOUDSTACK-7509: Added missing bound method in base library for copyTemplate operation

2014-09-08 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25433/ --- Review request for cloudstack, sanjeev n, Santhosh Edukulla, and SrikanteswaraRa

Jenkins build is still unstable: simulator-singlerun #316

2014-09-08 Thread jenkins
See

[GitHub] cloudstack-docs-admin pull request: accounts: document SAML authen...

2014-09-08 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/19 accounts: document SAML authentication This adds some documentation on how to use the SAML auth plugin. You can merge this pull request into a Git repository by running: $ git pu

Review Request 25436: CLOUDSTACK-7393: Removing dependency on wait period from test case

2014-09-08 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25436/ --- Review request for cloudstack, sanjeev n, Santhosh Edukulla, and SrikanteswaraRa

Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

2014-09-08 Thread Ilia Shakitko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25435/ --- Review request for cloudstack, Alena Prokharchyk, Kishan Kavala, and Sheng Yang.

Jenkins build is still unstable: simulator-singlerun #317

2014-09-08 Thread jenkins
See

Re: Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

2014-09-08 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25435/#review52591 --- Thanks for this minor features, I can think of many people using it.

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

2014-09-08 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/ --- (Updated Sept. 8, 2014, 1:55 p.m.) Review request for cloudstack, Alena Prokhar

Re: Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

2014-09-08 Thread Ilia Shakitko
> On Sept. 8, 2014, 1:52 p.m., Rohit Yadav wrote: > > api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java, > > lines 73-74 > > > > > > Does this cause any issue? I would avoid this though ther

Re: Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

2014-09-08 Thread Rohit Yadav
> On Sept. 8, 2014, 1:52 p.m., Rohit Yadav wrote: > > api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java, > > lines 73-74 > > > > > > Does this cause any issue? I would avoid this though ther

Re: Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

2014-09-08 Thread Ilia Shakitko
> On Sept. 8, 2014, 1:52 p.m., Rohit Yadav wrote: > > api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java, > > lines 73-74 > > > > > > Does this cause any issue? I would avoid this though ther

Re: Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

2014-09-08 Thread Ilia Shakitko
> On Sept. 8, 2014, 1:52 p.m., Rohit Yadav wrote: > > api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java, > > lines 73-74 > > > > > > Does this cause any issue? I would avoid this though ther

Jenkins build is still unstable: simulator-singlerun #318

2014-09-08 Thread jenkins
See

Re: Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

2014-09-08 Thread Rohit Yadav
> On Sept. 8, 2014, 1:52 p.m., Rohit Yadav wrote: > > api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java, > > lines 73-74 > > > > > > Does this cause any issue? I would avoid this though ther

Cloudstack/KVM/arch i686 case reopened

2014-09-08 Thread Laurent Steff
Hello, As a lot of our researchers still need "real" 32bits CPU support in KVM/Qemu with CloudStack, we reopened and old bug reported by a colleague almost one year ago, without any activity. https://issues.apache.org/jira/browse/CLOUDSTACK-7511 Tell us if we could help (testing, patch, ...) T

Re: Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

2014-09-08 Thread Ilia Shakitko
> On Sept. 8, 2014, 1:52 p.m., Rohit Yadav wrote: > > api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java, > > lines 73-74 > > > > > > Does this cause any issue? I would avoid this though ther

Re: Cloudstack/KVM/arch i686 case reopened

2014-09-08 Thread Rohit Yadav
Hi Laurent, You’re welcome to contribute any work that you’ve already done. Else, you could have any developers at INRIA or may sponsor developers to work on this issue and the ACS community will be happy to assist them during development, help with patches, reviews etc. I’m curious why your r

Jenkins build is still unstable: simulator-singlerun #319

2014-09-08 Thread jenkins
See

Re: Review Request 22712: This Test suite has test cases relating to acess checks for deleteNetwork() for Admin, domain admin and regular users

2014-09-08 Thread sangeetha hariharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22712/ --- (Updated Sept. 8, 2014, 7:52 p.m.) Review request for cloudstack, Min Chen, Pra

Jenkins build is still unstable: simulator-singlerun #320

2014-09-08 Thread jenkins
See

Re: [ACS431] Help testing 4.3.1 vote candidate

2014-09-08 Thread Sebastien Goasguen
This was mentioned off-list as a blocker: https://issues.apache.org/jira/browse/CLOUDSTACK-6624 It was fixed by Rohit right away. I am fine canceling the current vote (since there has not been many votes or clear testers). I will wait till tomorrow morning Europe time, if no-one objects to the

Jenkins build is still unstable: simulator-singlerun #321

2014-09-08 Thread jenkins
See

Re: Review Request 22707: Test suite contains test cases relating to access checks for listSnapshot() with parameters - id, listall, isrecursive, account and domainid executed as ROOT admin, domain ad

2014-09-08 Thread sangeetha hariharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22707/ --- (Updated Sept. 9, 2014, 12:27 a.m.) Review request for cloudstack, edison su, M

Re: S3/Swift Problem around Virtual Size

2014-09-08 Thread Mike Tutkowski
Hi Punith, Have you been able to make any progress with regards to this Swift/S3 issue? Thanks! Mike On Wed, Aug 27, 2014 at 7:43 AM, Punith S wrote: > hi > > think i had a timeout problem! > on the second try the template has been downloaded to the S3 bucket and > the management server shows

Re: S3/Swift Problem around Virtual Size

2014-09-08 Thread Punith S
hi mike, i have figured out the issue, in NFS secondary storage the virtual size is been calculated by the VHD Processor by accessing the vhd template. but in case of S3, cloudstack is not able to access the template but it only gets to know the physical size of the template! in order to solve t

Re: S3/Swift Problem around Virtual Size

2014-09-08 Thread Mike Tutkowski
Hi Punith, Thanks for putting in time on this! So, option 1 occurs after we download the template to S3 or Swift. We then have to copy it to NFS so that we can determine the virtual size? Relatively slow, but it would work. If we went this route, would we then delete that template from the NFS s

Re: S3/Swift Problem around Virtual Size

2014-09-08 Thread Will Stevens
My two cents on the topic. Ideally we would save the size in the object store metadata and retrieve it from the metadata if it is set. If it is not set in the object store metadata, then when it is fetched, we have to put it on NFS and determine the size (then ideally save the metadata back to th

Re: S3/Swift Problem around Virtual Size

2014-09-08 Thread Mike Tutkowski
Hi Will, Thanks for the input! I like the idea of storing the virtual size as metadata in S3 or Swift although this could require that the end user provide this value when uploading the template. However, if we have the ability to determine the virtual size of the template after it gets download

RE: S3/Swift Problem around Virtual Size

2014-09-08 Thread Sanjeev Neelarapu
Mike, You are right. Template gets copied to (secondary-storage) NFS before being copied to primary storage -Sanjeev -Original Message- From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Tuesday, September 09, 2014 10:55 AM To: dev@cloudstack.apache.org Cc: Punith S; Fran

Re: S3/Swift Problem around Virtual Size

2014-09-08 Thread Mike Tutkowski
Great :) Then a question might be, "Is it too late in the game to interrogate the template to discover its virtual size if we're just about to copy the template to primary storage?" If it's not, this might be the place to run the logic to figure out the virtual size. Really, there are three big p

Re: S3/Swift Problem around Virtual Size

2014-09-08 Thread Mike Tutkowski
By the way, for anyone new to this issue, this is what we're referring to here: https://issues.apache.org/jira/browse/CLOUDSTACK-7406 On Mon, Sep 8, 2014 at 11:41 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > Great :) Then a question might be, "Is it too late in the game to > inter

Re: Review Request 25436: CLOUDSTACK-7393: Removing dependency on wait period from test case

2014-09-08 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25436/#review52677 --- Ship it! This change makes test to run faster. In future, please ad

Re: Review Request 25436: CLOUDSTACK-7393: Removing dependency on wait period from test case

2014-09-08 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25436/#review52680 --- pushed to master 402fc914cf4047b7faf1b1410972bb5a4ae5b29d - Srikant

Re: Review Request 25433: CLOUDSTACK-7509: Added missing bound method in base library for copyTemplate operation

2014-09-08 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25433/#review52681 --- Ship it! It would be nice if you could submit patches which replace

Re: Review Request 25433: CLOUDSTACK-7509: Added missing bound method in base library for copyTemplate operation

2014-09-08 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25433/#review52683 --- pushed to master: bbb3ea5983928df66704ab78cef0a1c3e292cbe9 - Srikan

Re: Review Request 25433: CLOUDSTACK-7509: Added missing bound method in base library for copyTemplate operation

2014-09-08 Thread Gaurav Aradhye
> On Sept. 9, 2014, 11:48 a.m., SrikanteswaraRao Talluri wrote: > > It would be nice if you could submit patches which replaces other > > occurences copytemplate code in test_templates.py > > > > cmd = copyTemplate.copyTemplateCmd() > > cmd.id = self.template_2.id > > cmd.destzo

Re: Review Request 25431: CLOUDSTACK-7506: Fix base library to read hypevisor value from dictionary as opposed to only from function parameter

2014-09-08 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25431/#review52685 --- Ship it! - SrikanteswaraRao Talluri On Sept. 8, 2014, 11:35 a.m.,

Re: Review Request 25431: CLOUDSTACK-7506: Fix base library to read hypevisor value from dictionary as opposed to only from function parameter

2014-09-08 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25431/#review52687 --- pushed to master d08d71427bba562aa8b46a54143a783051297494 - Srikant