----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25392/#review52587 -----------------------------------------------------------
pushed to master 40a537fedcbb8c088875ef222c950213909df7f8 - SrikanteswaraRao Talluri On Sept. 5, 2014, 3:53 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25392/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2014, 3:53 p.m.) > > > Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7434 > https://issues.apache.org/jira/browse/CLOUDSTACK-7434 > > > Repository: cloudstack-git > > > Description > ------- > > 1.Corrected the VM internal name formation. The last part of the internal > name is value of "instance.name" from global settings and not the display > name of the VM. > 2.Added missing cleanup items. > 3.Removed test script which caused other test cases to fail. > > > Diffs > ----- > > test/integration/component/test_custom_hostname.py 22dbaf5 > > Diff: https://reviews.apache.org/r/25392/diff/ > > > Testing > ------- > > Yes. Tested on VMware setup. > Out of 5 test cases which were run, 1 test case is still failing because of > other reason. Need to look at that one seperately. > > Log: > Verify user provided hostname to an instance ... === TestName: > test_01_user_provided_hostname | Status : SUCCESS === > ok > Verify for globally set instancename ... === TestName: > test_02_instancename_from_default_configuration | Status : SUCCESS === > ok > Test the duplicate name when old VM is in non-expunged state ... === > TestName: test_03_duplicate_name | Status : SUCCESS === > ok > Test Edit the Display name Through the UI. ... SKIP: skip > Test Unsupported chars in the display name ... SKIP: skip > Test the instance name with hyphens ... === TestName: > test_instance_name_with_hyphens | Status : SUCCESS === > ok > @Desc: Test whether cloudstack allows duplicate vm instance names in the diff > networks ... === TestName: test_vm_instance_name_duplicate_different_accounts > | Status : > FAILED === > > > Thanks, > > Gaurav Aradhye > >
