> On Sept. 8, 2014, 11:39 a.m., Rohit Yadav wrote: > > LGTM
Additional notes: this looks like there are other methods in VirtualMachineManagerImpl.java that can possibly have the same issue. One way is that we do set service offering in VirtualMachineProfileImpl() contructor from passed vm object, so we don't have to change outer layers. We can check with people who may have some idea on this class, from git blame -- Alex, Kelven, Alena, Devdeep, Nitin, Edison, Mike, etc. - Rohit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52582 ----------------------------------------------------------- On Sept. 8, 2014, 10:52 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25430/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2014, 10:52 a.m.) > > > Review request for cloudstack and Koushik Das. > > > Bugs: CLOUDSTACK-6099 > https://issues.apache.org/jira/browse/CLOUDSTACK-6099 > > > Repository: cloudstack-git > > > Description > ------- > > live migration is failing for vm deployed using dynaic compute offerings with > NPE > https://issues.apache.org/jira/browse/CLOUDSTACK-6099 > > > Diffs > ----- > > engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java > 8edef77 > > Diff: https://reviews.apache.org/r/25430/diff/ > > > Testing > ------- > > Tested live migration on master using xenserver. > > > Thanks, > > bharat kumar > >
