----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25431/#review52687 -----------------------------------------------------------
pushed to master d08d71427bba562aa8b46a54143a783051297494 - SrikanteswaraRao Talluri On Sept. 8, 2014, 11:35 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25431/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2014, 11:35 a.m.) > > > Review request for cloudstack, sanjeev n, Santhosh Edukulla, and > SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7506 > https://issues.apache.org/jira/browse/CLOUDSTACK-7506 > > > Repository: cloudstack-git > > > Description > ------- > > Few test cases in Secondary Storage Limits failed due to error in registering > Template - "Invalid Parameters - hypervisor is required". > > Base library function is reading hypervisor value only from function > parameter and not from services dictionary. But the test cases are passing > hypervisor value from dictionary. > > Solution: > Read the hypervisor value from the services dict if it's not passed through > the function parameter. > > > Diffs > ----- > > tools/marvin/marvin/lib/base.py 982986b > > Diff: https://reviews.apache.org/r/25431/diff/ > > > Testing > ------- > > Yes. > > Test Try to deploy VM with admin account where account has not used ... === > TestName: test_01_deploy_vm_domain_limit_reached | Status : SUCCESS === > ok > Test Try to deploy VM with admin account where account has used ... SKIP: skip > Test TTry to deploy VM with admin account where account has not used ... > SKIP: skip > > ---------------------------------------------------------------------- > Ran 3 tests in 199.895s > > OK (SKIP=2) > > > Thanks, > > Gaurav Aradhye > >