Re: Review Request 15298: Fix for issues on Coverity related to IDs cv_1125383 [82, 80, 79, 78, 77, 76, 75, 74]

2013-11-07 Thread Wilder Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15298/ --- (Updated Nov. 7, 2013, 8:25 a.m.) Review request for cloudstack and Hugo Trippa

Re: 4.2.1 BVT automation results

2013-11-07 Thread Sebastien Goasguen
On Nov 6, 2013, at 6:07 PM, Rayees Namathponnan wrote: > Hi All, > > 4.2.1 BVT automation results published to cwiki; you can see the results below > > https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.2.1+Automation+Result > > Regards, > Rayees > Where are those results coming from

Review Request 15303: Reserved SCSI device number prevents CloudStack to attach more than 6 data volumes to CLOUDSTACK-4790

2013-11-07 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15303/ --- Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-4790 http

Re: Review Request 15303: Reserved SCSI device number prevents CloudStack to attach more than 6 data volumes to CLOUDSTACK-4790

2013-11-07 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15303/ --- (Updated Nov. 7, 2013, 9:43 a.m.) Review request for cloudstack and Kishan Kava

Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master

2013-11-07 Thread Daan Hoogland
H Min, Your fix will work if you can guarantee that the String passed is a integer. if it has the chance of being in the form of for instance vlan:// , you should use: vid = Integer.parseInt(BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId))); regards, Daan On Wed, Nov 6, 201

Re: Review Request 15280: CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating usage events are enabled

2013-11-07 Thread Daan Hoogland
H David, I think I already applied this on 4.2. On Wed, Nov 6, 2013 at 8:09 PM, David Grizzanti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15280/ > ---

Re: Review Request 15298: Fix for issues on Coverity related to IDs cv_1125383 [82, 80, 79, 78, 77, 76, 75, 74]

2013-11-07 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15298/#review28358 --- Ship it! commit c06d8a750c75f500fa29479c0aec58eb7fcea2ba Author: wi

Review Request 15304: Added installation of marvin along with packaging to mvn build

2013-11-07 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15304/ --- Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-5073

Review Request 15305: CLOUDSTACK-4996: Resolved gateway accessibility issue.

2013-11-07 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15305/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-4996 h

Review Request 15307: Increasing the timeout values to 600 seconds from 300 seconds

2013-11-07 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15307/ --- Review request for cloudstack and Girish Shilamkar. Repository: cloudstack-git

Re: Review Request 15243: Improve VR upgrades

2013-11-07 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15243/#review28359 --- Ship it! Make a version check at the resource layer before firing t

Re: Review Request 15307: Increasing the timeout values to 600 seconds from 300 seconds

2013-11-07 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15307/#review28360 --- Ship it! Ship It! - Girish Shilamkar On Nov. 7, 2013, 10:23 a.m.

Re: Review Request 15296: CLOUDSTACK-5067 Bugfix: two NICs connected to Public network exist in VR

2013-11-07 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15296/#review28361 --- Ship it! commit 494ccd821d711a2957531d1c33274ed293e4d925 Author: yn

Re: Review Request 15305: CLOUDSTACK-4996: Resolved gateway accessibility issue.

2013-11-07 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15305/#review28362 --- Ship it! Ship It! - Girish Shilamkar On Nov. 7, 2013, 10:22 a.m.

Cloudstack 4.2.0 > migration of local data volume is not allowed

2013-11-07 Thread Antonio Petrocelli
Hello, i've this error when i try to attach a volume to vm: "Failed to attach local data volume snap_2599317a-2598-4a91-8dca-f3801ae1f462 to VM Test01 as migration of local data volume is not allowed" Actual config is on LOCAL storage type. Someone know about? Thanks!

Re: Review Request 15305: CLOUDSTACK-4996: Resolved gateway accessibility issue.

2013-11-07 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15305/#review28363 --- Commit 5d75c6b75c3ee65a15563d4c6b62cae7761afd86 in branch refs/heads

Re: Review Request 15304: Added installation of marvin along with packaging to mvn build

2013-11-07 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15304/#review28364 --- I'm not sure this is a good idea. The install target doesn't actuall

Storage overprovisioning for RBD / disable threshold?

2013-11-07 Thread Indra Pramana
Dear all, I am using CloudStack 4.2.0, KVM hypervisors, Ceph RBD primary storage and NFS secondary storage. I tried to change the storage.overprovisioning.factor from 1 to 2 under Global Settings, and it doesn't seem to work on my primary storage. The total amount of disk space seems to be remain

[DISCUSS]Migration of NFS Secondary Storage to Object Store

2013-11-07 Thread Manasa Veloori (3P)
Hi, I Have gone through the FS https://cwiki.apache.org/confluence/display/CLOUDSTACK/Migration+of+NFS+Secondary+Storage+to+Object+Store . Below are my review comments: In Migration steps: Step2: We also automatically increment reference count of these old templates, volumes and snapshots on

Re: Cloudstack 4.2.0 > migration of local data volume is not allowed

2013-11-07 Thread Koushik Das
Is your data volume and VM on the same host? If not then the volume cannot be attached to the VM in case of a local volume. -Koushik On 07-Nov-2013, at 4:03 PM, Antonio Petrocelli wrote: > Hello, > > i've this error when i try to attach a volume to vm: > > "Failed to attach local data volu

Re: [PROPOSAL] Service monitoring tool in virtual router

2013-11-07 Thread Jayapal Reddy Uradi
Hi Sanjeev, Thanks your comments. Please find my comments inline. Also update the FS. Thanks, Jayapal On 07-Nov-2013, at 11:55 AM, Sanjeev Neelarapu wrote: > Jayapal, > > I have gone through the FS posted @ > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Monitoring+VR+services >

RE: write access on cwiki

2013-11-07 Thread Sanjeev Neelarapu
Please provide me the write access to cwiki. Userid: sanjeevn -Sanjeev -Original Message- From: Rayees Namathponnan [mailto:rayees.namathpon...@citrix.com] Sent: Thursday, November 07, 2013 10:26 AM To: dev@cloudstack.apache.org Subject: RE: write access on cwiki Edison helped me on thi

Enabling AMQP/RabbitMQ Events on master

2013-11-07 Thread David Grizzanti
Hi, I was looking for some help in enabling the AMQP/RabbitMQ events in CloudStack. I'm familiar with enabling these events in 4.2, however, I'm not all the familiar with Spring and given the new modularized changes I'm not really sure where the XML snippet belongs for the eventNotificationBus.

Re: Bug? Should we allow detaching volumes when VMs have snapshots

2013-11-07 Thread SuichII, Christopher
Thanks for replying, Kelvin. Now, should we only not allow this on VMWare, or should we prohibit it on XenServer as well. It appears to work fine on XenServer, but it may be a good idea to have a consistent experience, regardless of hypervisor. -Chris -- Chris Suich chris.su...@netapp.com NetA

Re: Review Request 15304: Added installation of marvin along with packaging to mvn build

2013-11-07 Thread Santhosh Edukulla
> On Nov. 7, 2013, 10:40 a.m., Hugo Trippaers wrote: > > tools/marvin/pom.xml, line 88 > > > > > > How do we ensure it also works for people that use easy_install instead > > of pip? 1. The current way of usage is we

Re: Review Request 15304: Added installation of marvin along with packaging to mvn build

2013-11-07 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15304/#review28367 --- I'm with Hugo on this. It's going to become harder to fit marvin's b

Re: Review Request 15243: Improve VR upgrades

2013-11-07 Thread Kishan Kavala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15243/#review28368 --- Ship it! commit 3f5b8f70630e8415a611984ccde2e1f631e96bc9 - Kishan

RE: 4.2.1 BVT automation results

2013-11-07 Thread Rayees Namathponnan
Hi Sebastian, I don't think so we are running automation 4.2.1 branch in jenkins.buildacloud.org, below result is from master branch; http://jenkins.buildacloud.org/view/cloudstack-qa/job/test-smoke-matrix/ Also I reported master failures in ASF jira https://issues.apache.org/jira/browse/C

Review Request 15309: Fixed bug with deleting VMWare VM Snapshots

2013-11-07 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15309/ --- Review request for cloudstack and edison su. Repository: cloudstack-git Descr

Re: Cloudstack 4.2.0 > migration of local data volume is not allowed

2013-11-07 Thread Antonio Petrocelli
Hello, before all thanks for your reply. I confirm you that data volume ( snapshot and templates ) is located on second storage mounted with NFS on both nodes ( 2 hosts ). We use local storage for vm on each node. How to setup a local path for snapshot repository inside cloudstack admin pan

Re: Review Request 15238: CLOUDSTACK-5039: bugfix: live migration failed : Domain not found: no domain with matching uuid ''

2013-11-07 Thread Kishan Kavala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15238/#review28371 --- Ship it! commit b864e677e5d007e10b73f10120d86dc97684de6c - Kishan

Review Request 15313: Updated VMSnapshotDetails* to match *Details* pattern (e.g. UserVMDetails*)

2013-11-07 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15313/ --- Review request for cloudstack and edison su. Repository: cloudstack-git Descr

Re: Review Request 15238: CLOUDSTACK-5039: bugfix: live migration failed : Domain not found: no domain with matching uuid ''

2013-11-07 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15238/#review28372 --- Commit b864e677e5d007e10b73f10120d86dc97684de6c in branch refs/heads

Re: Review Request 15247: [DOC] CLOUDSTACK-4967: Add a section to describe VNI allocation matter

2013-11-07 Thread Toshiaki Hatano
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15247/#review28374 --- This modification basically subtract contents from the doc but the p

Re: Review Request 15247: [DOC] CLOUDSTACK-4967: Add a section to describe VNI allocation matter

2013-11-07 Thread Toshiaki Hatano
> On Nov. 7, 2013, 4:32 p.m., Toshiaki Hatano wrote: > > This modification basically subtract contents from the doc but the patch > > actually add a option to use physical interface name for traffic label. > > Since we still allow user to use bridge (even if it's not optimal) as > > traffic lab

Re: Review Request 15263: Added fix for bug 5056.

2013-11-07 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15263/#review28380 --- tools/marvin/marvin/integration/lib/utils.py

Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master

2013-11-07 Thread Min Chen
Yes. From callstack, BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId) is already called before going to that routine. Thanks -min On 11/7/13 1:51 AM, "Daan Hoogland" wrote: >H Min, > >Your fix will work if you can guarantee that the String passed is a >integer. if it has the

Re: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions

2013-11-07 Thread Daan Hoogland
Alex, Why would you want to make this a plugin? It sounds like a function of the core server. Don't you agree? regards, Daan On Wed, Nov 6, 2013 at 10:59 PM, Alex Ough wrote: > I'm having a difficulty finding documents about how to develop a plug-in. > Anyone to help me find one? > > Thanks in

Re: Review Request 15263: Added fix for bug 5056.

2013-11-07 Thread Santhosh Edukulla
> On Nov. 7, 2013, 5:05 p.m., SrikanteswaraRao Talluri wrote: > > tools/marvin/marvin/remoteSSHClient.py, line 115 > > > > > > self.keyPairFiles is not defined at this moment we are getting an > > exception here. > >

Re: Enabling AMQP/RabbitMQ Events on master

2013-11-07 Thread Alena Prokharchyk
David, Here are the instructions that I've got from one of the CS QA engineers, hope it helps. FS - http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Admin_Guide/events.html#event-framework Test cases relating to this feature was covered as part of Regions Feature testing -

RE: [ACS43] Schedule reminder : feature freeze this Friday 11/08

2013-11-07 Thread Animesh Chaturvedi
Chip can you confirm if the IP clearance is done, should Devdeep proceed with merging into master? > -Original Message- > From: Chip Childers [mailto:chipchild...@apache.org] > Sent: Tuesday, November 05, 2013 9:36 AM > To: dev@cloudstack.apache.org > Subject: Re: [ACS43] Schedule reminde

Re: Review Request 15068: Change labels for VLAN to vNet

2013-11-07 Thread Animesh Chaturvedi
> On Nov. 4, 2013, 10:24 p.m., Jessica Wang wrote: > > Ship It! Has this been applied? - Animesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15068/#review28144 --

Re: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions

2013-11-07 Thread Alex Ough
I don't mind implementing it in the core server unless there is anyone who thinks differently. Anyone with another thought? Thank Daan for your suggestion. Alex Ough On Thu, Nov 7, 2013 at 11:23 AM, Daan Hoogland wrote: > Alex, > > Why would you want to make this a plugin? It sounds like a func

RE: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Animesh Chaturvedi
Fails RAT on plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpClientWrapper.java > -Original Message- > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On > Behalf Of Will Stevens > Sent: Wednesday, November 06, 2013 10:15 AM > To: dev@cloudstack.apache

Reviewboard needs your attention

2013-11-07 Thread Animesh Chaturvedi
There are large number of patches in review board. I went through some of them and followed up and closed out few that are already checked in, but the list is huge. Given that we are approaching the 4.3 feature freeze tomorrow if you have submitted patches and are still pending reviews please re

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-11-07 Thread Animesh Chaturvedi
> On Oct. 7, 2013, 7:49 p.m., Mike Tutkowski wrote: > > This looks reasonable to me, Marcus. > > > > When do you think you might start the process of getting this into master? is this expected for 4.3? then this should be in master soon - Animesh

Re: Review Request 12679: CLOUDSTACK-904: Changed multiple vcpus to one vcpu with multiple sockets

2013-11-07 Thread Animesh Chaturvedi
> On July 17, 2013, 4:43 p.m., Wido den Hollander wrote: > > Hmm, I'm not sure about this one. > > > > In the UI we indeed mention the amount of cores, however, the API parameter > > is "cpunumber". > > > > So I get the reasoning, but we would be changing a lot here. I don't know > > if this

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Sheng Yang
Fixed. --Sheng On Thu, Nov 7, 2013 at 10:23 AM, Animesh Chaturvedi < animesh.chaturv...@citrix.com> wrote: > Fails RAT on > plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpClientWrapper.java > > > > -Original Message- > > From: williamstev...@gmail.com [mailto:william

Re: Review Request 12660: Replaced multiple grep/awk/head commands by one awk

2013-11-07 Thread Animesh Chaturvedi
> On July 26, 2013, 10:24 p.m., Jenkins Cloudstack.org wrote: > > Review 12660 failed the build test : FAILURE > > The url of build cloudstack-master-with-patch #55 is : > > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/55/ Patch needs to br updated, fails the build - Animesh

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Will Stevens
Just so I know, can you explain what it means to 'Fail RAT'? Thx... On Thu, Nov 7, 2013 at 1:46 PM, Sheng Yang wrote: > Fixed. > > --Sheng > > > On Thu, Nov 7, 2013 at 10:23 AM, Animesh Chaturvedi < > animesh.chaturv...@citrix.com> wrote: > > > Fails RAT on > > > plugins/network-elements/palo-

Re: Review Request 14786: [CLOUDSTACK-4609] [doc] Review Comments on Dedicated Resources: POD, CLUSTER

2013-11-07 Thread Travis Graham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14786/ --- (Updated Nov. 7, 2013, 1:52 p.m.) Review request for cloudstack and Joe Brockme

Re: Review Request 14785: [CLOUDSTACK-4692] Release notes refer to componentsContext.xml instead of componentContext.xml

2013-11-07 Thread Travis Graham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14785/ --- (Updated Nov. 7, 2013, 1:52 p.m.) Review request for cloudstack and Joe Brockme

Re: Review Request 14784: [CLOUDSTACK-4805] Installation instructions drops support for Ubuntu

2013-11-07 Thread Travis Graham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14784/ --- (Updated Nov. 7, 2013, 1:53 p.m.) Review request for cloudstack and Joe Brockme

Re: Review Request 14783: [CLOUDSTACK-4844] Docs show incorrect URL for Windows password reset service download

2013-11-07 Thread Travis Graham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14783/ --- (Updated Nov. 7, 2013, 1:53 p.m.) Review request for cloudstack and Joe Brockme

Re: [ACS43] Schedule reminder : feature freeze this Friday 11/08

2013-11-07 Thread Chip Childers
Please wait for tomorrow morning US time. 72 hours is not up yet. > On Nov 7, 2013, at 12:45 PM, Animesh Chaturvedi > wrote: > > Chip can you confirm if the IP clearance is done, should Devdeep proceed with > merging into master? > >> -Original Message- >> From: Chip Childers [mailto

Re: [ACS43] Schedule reminder : feature freeze this Friday 11/08

2013-11-07 Thread Chip Childers
Yes - please do. On Thu, Nov 07, 2013 at 05:45:27PM +, Animesh Chaturvedi wrote: > Chip can you confirm if the IP clearance is done, should Devdeep proceed with > merging into master? > > > -Original Message- > > From: Chip Childers [mailto:chipchild...@apache.org] > > Sent: Tuesday,

Re: [ACS43] Schedule reminder : feature freeze this Friday 11/08

2013-11-07 Thread Chip Childers
I was off - this morning it cleared. Sorry. Merge away. On Thu, Nov 7, 2013 at 1:55 PM, Chip Childers wrote: > Please wait for tomorrow morning US time. 72 hours is not up yet. > >> On Nov 7, 2013, at 12:45 PM, Animesh Chaturvedi >> wrote: >> >> Chip can you confirm if the IP clearance is don

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Sheng Yang
Oh, that means something wrong with the license header of the file(header missing in this case). http://creadur.apache.org/rat/ --Sheng On Thu, Nov 7, 2013 at 10:50 AM, Will Stevens wrote: > Just so I know, can you explain what it means to 'Fail RAT'? Thx... > > > On Thu, Nov 7, 2013 at 1:46

RE: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Animesh Chaturvedi
RAT is release audit tool and checks for missing license headers. You can run it as below mvn --projects='org.apache.cloudstack:cloudstack' org.apache.rat:apache-rat-plugin:0.8:check The build should FAIL if there are any non-compliant files that are not specifically excluded from the ASF li

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Will Stevens
Perfect. Thank you for the details. On Thu, Nov 7, 2013 at 1:59 PM, Sheng Yang wrote: > Oh, that means something wrong with the license header of the file(header > missing in this case). > > http://creadur.apache.org/rat/ > > --Sheng > > > On Thu, Nov 7, 2013 at 10:50 AM, Will Stevens > wrote

Re: Review Request 14628: AutoScaling without NetScaler

2013-11-07 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14628/#review28408 --- Reminder- Hi, The review has been pending for long. Please update th

Re: Review Request 11861: double slash fix for windows based nfs servers [CLOUDSTACK-2968]

2013-11-07 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11861/#review28410 --- Reminder- Hi, The review has been pending for long. Please update th

RE: [ACS43] Schedule reminder : feature freeze this Friday 11/08

2013-11-07 Thread Animesh Chaturvedi
That's what I thought because you had said 7th morning > -Original Message- > From: Chip Childers [mailto:chip.child...@gmail.com] > Sent: Thursday, November 07, 2013 10:59 AM > To: dev@cloudstack.apache.org > Subject: Re: [ACS43] Schedule reminder : feature freeze this Friday > 11/08 > >

Re: Review Request 8294: Store NetworkServiceProvider connectivity service configuration in database.

2013-11-07 Thread Amogh Vasekar
> On Jan. 29, 2013, 9:43 a.m., Hugo Trippaers wrote: > > The change looks good. Could you update the patch to the latest state of > > master? > > Animesh Chaturvedi wrote: > Hiroaki can you update the patch to latetst master. > > Animesh Chaturvedi wrote: > Any updates Hiroaki? Remind

Re: Review Request 14604: Removing coded documentation

2013-11-07 Thread Amogh Vasekar
> On Oct. 13, 2013, 6:34 p.m., daan Hoogland wrote: > > :) Reminder- Hi, The review has been pending for long. Please update the review status if it has already been committed. Thanks - Amogh --- This is an automatically generated e-ma

Re: Review Request 14603: fixed Rules

2013-11-07 Thread Amogh Vasekar
> On Oct. 13, 2013, 6:32 p.m., daan Hoogland wrote: > > Ship It! Reminder- Hi, The review has been pending for long. Please update the review status to "submitted" if it has already been committed. Thanks - Amogh --- This is an automat

Re: Review Request 14451: Some test for NetUtils

2013-11-07 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14451/#review28417 --- Reminder- Hi, The review has been pending for long. Please update th

Re: Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null

2013-11-07 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12192/#review28418 --- Reminder- Hi, The review has been pending for long. Please update th

Re: Review Request 12185: Remove dependency on backport-util.concurrent, and just use built in classes

2013-11-07 Thread Amogh Vasekar
> On Aug. 1, 2013, 8:31 a.m., daan Hoogland wrote: > > I think you need to rework this. Jenkins can't apply your patch and build > > it. Reminder- Hi, The review has been pending for long. Please update the patch since the build fails. Thanks - Amogh ---

Re: Reviewboard needs your attention

2013-11-07 Thread Sebastien Goasguen
I hate to move deadline, but it might be good to have couple days to try to clean review board. -Sebastien On 7 Nov 2013, at 19:26, Animesh Chaturvedi wrote: > There are large number of patches in review board. I went through some of > them and followed up and closed out few that are already

Re: Review Request 14786: [CLOUDSTACK-4609] [doc] Review Comments on Dedicated Resources: POD, CLUSTER

2013-11-07 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14786/#review28430 --- Ship it! Ship It! - Sebastien Goasguen On Nov. 7, 2013, 6:52 p.m

Re: Review Request 14785: [CLOUDSTACK-4692] Release notes refer to componentsContext.xml instead of componentContext.xml

2013-11-07 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14785/#review28432 --- Ship it! applied to master: 7229caff6eef3d5ed9b0bb282a593eb3425365a

Re: Review Request 14784: [CLOUDSTACK-4805] Installation instructions drops support for Ubuntu

2013-11-07 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14784/#review28433 --- this does not seem to apply. Can you please pull the latest and see

Re: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions

2013-11-07 Thread Chiradeep Vittal
It may be an admin burden, but it has to be optional. There are other ways to achieve global sync (e.g., LDAP/AD/Oauth). A lot of service providers who run cloudstack have their own user database / portal. In their implementations the CloudStack database is not the master source of user records, bu

Re: Review Request 14783: [CLOUDSTACK-4844] Docs show incorrect URL for Windows password reset service download

2013-11-07 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14783/#review28435 --- Ship it! applied to master: 5e6d003c57474c2e6c0d75e009e390468f67ab2

Re: Review Request 14786: [CLOUDSTACK-4609] [doc] Review Comments on Dedicated Resources: POD, CLUSTER

2013-11-07 Thread Sebastien Goasguen
> On Nov. 7, 2013, 7:34 p.m., Sebastien Goasguen wrote: > > Ship It! applied to master docs repo: 1f4822a75e2c100e19f2af8044ea6d767762d6ef - Sebastien --- This is an automatically generated e-mail. To reply, visit: https://reviews.apach

Re: Review Request 14784: [CLOUDSTACK-4805] Installation instructions drops support for Ubuntu

2013-11-07 Thread Travis Graham
> On Nov. 7, 2013, 2:38 p.m., Sebastien Goasguen wrote: > > this does not seem to apply. Can you please pull the latest and see what's > > going on > > > > thanks Do you want this based against master or 4.2? The patch was originally created against 4.2. - Travis

Re: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions

2013-11-07 Thread Chip Childers
On Thu, Nov 7, 2013 at 2:37 PM, Chiradeep Vittal wrote: > It may be an admin burden, but it has to be optional. There are other ways > to achieve global sync (e.g., LDAP/AD/Oauth). > A lot of service providers who run cloudstack have their own user database > / portal. In their implementations the

Re: Enabling AMQP/RabbitMQ Events on master

2013-11-07 Thread David Grizzanti
Alena, I don't think these steps will work on master (not installing packages of cloudstack), I'm building from source. The componentContext XML file doesn't seem to exist anymore since some of the Spring refactoring was done. Thanks On Thu, Nov 7, 2013 at 12:42 PM, Alena Prokharchyk < alena.p

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Chip Childers
On Thu, Nov 07, 2013 at 06:59:25PM +, Animesh Chaturvedi wrote: > mvn --projects='org.apache.cloudstack:cloudstack' > org.apache.rat:apache-rat-plugin:0.8:check s/0.8/0.10 if you want the latest

Re: Question: Error when creating templates from ROOT volumes in the Simulator

2013-11-07 Thread David Grizzanti
Prasanna, I took a look at the SimulatorImageStoreDriverImpl, but it seems like it's setting size correctly in that case. Also, in trying to step through the code, that section doesn't appear to be called when creating a template from a ROOT volume (I could be doing something wrong though when st

Review Request 15323: CLOUDSTACK-5080: Hypervisor Capabilities table missing entry for Simulator

2013-11-07 Thread David Grizzanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15323/ --- Review request for cloudstack. Bugs: CLOUDSTACK-5080 https://issues.apache.

Re: Review Request 15068: Change labels for VLAN to vNet

2013-11-07 Thread Yoshikazu Nojima
> On Nov. 4, 2013, 10:24 p.m., Jessica Wang wrote: > > Ship It! > > Animesh Chaturvedi wrote: > Has this been applied? Yes, it has. https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=5ccf3a90abb79eace839a8e61cf950248aa913c8 - Yoshikazu --

Review Request 15326: Added option to reload VM during in RevertToVMSnapshotCommand

2013-11-07 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15326/ --- Review request for cloudstack and edison su. Repository: cloudstack-git Descr

Re: Review Request 15309: Fixed bug with deleting VMWare VM Snapshots

2013-11-07 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15309/ --- (Updated Nov. 7, 2013, 9 p.m.) Review request for cloudstack and edison su. R

Re: Review Request 15313: Updated VMSnapshotDetails* to match *Details* pattern (e.g. UserVMDetails*)

2013-11-07 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15313/ --- (Updated Nov. 7, 2013, 9 p.m.) Review request for cloudstack and edison su. R

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-11-07 Thread Mike Tutkowski
> On Oct. 7, 2013, 7:49 p.m., Mike Tutkowski wrote: > > This looks reasonable to me, Marcus. > > > > When do you think you might start the process of getting this into master? > > Animesh Chaturvedi wrote: > is this expected for 4.3? then this should be in master soon This code has been co

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-11-07 Thread Mike Tutkowski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14381/#review28443 --- Ship it! Ship It! - Mike Tutkowski On Sept. 30, 2013, 5:14 p.m.,

RE: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-11-07 Thread Animesh Chaturvedi
Ok I closed out the review as "submitted" > -Original Message- > From: Mike Tutkowski [mailto:nore...@reviews.apache.org] On Behalf Of > Mike Tutkowski > Sent: Thursday, November 07, 2013 1:03 PM > To: Edison Su; Mike Tutkowski > Cc: Marcus Sorensen; cloudstack > Subject: Re: Review Reques

Re: Bug? Should we allow detaching volumes when VMs have snapshots

2013-11-07 Thread Mike Tutkowski
I can see the appeal in consistent behavior, but I'm not sure we want CloudStack to always follow a least-common-denominator approach. Personally I recommend we leave XenServer's functionality here as is. On Thu, Nov 7, 2013 at 6:14 AM, SuichII, Christopher wrote: > Thanks for replying, Kelvin

Re: Bug? Should we allow detaching volumes when VMs have snapshots

2013-11-07 Thread Mike Tutkowski
Especially since it appears to have been working for XenServer and I'd hate to take that functionality away from people who might be using it. On Thu, Nov 7, 2013 at 2:15 PM, Mike Tutkowski wrote: > I can see the appeal in consistent behavior, but I'm not sure we want > CloudStack to always fol

api incompatibility between 4.1 and 4.2 in ACLs

2013-11-07 Thread Marcus Sorensen
Maybe this has been discussed already, but we seem to have run into an api incompatibility. In 4.1, you could create ad-hoc ACL rules that applied to a network. In 4.2, you have to first create an 'ACL list', then add those rules to the list, then apply the list to a network. Or so it seems. This

Re: Review Request 15309: Fixed bug with deleting VMWare VM Snapshots

2013-11-07 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15309/ --- (Updated Nov. 7, 2013, 9:30 p.m.) Review request for cloudstack and edison su.

Re: Review Request 15326: Added option to reload VM during in RevertToVMSnapshotCommand

2013-11-07 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15326/#review28456 --- Ship it! Ship It! - edison su On Nov. 7, 2013, 9 p.m., Chris Sui

Re: Review Request 15313: Updated VMSnapshotDetails* to match *Details* pattern (e.g. UserVMDetails*)

2013-11-07 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15313/#review28457 --- Ship it! Ship It! - edison su On Nov. 7, 2013, 9 p.m., Chris Sui

Re: Review Request 15309: Fixed bug with deleting VMWare VM Snapshots

2013-11-07 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15309/#review28458 --- Ship it! Ship It! - edison su On Nov. 7, 2013, 9:30 p.m., Chris

Re: Bug? Should we allow detaching volumes when VMs have snapshots

2013-11-07 Thread Nux!
On 07.11.2013 21:17, Mike Tutkowski wrote: Especially since it appears to have been working for XenServer and I'd hate to take that functionality away from people who might be using it. +100, removing functionality will not gain you any extra points; especially doing it for what is probably t

pool.storage.capacity.disablethreshold global config

2013-11-07 Thread Alena Prokharchyk
I've run into the problem in master where I can't deploy the VM due to insufficient capacity: 2013-11-07 14:21:20,439 DEBUG [c.c.s.StorageManagerImpl] (Job-Executor-27:ctx-e5d8814d ctx-e5375ad7) Insufficient space on pool: 1 since its usage percentage: 4.875950712239125 has crossed the pool.st

Re: [jira] [Updated] (CLOUDSTACK-4982) Top of dialogs cut off

2013-11-07 Thread Luis
Hi I will appreciate your help to fix this problem CloudStack 4.2 Ubuntu 12.04 single machine The errors 10.0.0.20:/export/primary/ 684G  2.5G  646G   1% /mnt/primary 10.0.0.20:/export/secondary/   684G  2.5G  646G   1% /mnt/secondary 10.0.0.20:/export/pr

Build failed in Jenkins: build-master-noredist #1739

2013-11-07 Thread jenkins
See Changes: [sudison] Add quiencevm option on createsnapshotcmd [min.chen] CLOUDSTACK-4833:[Automation][BVT] Template and ISO test cases failing -- [...truncated 415 lines...] [INFO]

  1   2   >