----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15247/#review28374 -----------------------------------------------------------
This modification basically subtract contents from the doc but the patch actually add a option to use physical interface name for traffic label. Since we still allow user to use bridge (even if it's not optimal) as traffic label, why don't we add more documentation to tell options and pros/cons instead of concealing things. vxlan/en-US/plugin-vxlan-config-hypervisor.xml <https://reviews.apache.org/r/15247/#comment55191> s/XVLAN/VXLAN/ ? :) vxlan/en-US/plugin-vxlan-config-hypervisor.xml <https://reviews.apache.org/r/15247/#comment55194> This paragraph excluding line 32 is still valid after the patch. IMO it's better to explain why we need to open UDP/8472 port. I also feel it's must to explain this plugin require multicast reachability between underlying interfaces, at least somewhere in this document. - Toshiaki Hatano On Nov. 5, 2013, 9:31 p.m., Yoshikazu Nojima wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15247/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2013, 9:31 p.m.) > > > Review request for cloudstack and Marcus Sorensen. > > > Bugs: CLOUDSTACK-4967 > https://issues.apache.org/jira/browse/CLOUDSTACK-4967 > > > Repository: cloudstack-docs > > > Description > ------- > > This patch updates CloudStack Plugin Guide for the VXLAN Plugin. > > - Add a section to describe VNIs allocation matter > - Remove section that explain how to configure the bridge for traffic label > because the bridge configuration is no longer necessary. > - Update screen shots to catch up new UI visual appearance. > > > Diffs > ----- > > vxlan/en-US/images/vxlan-trafficlabel.png > 956d5f4f58f592ed3f260d6e1982c238c2ddf06a > vxlan/en-US/images/vxlan-vniconfig.png PRE-CREATION > vxlan/en-US/plugin-vxlan-config-hypervisor.xml 2c5e138 > vxlan/en-US/plugin-vxlan-config-management.xml 21f5461 > vxlan/en-US/plugin-vxlan-revision-history.xml ec04d11 > > Diff: https://reviews.apache.org/r/15247/diff/ > > > Testing > ------- > > I generated and confirmed the PDF. > > > Thanks, > > Yoshikazu Nojima > >
