----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15313/ -----------------------------------------------------------
(Updated Nov. 7, 2013, 9 p.m.) Review request for cloudstack and edison su. Repository: cloudstack-git Description ------- VMSnapshotDetailsDao/Impl/VO were not using the ResourceDetails/Dao/Base pattern which caused issues with adding details and did not give access to useful methods like the detail getters/deleters. Diffs ----- engine/schema/src/com/cloud/vm/snapshot/VMSnapshotDetailsVO.java 934dd92 engine/schema/src/com/cloud/vm/snapshot/dao/VMSnapshotDetailsDao.java e84178c engine/schema/src/com/cloud/vm/snapshot/dao/VMSnapshotDetailsDaoImpl.java b528b39 engine/storage/integration-test/test/com/cloud/vm/snapshot/dao/VmSnapshotDaoTest.java fc52f89 Diff: https://reviews.apache.org/r/15313/diff/ Testing (updated) ------- This has been tested locally with a custom plugin. However, the changes are not used by the existing CloudStack codebase and should not impact any existing workflows or use cases. They are simply for plugins to take advantage of. Thanks, Chris Suich
