-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15298/#review28358
-----------------------------------------------------------
Ship it!
commit c06d8a750c75f500fa29479c0aec58eb7fcea2ba
Author: wilderrodrigues <wrodrig...@schubegphilis.com>
Date: Thu Nov 7 09:22:43 2013 +0100
Fix for issues on Coverity related to IDs cv_1125383, cv_1125382,
cv_1125380, cv_1125379, cv_1125378, cv_1125377, cv_1125376, cv_1125375,
cv_1125374.
Those bugs are related to classes not implementing Serializable, nox
overriding the equals and/or hashCode methods and with empty finalize method.
Signed-off-by: Hugo Trippaers <htrippa...@schubergphilis.com>
- Hugo Trippaers
On Nov. 7, 2013, 8:25 a.m., Wilder Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15298/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2013, 8:25 a.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Several bugs reported on Coverity have been fixed on this path. The ID are:
> Fix for issues on Coverity related to IDs cv_1125383, cv_1125382, cv_1125380,
> cv_1125379, cv_1125378, cv_1125377, cv_1125376, cv_1125375, cv_1125374.
>
> Those bugs are related to classes not implementing Serializable, nox
> overriding the equals and/or hashCode methods and with empty finalize method.
>
> For the bug cv_1125376, although it has been submitted in a previous patch,
> there was a typo on the return key word, which contained a "s".
>
>
> Diffs
> -----
>
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java
> 8cb4e8d
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java
> 455e601
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java
> 71d28ac
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java
> f22c7c5
>
> Diff: https://reviews.apache.org/r/15298/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Wilder Rodrigues
>
>
