Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

Thank you Sheng. Bharat. On Jul 25, 2013, at 12:20 AM, Sheng Yang mailto:sh...@yasker.org>> wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ Ship it! Nice work! patches/systemvm/debian/config/root/dnsmasq.sh

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

> On July 24, 2013, 6:50 p.m., Sheng Yang wrote: > > Nice work! Fixed version pushed to 4.2 and MASTER. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23779

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23779 --- Ship it! Nice work! patches/systemvm/debian/config/root/dnsmasq.s

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ --- (Updated July 24, 2013, 10:28 a.m.) Review request for cloudstack, Alena Prokha

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

> On July 23, 2013, 8:51 p.m., Sheng Yang wrote: > > patches/systemvm/debian/config/root/dnsmasq.sh, line 100 > > > > > > dhcp-option=tag.* is not in the log > > bharat kumar wrote: > the dhcp-option=tag* will be

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

> On July 23, 2013, 8:51 p.m., Sheng Yang wrote: > > patches/systemvm/debian/config/root/dnsmasq.sh, line 100 > > > > > > dhcp-option=tag.* is not in the log > > bharat kumar wrote: > the dhcp-option=tag* will be

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

> On July 23, 2013, 8:51 p.m., Sheng Yang wrote: > > patches/systemvm/debian/config/root/dnsmasq.sh, line 100 > > > > > > dhcp-option=tag.* is not in the log the dhcp-option=tag* will be there in the new config. I am

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23713 --- patches/systemvm/debian/config/root/dnsmasq.sh

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

> On July 22, 2013, 10:23 p.m., Sheng Yang wrote: > > patches/systemvm/debian/config/root/dnsmasq.sh, line 54 > > > > > > You don't need so complicate way to find dns is enabled or not. Just > > check /var/cache/cloud/

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ --- (Updated July 23, 2013, 1:07 p.m.) Review request for cloudstack, Alena Prokhar

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ --- (Updated July 23, 2013, 12:42 p.m.) Review request for cloudstack, Alena Prokha

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

> On July 22, 2013, 10:23 p.m., Sheng Yang wrote: > > patches/systemvm/debian/config/root/dnsmasq.sh, line 54 > > > > > > You don't need so complicate way to find dns is enabled or not. Just > > check /var/cache/cloud/

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23649 --- patches/systemvm/debian/config/root/dnsmasq.sh

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23629 --- Review 12810 PASSED the build test The url of build cloudstack-maste

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ --- (Updated July 22, 2013, 12:54 p.m.) Review request for cloudstack, Alena Prokha

Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ --- Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Bugs: CLOUDSTA