> On July 23, 2013, 8:51 p.m., Sheng Yang wrote: > > patches/systemvm/debian/config/root/dnsmasq.sh, line 100 > > <https://reviews.apache.org/r/12810/diff/4/?file=325449#file325449line100> > > > > dhcp-option=tag.* is not in the log > > bharat kumar wrote: > the dhcp-option=tag* will be there in the new config. I am not logging it > as it is not a part of the config which i am removing from /etc/dnsmasq.conf. > > Sheng Yang wrote: > Not quite understand... All your new config should be in > /etc/dnsmasq.d/multiple_ranges.conf rather than /etc/dnsmasq.conf. Why there > are any dhcp-options=tag* in dnsmasq.conf?
Sheng you are right. This setting is not there in the dnsmasq.conf. so this line is not needed. I will remove it. - bharat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23713 ----------------------------------------------------------- On July 23, 2013, 1:07 p.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12810/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 1:07 p.m.) > > > Review request for cloudstack, Alena Prokharchyk and Sheng Yang. > > > Bugs: CLOUDSTACK-3694 > > > Repository: cloudstack-git > > > Description > ------- > > https://issues.apache.org/jira/browse/CLOUDSTACK-3694 > > wrote the dnsmasq config in bash instead of creating the config file in java > and overwriting. > > > Diffs > ----- > > core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 > > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java > 0b26220 > core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df > patches/systemvm/debian/config/etc/init.d/cloud-early-config c04ff90 > patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > c7f487e > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > f80d4b6 > scripts/vm/hypervisor/xenserver/vmops f8c0253 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > 6c0f7a1 > > Diff: https://reviews.apache.org/r/12810/diff/ > > > Testing > ------- > > Tested on old master using xenserver. > Could not test on the latest one as it is broken. > > > Thanks, > > bharat kumar > >
