Thank you Sheng. Bharat.
On Jul 25, 2013, at 12:20 AM, Sheng Yang <sh...@yasker.org<mailto:sh...@yasker.org>> wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ Ship it! Nice work! patches/systemvm/debian/config/root/dnsmasq.sh<https://reviews.apache.org/r/12810/diff/4-5/?file=325449#file325449line59> (Diff revisions 4 - 5) 56 dns2=$(grep -o " dns2=.* " "$CMDLINE" | sed -e 's/dns2=//' | awk '{print $1}') 59 dns2=$(echo "CMDLINE" | grep -o " dns2=.* " | sed -e 's/dns2=//' | awk '{print $1}') Typo here. I would fix it when check in the patch. - Sheng Yang On July 24th, 2013, 10:28 a.m. UTC, bharat kumar wrote: Review request for cloudstack, Alena Prokharchyk and Sheng Yang. By bharat kumar. Updated July 24, 2013, 10:28 a.m. Bugs: CLOUDSTACK-3694 Repository: cloudstack-git Description https://issues.apache.org/jira/browse/CLOUDSTACK-3694 wrote the dnsmasq config in bash instead of creating the config file in java and overwriting. Testing Tested on old master using xenserver. Could not test on the latest one as it is broken. Diffs * core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java (521ad70) * core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java (0b26220) * core/src/com/cloud/network/DnsMasqConfigurator.java (3fc61df) * patches/systemvm/debian/config/etc/init.d/cloud-early-config (c04ff90) * patches/systemvm/debian/config/root/dnsmasq.sh (b70e2d3) * plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java (c7f487e) * plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java (f80d4b6) * scripts/vm/hypervisor/xenserver/vmops (f8c0253) * server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java (6c0f7a1) * server/src/com/cloud/vm/VirtualMachineManagerImpl.java (7a4bf50) View Diff<https://reviews.apache.org/r/12810/diff/>
