Re: Review Request 14405: ConstantTimeBackoff test and cleanup

2013-10-04 Thread Darren Shepherd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14405/#review26688 --- Ship it! master: 826c69fd29bb98d3f631596f72a6eb3525d83aa2 - Darren

Re: Review Request 14405: ConstantTimeBackoff test and cleanup

2013-10-01 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14405/ --- (Updated Oct. 1, 2013, 5:32 p.m.) Review request for cloudstack. Changes

Re: Review Request 14405: ConstantTimeBackoff test and cleanup

2013-09-30 Thread Laszlo Hornyak
> On Sept. 30, 2013, 6:12 p.m., Darren Shepherd wrote: > > utils/src/com/cloud/utils/backoff/impl/ConstantTimeBackoff.java, line 60 > > > > > > I wouldn't log at WARN level for this, can you change to DEBUG. > > Hitti

Re: Review Request 14405: ConstantTimeBackoff test and cleanup

2013-09-30 Thread Darren Shepherd
> On Sept. 30, 2013, 6:12 p.m., Darren Shepherd wrote: > > utils/src/com/cloud/utils/backoff/impl/ConstantTimeBackoff.java, line 60 > > > > > > I wouldn't log at WARN level for this, can you change to DEBUG. > > Hitti

Re: Review Request 14405: ConstantTimeBackoff test and cleanup

2013-09-30 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14405/ --- (Updated Sept. 30, 2013, 8:27 p.m.) Review request for cloudstack. Changes --

Re: Review Request 14405: ConstantTimeBackoff test and cleanup

2013-09-30 Thread Laszlo Hornyak
> On Sept. 30, 2013, 6:12 p.m., Darren Shepherd wrote: > > utils/src/com/cloud/utils/backoff/impl/ConstantTimeBackoff.java, line 60 > > > > > > I wouldn't log at WARN level for this, can you change to DEBUG. > > Hitti

Re: Review Request 14405: ConstantTimeBackoff test and cleanup

2013-09-30 Thread Darren Shepherd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14405/#review26503 --- utils/src/com/cloud/utils/backoff/impl/ConstantTimeBackoff.java