----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14405/ -----------------------------------------------------------
(Updated Sept. 30, 2013, 8:27 p.m.) Review request for cloudstack. Changes ------- - license comment added to the test file - log level decreased to INFO Repository: cloudstack-git Description ------- - javadoc changed - the old one was copy-pasted from AgentShell - start and stop method removed - they did the same as the overridden methods - _counter removed as it was only written, but never read - remove from _asleep map was moved to a finally block, to make sure it is removed even in case of the thread gets interrupted - Tests created for the above scenarios. Diffs (updated) ----- agent/src/com/cloud/agent/AgentShell.java bf1e818 utils/src/com/cloud/utils/backoff/impl/ConstantTimeBackoff.java 976e369 utils/test/com/cloud/utils/backoff/impl/ConstantTimeBackoffTest.java PRE-CREATION Diff: https://reviews.apache.org/r/14405/diff/ Testing ------- test included Thanks, Laszlo Hornyak
