----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14405/#review26688 -----------------------------------------------------------
Ship it! master: 826c69fd29bb98d3f631596f72a6eb3525d83aa2 - Darren Shepherd On Oct. 1, 2013, 5:32 p.m., Laszlo Hornyak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14405/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2013, 5:32 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > - javadoc changed - the old one was copy-pasted from AgentShell > - start and stop method removed - they did the same as the overridden methods > - _counter removed as it was only written, but never read > - remove from _asleep map was moved to a finally block, to make sure it is > removed even in case of the thread gets interrupted > - Tests created for the above scenarios. > > > Diffs > ----- > > agent/src/com/cloud/agent/AgentShell.java bf1e818 > utils/src/com/cloud/utils/backoff/impl/ConstantTimeBackoff.java 976e369 > utils/test/com/cloud/utils/backoff/impl/ConstantTimeBackoffTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/14405/diff/ > > > Testing > ------- > > test included > > > Thanks, > > Laszlo Hornyak > >
