Re: Contrail Plugin Emitting Extra Action Events?

2017-03-29 Thread Syed Ahmed
9.2.0 into our fork, I'm noticing that > the Juniper Contrail plugin has an "EventUtils" class which looks for > methods with @ActionEvent on them and them emits over the event bus. This > does the same thing as the more-standard ActionEventUtils class. Is there a > reason for t

Contrail Plugin Emitting Extra Action Events?

2017-03-14 Thread Jeff Hair
Hi, In my continuing quest to merge 4.9.2.0 into our fork, I'm noticing that the Juniper Contrail plugin has an "EventUtils" class which looks for methods with @ActionEvent on them and them emits over the event bus. This does the same thing as the more-standard ActionEventUtils cl

Re: Disable open inactive plugins: Contrail plugin

2016-10-28 Thread Will Stevens
*From:* williamstev...@gmail.com on behalf of > Will Stevens > *Sent:* 27 October 2016 22:50:19 > *To:* dev@cloudstack.apache.org > *Cc:* Rohit Yadav; us...@cloudstack.apache.org > *Subject:* Re: Disable open inactive plugins: Contrail plugin > > Just because recent builds are

Re: Disable open inactive plugins: Contrail plugin

2016-10-27 Thread Rohit Yadav
: dev@cloudstack.apache.org Cc: Rohit Yadav; us...@cloudstack.apache.org Subject: Re: Disable open inactive plugins: Contrail plugin I second this. I am aware of the customers who are actively using this. In fact, I have a PR to be merged in this area. Rather, we need to fix the build failures https://githu

Re: Disable open inactive plugins: Contrail plugin

2016-10-27 Thread Venkata Yedugundla
I second this. I am aware of the customers who are actively using this. In fact, I have a PR to be merged in this area. Rather, we need to fix the build failures https://github.com/apache/cloudstack/pull/1715 Thanks, Subhash On Oct 27, 2016, at 10:50 PM, Will Stevens mailto:wstev...@cloudops.

Re: Disable open inactive plugins: Contrail plugin

2016-10-27 Thread Rohit Yadav
: williamstev...@gmail.com on behalf of Will Stevens Sent: 27 October 2016 22:50:19 To: dev@cloudstack.apache.org Cc: Rohit Yadav; us...@cloudstack.apache.org Subject: Re: Disable open inactive plugins: Contrail plugin Just because recent builds are failing does not really mean that no one is

Re: Disable open inactive plugins: Contrail plugin

2016-10-27 Thread Will Stevens
Just because recent builds are failing does not really mean that no one is using it. In my experience working with different companies who have ACS in production, a lot of them are using much older versions of ACS (4.4 for example). Only a subset of companies keep their ACS install "close" to mas

Re: Disable open inactive plugins: Contrail plugin

2016-10-27 Thread Simon Weller
From: Wido den Hollander Sent: Thursday, October 27, 2016 6:12 AM To: Rohit Yadav; dev@cloudstack.apache.org Cc: us...@cloudstack.apache.org Subject: Re: Disable open inactive plugins: Contrail plugin > Op 27 oktober 2016 om 13:00 schreef Rohit Ya

Re: Disable open inactive plugins: Contrail plugin

2016-10-27 Thread Wido den Hollander
> Op 27 oktober 2016 om 13:00 schreef Rohit Yadav : > > > All, > > > The Juniper contrail plugin is failing for last few hours, this plugin has > not been maintained in last few years, except for codebase/architectural > changes no changes were made to the pl

Disable open inactive plugins: Contrail plugin

2016-10-27 Thread Rohit Yadav
All, The Juniper contrail plugin is failing for last few hours, this plugin has not been maintained in last few years, except for codebase/architectural changes no changes were made to the plugin itself in last 2 years. The Jenkins failure is due to the dependency not available, further the

Juniper Contrail Plugin

2016-07-20 Thread Venkata Yedugundla
Hi all, I see juniper contrail plugin publishing events to message bus. It is causing a deadlock in a specific scenario. May I know the reason for the same. The following is the code piece I am referring to and the corresponding event is not subscribed to far. public void interceptComplete

Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2015-04-06 Thread Sebastien Goasguen
sh Battala. > > > Repository: cloudstack-git > > > Description > --- > > This patch has following changes: > - Added service-instance delete command to Juniper Contrail Plugin. > - Fixes to plugin code to handle instance-delete operation properly. > -

Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2014-06-09 Thread Rajesh Battala
pository: cloudstack-git > > > Description > --- > > This patch has following changes: > - Added service-instance delete command to Juniper Contrail Plugin. > - Fixes to plugin code to handle instance-delete operation properly. > - Fix related to service-instance

Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2014-05-20 Thread Sachchidanand Vaidya
te and delete. > >Thanks, >Sachin > > >Repository: cloudstack-git > > >Description >--- > >This patch has following changes: > - Added service-instance delete command to Juniper Contrail Plugin. > - Fixes to plugin code to handle instance-delete operati

Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2014-05-16 Thread Sachchidanand Vaidya
Battala. Changes --- Fixed licenser header and created new EventTypes for serviceInstance VM create and delete. Thanks, Sachin Repository: cloudstack-git Description --- This patch has following changes: - Added service-instance delete command to Juniper Contrail Plugin. - Fixes to

Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2014-05-14 Thread Sachchidanand Vaidya
dstack and Rajesh Battala. > > > Repository: cloudstack-git > > > Description > --- > > This patch has following changes: > - Added service-instance delete command to Juniper Contrail Plugin. > - Fixes to plugin code to handle instance-delete

Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2014-05-13 Thread Sachchidanand Vaidya
t; --- > > This patch has following changes: > - Added service-instance delete command to Juniper Contrail Plugin. > - Fixes to plugin code to handle instance-delete operation properly. > - Fix related to service-instance persistence and re-creation during Mgmt >

Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2014-05-05 Thread Rajesh Battala
t; Review request for cloudstack and Rajesh Battala. > > > Repository: cloudstack-git > > > Description > --- > > This patch has following changes: > - Added service-instance delete command to Juniper Contrail Plugin. > - Fixes to plugin code to handle ins

Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2014-05-05 Thread Rajesh Battala
(Updated May 3, 2014, 7:29 a.m.) > > > Review request for cloudstack and Rajesh Battala. > > > Repository: cloudstack-git > > > Description > --- > > This patch has following changes: > - Added service-instance delete command to Juniper Co

Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2014-05-03 Thread Sachchidanand Vaidya
Battala. Changes --- . Repository: cloudstack-git Description --- This patch has following changes: - Added service-instance delete command to Juniper Contrail Plugin. - Fixes to plugin code to handle instance-delete operation properly. - Fix related to service-instance persistence

[4.4]: contrail plugin test log

2014-04-16 Thread Santhosh Edukulla
Team, We could see lot of logs generated for contrail plugin as part of build under 4.4, at the below path ( as an example ). I believe we wanted to clean them up post our tests,running as part of build. ./plugins/network-elements/juniper-contrail/logs/testclient.log Regards, Santhosh

Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2014-03-16 Thread Sachchidanand Vaidya
--- This patch has following changes: - Added service-instance delete command to Juniper Contrail Plugin. - Fixes to plugin code to handle instance-delete operation properly. - Fix related to service-instance persistence and re-creation during Mgmt server reboot. Diffs - client

Re: Event Interceptor fix - contrail plugin : Review Request

2014-02-24 Thread Suresh Balineni
resh Balineni mailto:sbalin...@juniper.net>> Cc: Sunil Bakhru mailto:sbak...@juniper.net>>, Sheng Yang mailto:sh...@yasker.org>>, Hugo mailto:h...@trippaers.nl>>, Animesh Chaturvedi mailto:animesh.chaturv...@citrix.com>> Subject: Re: Event Interceptor fix - contrail plugin :

Re: Event Interceptor fix - contrail plugin : Review Request

2014-02-24 Thread Darren Shepherd
Re: Event Interceptor fix - contrail plugin : Review Request Cc: Sheng Yang ,Hugo ,Animesh Chaturvedi ,Sunil Bakhru Hi Darren, Can you please review and ship these changes (Master branch)? Without this, contrail implementation won't work. Thanks, Suresh From: Suresh Balineni

Re: Event Interceptor fix - contrail plugin : Review Request

2014-02-24 Thread Suresh Balineni
mesh.chaturv...@citrix.com>>, Sheng Yang mailto:sh...@yasker.org>>, Sunil Bakhru mailto:sbak...@juniper.net>> Subject: Re: Event Interceptor fix - contrail plugin : Review Request Hi Darren, Can you please review this ? Thanks, Suresh From: Suresh Balineni mailto:sbalin...@jun

Re: Review Request 18066: Fixing troubling issues on contrail plugin found by FindBugs

2014-02-14 Thread Wilder Rodrigues
> On Feb. 14, 2014, 10:18 a.m., Wilder Rodrigues wrote: > > This review will be discarded. The changes for the contrail plugin were squashed with another commit. A new patch will be uploaded to the review ID 18072 - Wilder --

Re: Review Request 18066: Fixing troubling issues on contrail plugin found by FindBugs

2014-02-14 Thread Wilder Rodrigues
> Review request for cloudstack, daan Hoogland and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > --- > > Fixing troubling issues on contrail plugin related to dereference nullpoint; > adding unit tests to cover changes

Re: Review Request 18066: Fixing troubling issues on contrail plugin found by FindBugs

2014-02-14 Thread Wilder Rodrigues
automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18066/ > --- > > (Updated Feb. 13, 2014, 11:32 a.m.) > > > Review request for cloudstack, daan Hoogland and Hugo Trippaers. > >

Re: Review Request 18066: Fixing troubling issues on contrail plugin found by FindBugs

2014-02-14 Thread Hugo Trippaers
(Updated Feb. 13, 2014, 11:32 a.m.) > > > Review request for cloudstack, daan Hoogland and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > --- > > Fixing troubling issues on contrail plugin related to dereference nullpoint; &g

Review Request 18066: Fixing troubling issues on contrail plugin found by FindBugs

2014-02-13 Thread Wilder Rodrigues
: cloudstack-git Description --- Fixing troubling issues on contrail plugin related to dereference nullpoint; adding unit tests to cover changes on the compare method on the VirtualNetworkModel Diffs - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network

Contrail plugin - VirtualMchineModel

2014-02-11 Thread Wilder Rodrigues
Hi guys, We are working with FindBugs and trying to get Scariest and Scary bugs fixed on the master branch. FindBugs has reported a bug on the contrail plugin, in the VirtualMachineModel class. If you check the Checking the commit id cc2b1c4961244d9c3d8b452f1dcaa6614e56d11a, you will see the

Re: Event Interceptor fix - contrail plugin : Review Request

2014-02-10 Thread Suresh Balineni
turv...@citrix.com>>, Sheng Yang mailto:sh...@yasker.org>>, Sunil Bakhru mailto:sbak...@juniper.net>> Subject: Re: Event Interceptor fix - contrail plugin : Review Request Hi Darren, Can you review this? Thanks, Suresh On Jan 30, 2014, at 4:23 PM, "Suresh Balineni&qu

Re: Review Request 17684: Do not initialize contrail plugin component functionality like db sync, network offerring creation when contrail is not installed

2014-02-04 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17684/#review33636 --- Ship it! Applied to MASTER. Thanks. - Sheng Yang On Feb. 4, 201

Review Request 17684: Do not initialize contrail plugin component functionality like db sync, network offerring creation when contrail is not installed

2014-02-03 Thread Suresh Balineni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17684/ --- Review request for cloudstack. Repository: cloudstack-git Description ---

Re: Review Request 17348: VPC support for contrail plugin

2014-01-30 Thread Sheng Yang
ted Jan. 31, 2014, 12:19 a.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > --- > > VPC Element implementation in contrail plugin > > > Diffs > - > > api/src/com/cloud/network/Netwo

Re: Review Request 17348: VPC support for contrail plugin

2014-01-30 Thread Suresh Balineni
--- Hi Sheng, I have created a new diff with your suggested changes. Please review the same. Thanks, Suresh Repository: cloudstack-git Description --- VPC Element implementation in contrail plugin Diffs (updated) - api/src/com/cloud/network/Network.java 62151a4 plugins

Re: Review Request 17348: VPC support for contrail plugin

2014-01-30 Thread Sheng Yang
a.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > --- > > VPC Element implementation in contrail plugin > > > Diffs > - > > api/src/com/cloud/network/Network.java 62151a4 > > plug

Re: Review Request 17307: Juniper Contrail Plugin fixes

2014-01-28 Thread Hugo Trippaers
: Sachchidanand Vaidya Date: Wed Jan 8 00:26:46 2014 -0800 These are additional fixes to make Juniper Contrail plugin work - Hugo Trippaers On Jan. 24, 2014, 8:06 a.m., Sachchidanand Vaidya wrote: > > --- > This is an auto

Review Request 17348: VPC support for contrail plugin

2014-01-24 Thread Suresh Balineni
--- VPC Element implementation in contrail plugin Diffs - api/src/com/cloud/network/Network.java 62151a4 plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml 4614af7 plugins/network-elements/juniper-contrail/src/org/apache

Review Request 17307: Juniper Contrail Plugin fixes

2014-01-24 Thread Sachchidanand Vaidya
--- These are additional fixes to make Juniper Contrail plugin work on ACS master Diffs - plugins/network-elements/juniper-contrail/pom.xml ae6961e plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/module.properties PRE-CREATION plugins/network

Re: Review Request 16974: (ACS4.3) Juniper Contrail Plugin fixes

2014-01-16 Thread Sachchidanand Vaidya
Hi Hugo, These fixes are blocker for contrail plugin. We missed this fix while submitting patches to ACS. Thanks, Sachin From: Hugo Trippaers mailto:htrippa...@schubergphilis.com>> Reply-To: Hugo Trippaers mailto:htrippa...@schubergphilis.com>> Date: Thursday, January 16, 2014

Re: Review Request 16974: (ACS4.3) Juniper Contrail Plugin fixes

2014-01-16 Thread David Nalley
Agreed - there seems to be a ton being dumped into the contrail plugin. If it wasn't working by feature freeze then we should wait. If all of these are bugfixes, I'd expect to see more bugs filed and referenced in commits, but instead have been seeing commits that seem to expand the fun

Re: Review Request 16974: (ACS4.3) Juniper Contrail Plugin fixes

2014-01-16 Thread Hugo Trippaers
.org/r/16974/ > --- > > (Updated Jan. 16, 2014, 6:53 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > --- > > These are additional fixes to mak

Review Request 16974: (ACS4.3) Juniper Contrail Plugin fixes

2014-01-16 Thread Sachchidanand Vaidya
--- These are additional fixes to make Juniper Contrail plugin work in ACS4.3. These changes were missed during last commit Diffs - plugins/network-elements/juniper-contrail/pom.xml 22167fe plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/module.properties

Re: Review Request 16813: Contrail plugin fixes

2014-01-15 Thread Sheng Yang
d Jan. 15, 2014, 7:23 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > --- > > Contrail plugin fixes > - this patch is already applied to 4.3 > - a master branch patch. > > >

Re: Review Request 16813: Contrail plugin fixes

2014-01-15 Thread Suresh Balineni
--- Hi Sheng, Please review this and apply to master branch. It has single commit. Repository: cloudstack-git Description --- Contrail plugin fixes - this patch is already applied to 4.3 - a master branch patch. Diffs (updated) - api/src/com/cloud/network/Network.java

Re: Review Request 16813: Contrail plugin fixes

2014-01-14 Thread Sheng Yang
2014, 10:56 p.m. UTC, Suresh Balineni wrote: > Review request for cloudstack. > By Suresh Balineni. > > *Updated Jan. 14, 2014, 10:56 p.m.* > *Repository: *cloudstack-git > Description > > Contrail plugin fixes > - this patch is already applied to 4.3 > - a master b

Re: Review Request 16813: Contrail plugin fixes

2014-01-14 Thread Suresh Balineni
cloudstack. By Suresh Balineni. Updated Jan. 14, 2014, 10:56 p.m. Repository: cloudstack-git Description Contrail plugin fixes - this patch is already applied to 4.3 - a master branch patch. Testing compiled and verified locally Diffs * api/src/com/cloud/network/Network.java (0b76789)

Re: Review Request 16813: Contrail plugin fixes

2014-01-14 Thread Sheng Yang
pache.org/r/16813/ > --- > > (Updated Jan. 14, 2014, 10:56 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > --- > > Contrail plugin fixes > - this patch is already applied to 4.3 >

Re: Review Request 16805: Contrail plugin fixes - db update, policy port end fix

2014-01-14 Thread Sheng Yang
Updated Jan. 14, 2014, 11:03 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > --- > > Contrail plugin fixes. > - db updates must be done inside a transaction. > - network policy port end type err

Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-14 Thread Sachchidanand Vaidya
Thanks Sheng. Best Regards, Sachin On 1/14/14 1:56 PM, "Sheng Yang" wrote: > >--- >This is an automatically generated e-mail. To reply, visit: >https://reviews.apache.org/r/16258/#review31812 >--

Re: Review Request 16805: Contrail plugin fixes - db update, policy port end fix

2014-01-14 Thread Suresh Balineni
--- Hi Sheng, I updated the fix without db transaction wrappers. This is a 4.3 version of patch. Please review and ship it. Thanks, Suresh Repository: cloudstack-git Description --- Contrail plugin fixes. - db updates must be done inside a transaction. - network policy port end type

Re: Review Request 16813: Contrail plugin fixes

2014-01-14 Thread Suresh Balineni
--- Hi Sheng, I removed DB Transaction statements when update is invoked, since they are atomic operations. This is a master version diff, contains both commits. Thanks - Suresh Repository: cloudstack-git Description --- Contrail plugin fixes - this patch is already applied to 4.3

Re: Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-14 Thread Sachchidanand Vaidya
dev@cloudstack.apache.org>" mailto:dev@cloudstack.apache.org>>, Admin mailto:vaidy...@juniper.net>> Subject: Re: Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin. I don't think it's a feature after ch

Re: Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-14 Thread Sheng Yang
I don't think it's a feature after checking the patch. It's basically they called it "L3VPN" instead of "GRE" in the patch I think. --Sheng On Tue, Jan 14, 2014 at 1:55 PM, David Nalley wrote: > Why are we adding functionality after 4.3 has closed? > > --David > > On Tue, Jan 14, 2014 at 4:53

Re: Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-14 Thread David Nalley
Why are we adding functionality after 4.3 has closed? --David On Tue, Jan 14, 2014 at 4:53 PM, Sheng Yang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16841/#review31810 > -

Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-14 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16258/#review31812 --- Ship it! Applied to MASTER. Thanks. - Sheng Yang On Jan. 14, 20

Re: Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-14 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16841/#review31810 --- Ship it! Applied to 4.3 branch. Thanks. - Sheng Yang On Jan. 1

Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-14 Thread Sachchidanand Vaidya
Hi Sheng, I have updated the review with changes based off latest on ACS master. Thanks & Best Regards, Sachin On 1/14/14 1:25 PM, "Sheng Yang" wrote: > >--- >This is an automatically generated e-mail. To reply, visit: >https://reviews

Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-14 Thread Sachchidanand Vaidya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16258/ --- (Updated Jan. 14, 2014, 9:44 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-14 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16258/#review31802 --- Looks good to me, but cannot applied to the latest MASTER branch(I s

Re: Review Request 16813: Contrail plugin fixes

2014-01-14 Thread Sheng Yang
-- > > (Updated Jan. 13, 2014, 1:02 a.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > --- > > Contrail plugin fixes > - this patch is already applied to 4.3 > - a master branch patch. >

Re: Review Request 16805: Contrail plugin fixes - db update, policy port end fix

2014-01-14 Thread Sheng Yang
ews.apache.org/r/16805/ > --- > > (Updated Jan. 12, 2014, 12:08 a.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > --- > > Contrail plugin fixes. > - db updates must be done inside a transaction. &g

Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-13 Thread Sachchidanand Vaidya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16841/ --- Review request for cloudstack. Repository: cloudstack-git Description ---

Re: Review Request 16805: Contrail plugin fixes - db update, policy port end fix

2014-01-13 Thread Suresh Balineni
stack.apache.org>> Subject: Review Request 16805: Contrail plugin fixes - db update, policy port end fix This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16805/ Review request for cloudstack. By Suresh Balineni. Repository: cloudstack-git Description

Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-12 Thread Sachchidanand Vaidya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16258/ --- (Updated Jan. 13, 2014, 5:46 a.m.) Review request for cloudstack. Changes ---

Re: Review Request 16813: Contrail plugin fixes

2014-01-12 Thread Suresh Balineni
Hi Sheng, Please review and ship this master version patch of contrail plugin fixes : https://reviews.apache.org/r/16813/ This patch contains fixes of 4.3 review requests : https://reviews.apache.org/r/16642/ https://reviews.apache.org/r/16805/ Thanks, Suresh From: Suresh Balineni

Review Request 16813: Contrail plugin fixes

2014-01-12 Thread Suresh Balineni
--- Contrail plugin fixes - this patch is already applied to 4.3 - a master branch patch. Diffs - api/src/com/cloud/network/Network.java 0b76789 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 5adbacd

Review Request 16805: Contrail plugin fixes - db update, policy port end fix

2014-01-11 Thread Suresh Balineni
--- Contrail plugin fixes. - db updates must be done inside a transaction. - network policy port end type error. - default host contrail vnc is set to local host. This is considered if config is not present. Diffs - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack

Re: Review Request 16276: Contrail Plugin Code fixes - Virtual Network name should have fully qualified name for policy creation.

2013-12-30 Thread Sheng Yang
: cloudstack-git > > > Description > --- > > Contrail Virtual Router Controller is expecting virtual network name should > have a fully qualified name while creating a Network Policy in the > controller. > > This fix is only applicable to contrail plug

Re: Review Request 16279: Contrail plugin fixes for db updates, adding JuniperContrailVPCRouter as a SDN Provider.

2013-12-30 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16279/#review30983 --- And this fix involved VPC, which I don't think would be contained in

Re: Review Request 16279: Contrail plugin fixes for db updates, adding JuniperContrailVPCRouter as a SDN Provider.

2013-12-30 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16279/#review30981 --- Hi Suresh, There is no way we can review this since it's not added

Re: Review Request 16276: Contrail Plugin Code fixes - Virtual Network name should have fully qualified name for policy creation.

2013-12-30 Thread Sheng Yang
m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > --- > > Contrail Virtual Router Controller is expecting virtual network name should > have a fully qualified name while creating a Network Policy in the &

Re: Review Request 16276: Contrail Plugin Code fixes - Virtual Network name should have fully qualified name for policy creation.

2013-12-15 Thread Suresh Balineni
. Repository: cloudstack-git Description --- Contrail Virtual Router Controller is expecting virtual network name should have a fully qualified name while creating a Network Policy in the controller. This fix is only applicable to contrail plugin. Diffs - Diff: https://reviews.apache.org/r

Re: Review Request 16279: Contrail plugin fixes for db updates, adding JuniperContrailVPCRouter as a SDN Provider.

2013-12-15 Thread Suresh Balineni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16279/ --- (Updated Dec. 15, 2013, 11:57 p.m.) Review request for cloudstack. Repository

Review Request 16279: Contrail plugin fixes for db updates, adding JuniperContrailVPCRouter as a SDN Provider.

2013-12-15 Thread Suresh Balineni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16279/ --- Review request for cloudstack. Repository: cloudstack-git Description ---

Review Request 16276: Contrail Plugin Code fixes - Virtual Network name should have fully qualified name for policy creation.

2013-12-15 Thread Suresh Balineni
--- Contrail Virtual Router Controller is expecting virtual network name should have a fully qualified name while creating a Network Policy in the controller. This fix is only applicable to contrail plugin. Diffs - Diff: https://reviews.apache.org/r/16276/diff/ Testing --- Network

Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2013-12-13 Thread Sachchidanand Vaidya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16258/ --- Review request for cloudstack. Repository: cloudstack-git Description ---

Re: Contrail plugin

2013-10-09 Thread Pedro Roque Marques
complete reliability. 99% of the time it > will work, but since there is no way to tie your code to the > transaction of the API code, there is a small window if the JVM dies, > you won't be called. I know this sounds nit picky, but I hate when > there is a situation that could

Re: Contrail plugin

2013-10-09 Thread Darren Shepherd
is a small window if the JVM dies, you won't be called. I know this sounds nit picky, but I hate when there is a situation that could happen that there is no recovery from. Is it possible for the contrail plugin to on-demand register the account/projects? So only when the element/guru/whate

Re: Contrail plugin

2013-10-09 Thread Murali Reddy
ric >way to accomplish that... >The contrail plugin wants to know about project creation and deletion. >Projects need to be reflected in the contrail-api server; the project >delete notification is necessary to understand that the project is not >longer used. > >When it comes to net

Re: Contrail plugin

2013-10-08 Thread Pedro Roque Marques
Darren, Using ActionEvents is not desirable for the plugin either... today CloudStack lacks the ability for a component/plugin to associate itself to the life-cycle of an object. It would be ideal if there was a generic way to accomplish that... The contrail plugin wants to know about project

Re: Contrail plugin

2013-10-08 Thread Darren Shepherd
I'll take some time and review this code too. I already know there's going to be a conflict with the stuff I did in the spring modularization branch. Moving to full spring we have gotten rid of the custom ACS AOP for the mgmt server. This code relies on that framework so it will have to move to

Re: Contrail plugin

2013-10-08 Thread Chip Childers
On Tue, Oct 08, 2013 at 09:43:39AM -0700, Pedro Roque Marques wrote: > Chip, > > On Oct 8, 2013, at 7:23 AM, Chip Childers wrote: > > > As stated, I've imported the contrail plugin donation into the contrail > > branch. > > > > I've taken the ti

Re: Contrail plugin

2013-10-08 Thread Pedro Roque Marques
Chip, On Oct 8, 2013, at 7:23 AM, Chip Childers wrote: > As stated, I've imported the contrail plugin donation into the contrail > branch. > > I've taken the time to add the ASF license header to all of the new files in > that branch. I think we have to complete

Re: Contrail plugin

2013-10-08 Thread Pedro Roque Marques
On Oct 8, 2013, at 7:36 AM, Chip Childers wrote: > On Tue, Oct 08, 2013 at 07:59:24PM +0530, Prasanna Santhanam wrote: >> On Tue, Oct 08, 2013 at 10:23:32AM -0400, Chip Childers wrote: >>> 3) I'd love if we could get some consensus on what additional tests and / >>> or changes to the test approach

Re: Contrail plugin

2013-10-08 Thread Chip Childers
On Tue, Oct 08, 2013 at 07:59:24PM +0530, Prasanna Santhanam wrote: > On Tue, Oct 08, 2013 at 10:23:32AM -0400, Chip Childers wrote: > > 3) I'd love if we could get some consensus on what additional tests and / > > or changes to the test approach are needed. Prasanna - as with Hugo and > > Chirade

Re: Contrail plugin

2013-10-08 Thread Prasanna Santhanam
On Tue, Oct 08, 2013 at 10:23:32AM -0400, Chip Childers wrote: > As stated, I've imported the contrail plugin donation into the contrail > branch. > > I've taken the time to add the ASF license header to all of the new files > in that branch. I think we have to complete

Contrail plugin

2013-10-08 Thread Chip Childers
As stated, I've imported the contrail plugin donation into the contrail branch. I've taken the time to add the ASF license header to all of the new files in that branch. I think we have to complete the following in order to merge into master. 1) I'd like to see the package struc

Re: FWD: [IP CLEARANCE] Contrail Plugin for CloudStack

2013-10-08 Thread Chip Childers
I'll update this thread when we have cleared that hurdle, allowing us to > accept the patch into the repo. > > -chip > > - Forwarded message from Chip Childers - > > Date: Fri, 4 Oct 2013 13:50:47 -0400 > From: Chip Childers > To: gene...@incubator.apache.

FWD: [IP CLEARANCE] Contrail Plugin for CloudStack

2013-10-04 Thread Chip Childers
Date: Fri, 4 Oct 2013 13:50:47 -0400 From: Chip Childers To: gene...@incubator.apache.org Subject: [IP CLEARANCE] Contrail Plugin for CloudStack Message-ID: <20131004175047.gg88...@uslt-205755.sungardas.corp> Juniper Networks, Inc has dontated a plugin for Apache CloudStack to work with the

[RESULTS][VOTE] Accept the donation of a Contrail plugin into Apache CloudStack

2013-10-01 Thread Chip Childers
With 13 +1 votes, and no other votes, this passes. I'll work with Pedro and Juniper to complete the donation. -chip On Wed, Sep 25, 2013 at 01:13:07PM -0400, Chip Childers wrote: > Hi all! > > As stated in other threads, Juniper is proposing the donation of a > Contrail

RE: [VOTE] Accept the donation of a Contrail plugin into Apache CloudStack

2013-09-26 Thread Sudha Ponnaganti
+1 (binding) on donation -Original Message- From: Chip Childers [mailto:chipchild...@apache.org] Sent: Wednesday, September 25, 2013 10:13 AM To: dev@cloudstack.apache.org Subject: [VOTE] Accept the donation of a Contrail plugin into Apache CloudStack Hi all! As stated in other threads

RE: [VOTE] Accept the donation of a Contrail plugin into Apache CloudStack

2013-09-26 Thread Alex Huang
+1 (binding) --Alex > -Original Message- > From: Chip Childers [mailto:chipchild...@apache.org] > Sent: Wednesday, September 25, 2013 10:13 AM > To: dev@cloudstack.apache.org > Subject: [VOTE] Accept the donation of a Contrail plugin into Apache > CloudStack > >

Re: [VOTE] Accept the donation of a Contrail plugin into Apache CloudStack

2013-09-26 Thread Simon Weller
+1. - Original Message - From: "Chip Childers" To: dev@cloudstack.apache.org Sent: Wednesday, September 25, 2013 12:13:07 PM Subject: [VOTE] Accept the donation of a Contrail plugin into Apache CloudStack Hi all! As stated in other threads, Juniper is proposing the don

Re: [VOTE] Accept the donation of a Contrail plugin into Apache CloudStack

2013-09-26 Thread Ian Duffy
Agree with Daan unit tests would be nice. +1 On 26 September 2013 07:59, Wei ZHOU wrote: > +1 > > > 2013/9/25 Chip Childers > >> Hi all! >> >> As stated in other threads, Juniper is proposing the donation of a >> Contrail plugin to Apache CloudStack.

Re: [VOTE] Accept the donation of a Contrail plugin into Apache CloudStack

2013-09-26 Thread Wei ZHOU
+1 2013/9/25 Chip Childers > Hi all! > > As stated in other threads, Juniper is proposing the donation of a > Contrail plugin to Apache CloudStack. The code itself has been posted > to reviewboard [1]. The design has been documented by Pedro [2]. > > [1] https://revie

Re: [VOTE] Accept the donation of a Contrail plugin into Apache CloudStack

2013-09-25 Thread Sebastien Goasguen
+1 On Sep 26, 2013, at 12:17 AM, Francois Gaudreault wrote: > Definitely +1 on this :) > > Francois > > On 2013-09-25 1:13 PM, Chip Childers wrote: >> Hi all! >> >> As stated in other threads, Juniper is proposing the donation of a >> Contrail plugin

Re: [VOTE] Accept the donation of a Contrail plugin into Apache CloudStack

2013-09-25 Thread Francois Gaudreault
Definitely +1 on this :) Francois On 2013-09-25 1:13 PM, Chip Childers wrote: Hi all! As stated in other threads, Juniper is proposing the donation of a Contrail plugin to Apache CloudStack. The code itself has been posted to reviewboard [1]. The design has been documented by Pedro [2]. [1

Re: [VOTE] Accept the donation of a Contrail plugin into Apache CloudStack

2013-09-25 Thread David Nalley
+1 On Wed, Sep 25, 2013 at 10:13 AM, Chip Childers wrote: > Hi all! > > As stated in other threads, Juniper is proposing the donation of a > Contrail plugin to Apache CloudStack. The code itself has been posted > to reviewboard [1]. The design has been documented by Pedro [2]

  1   2   >