----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16805/#review31799 -----------------------------------------------------------
Dao.update don't need to be wrapped by transaction. It's already atomic. - Sheng Yang On Jan. 12, 2014, 12:08 a.m., Suresh Balineni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16805/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2014, 12:08 a.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > Contrail plugin fixes. > - db updates must be done inside a transaction. > - network policy port end type error. > - default host contrail vnc is set to local host. This is considered if > config is not present. > > > Diffs > ----- > > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java > 18e8bde > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java > eea5026 > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java > d5a8722 > > Diff: https://reviews.apache.org/r/16805/diff/ > > > Testing > ------- > > verified locally. > > > Thanks, > > Suresh Balineni > >
