That's not how we deal with patches... Please merge them into one patch and upload to the reviewboard as diff v2 instead. That would be easier for review.
Thanks. --Sheng On Tue, Jan 14, 2014 at 5:36 PM, Suresh Balineni < sbalin...@service.juniper.net> wrote: > Hi Sheng, > > This patch contains two commits.. > 1. Previous patch. > 2. New updated code with DB transactions removed. > > If look at the second commit, you will see added diff. > > Thanks, > Suresh > > Sent from my iPhone > > On Jan 14, 2014, at 5:32 PM, "Sheng Yang" <sh...@yasker.org> wrote: > > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16813/ > > I didn't see the updated patch. Both attached file and diff are old with > transactions. > > > - Sheng Yang > > On January 14th, 2014, 10:56 p.m. UTC, Suresh Balineni wrote: > Review request for cloudstack. > By Suresh Balineni. > > *Updated Jan. 14, 2014, 10:56 p.m.* > *Repository: *cloudstack-git > Description > > Contrail plugin fixes > - this patch is already applied to 4.3 > - a master branch patch. > > > Testing > > compiled and verified locally > > Diffs > > - api/src/com/cloud/network/Network.java (0b76789) > - > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java > (5adbacd) > - > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java > (079035b) > - > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java > (335299e) > - > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java > (ed58594) > - > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java > (e2845b7) > - > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java > (52fe31e) > - > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java > (5030bb7) > - > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java > (98be288) > - > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java > (PRE-CREATION) > - > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java > (a9bc5c1) > - > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java > (df0af90) > - > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java > (547d4bd) > - > plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java > (806dd21) > - > plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java > (fff4e5a) > > View Diff <https://reviews.apache.org/r/16813/diff/> > File Attachments > > - Contrail fixes master branch - with fix for sheng review > comment<https://reviews.apache.org/media/uploaded/files/2014/01/14/26c95dad-b064-4e66-8128-08d786858cc6__master.patch> > >
