Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1996#discussion_r111075302
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/user/GetUserKeysCmd.java ---
@@ -0,0 +1,76 @@
+// Licensed to the Apache Software
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1996#discussion_r111075076
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/user/GetUserKeysCmd.java ---
@@ -0,0 +1,76 @@
+// Licensed to the Apache Software
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1996#discussion_r111078382
--- Diff: server/src/com/cloud/api/ApiDBUtils.java ---
@@ -559,6 +561,8 @@
@Inject
private VpcManager vpcMgr;
@Inject
Hi Wido,
Check initDataSource() in TransactionLegacy.java. The connection properties are
read from db.properties.
-Koushik
On 11/04/17, 10:27 PM, "Wido den Hollander" wrote:
> Op 11 april 2017 om 10:51 schreef Rohit Yadav :
>
>
> Hi Wido,
>
>
> You're righ
Check the MS logs to see if there are OOM exceptions due to threads not
available. If that’s the case then you may have to adjust nproc limits in
/etc/security/limits.conf.
On 11/04/17, 1:11 PM, "Daan Hoogland" wrote:
My next step is to rebase my change to 4.9 and see if that works. But t
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1960
@abhinandanprateek Initially I also thought that this is about host HA. But
after reading the FS I had doubts and asked about the definition of "host HA".
If you refer to the dis
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/2032
LGTM. Build is broken due to this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1960
There are open questions that I had asked in the dev@ list and haven't seen
satisfactory answers to them. I am -1 on this feature till the need for a new
VM HA framework is just
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/2019
Code changes LGTM. @SudharmaJain Can you check on the travis failures?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1953
@karuturi This PR is not correct and is resulting in travis CI failures. It
needs to be properly fixed.
---
If your project is set up for it, you can reply to this email and have your
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/2019
@SudharmaJain Although the PR fixes the tests but it is not correct. I
looked at PR #1953 and the changes there are incorrect.
getMaxDataVolumes() returns only the data volume count
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1853
Code change LGTM.
@anshul1886 Please make sure Travis is green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1867
Code changes LGTM
@anshul1886 Please check on travis failure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1853#discussion_r106589966
--- Diff: server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java ---
@@ -312,6 +317,65 @@ public DedicatedResourceVO findByHostId(Long hostId
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1853#discussion_r106590720
--- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ---
@@ -584,105 +583,64 @@ private void
checkForNonDedicatedResources
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1853#discussion_r106591079
--- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ---
@@ -584,105 +583,64 @@ private void
checkForNonDedicatedResources
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1853#discussion_r106138864
--- Diff: server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java ---
@@ -312,6 +317,65 @@ public DedicatedResourceVO findByHostId(Long hostId
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1853#discussion_r106142726
--- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ---
@@ -584,105 +583,64 @@ private void
checkForNonDedicatedResources
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1853#discussion_r106145072
--- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ---
@@ -584,105 +583,64 @@ private void
checkForNonDedicatedResources
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1867#discussion_r106133214
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
---
@@ -191,7 +191,8 @@ public void
processEvent
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1867#discussion_r103894706
--- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ---
@@ -1181,6 +1181,17 @@ public boolean configure(String name, Map params
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1867#discussion_r106134695
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -194,18 +194,22 @@ protected
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1867#discussion_r106137098
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1078,6 +1082,16 @@ public void cleanupStorage(boolean recurring
Hi Jeromy,
Thanks for the proposal. It will good if you can create a FS in cwiki for the
same. I saw your comment about force stopping VMs affected by primary storage
outage. If this can be done without any issues then it can be leveraged to
improve the current behavior of Cloudstack as well. C
Looks like there is already a PR for the same issue
https://github.com/apache/cloudstack/pull/1982 from Kishan.
-Koushik
On 03/03/17, 1:58 PM, "Rohit Yadav" wrote:
-1 (binding)
All, I've found an upgrade blocker. Pre 4.6 users are required to seed 4.6
systemvmtemplate to pro
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1865
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1865#discussion_r103875741
--- Diff: server/src/com/cloud/api/ApiServer.java ---
@@ -430,8 +433,27 @@ public void handle(final HttpRequest request, final
HttpResponse
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1865
@anshul1886 @karuturi Should this be treated as a security issue and fixed
on priority?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1868
Code changes LGTM, also verified that deployment is not retried in case of
failure if host is specified
---
If your project is set up for it, you can reply to this email and have your
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1980
Is it only showing VR or other appliances providing service in that
network? If it is the latter then the tab name is appropriate otherwise it is
better to name it something like "Vi
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1278
I think disabled resource related checks are only applicable for regular
users, root/system users can go ahead and deploy VMs in disabled resources as
well.
---
If your project is set up
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1960
@abhinandanprateek If you refer to the discussion on dev@
https://goo.gl/cU8RuX, @rhtyd proposed it as a generic HA framework for any
resources (and not limited to VM). Now if it just a
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1960
I have already raised some questions on dev@ on the need for a new HA
framework when the existing HA framework can do all the things mentioned. The
new framework only supports VM HA. If we
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/commit/fa85151be962824cc88776a0264e1ac6ef90560c#commitcomment-21082422
In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java:
In server/src/com/cloud/vm/snapshot
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1975
ping @karuturi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/1975
Fix build failure on master
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Accelerite/cloudstack build-failure
Alternatively you can
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1886
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1825
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1968
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1967
Code change LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1964
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1825
@karuturi This can be merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1941#discussion_r102698293
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -1415,6 +1417,10 @@ public VM
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1771#discussion_r102445777
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -3085,9 +3085,10 @@ public GuestVlan
dedicateGuestVlanRange
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1951
I already see schema-4920to41000.sql and the corresponding cleanup file in
master. So how will this fit in the overall scheme? Is there any plans for
4.9.3?
---
If your project is set up
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1773
I think changing the default API behaviour for fixing a bug should be ok as
long as documented properly. Also in this case the deletion criteria is made
more strict, so there is no unwanted
Regards.
From: Koushik Das
Sent: 20 February 2017 11:45
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS][FS] Host HA for CloudStack
Rohit,
Thanks for the effort you have put in writing the FS. I have some questions
based on my
Rohit,
Thanks for the effort you have put in writing the FS. I have some questions
based on my initial reading of the FS.
1. “Host HA” – In the FS you are talking about a generic HA framework but it is
not clear what is meaning of “host HA”. Is it something like all or some VMs
running on a ho
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1838
Code changes LGTM
@karuturi This can be merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1771#discussion_r101486770
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -3085,9 +3085,10 @@ public GuestVlan
dedicateGuestVlanRange
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1829
@borisstoyanov Sorry don't have a windows template
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1829
@borisstoyanov try using a Windows template
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1834
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1758
@karuturi This is ready for merge. UI change only, 2 LGTMs, UI screenshot
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1771#discussion_r101451791
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -3085,9 +3085,10 @@ public GuestVlan
dedicateGuestVlanRange
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1786
LGTM based on code review
@karuturi Since this is a network plugin related fix and requires
Netscaler, I don't think there is a need to run the BVTs.
---
If your project is set u
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1792
Code changes LGTM
@nitin-maharana Can you check on the travis failure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
The hardcoded value of 15 needs to be fixed, it can be replaced with
getMaxDataVolumesSupported() just above it. Please file a bug and if possible
raise a PR as well.
-Koushik
On 15/02/17, 11:21 PM, "Voloshanenko Igor" wrote:
On VM we try to emulate real hardware )))
So any device hon
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1889
LGTM based on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1885
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1885#discussion_r100767709
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -460,6 +460,12 @@ boolean checkIfIpAssocRequired(Network network,
boolean
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r100478202
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean
cleanup
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r100477949
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean
cleanup
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1936
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1906#discussion_r100281158
--- Diff:
plugins/network-elements/opendaylight/src/main/java/org/apache/cloudstack/network/opendaylight/OpendaylightElement.java
---
@@ -156,7
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1930
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1933
@abhinandanprateek Looks like there is another PR #1856 related to this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r100267498
--- Diff: setup/db/db/schema-490to4910.sql ---
@@ -71,3 +71,17 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Welcome back Daan!
On 01/02/17, 1:56 PM, "Daan Hoogland" wrote:
Hello,
My name is Daan Hoogland. I've been mostly out of the community since May
last year. I am now back through the generous sponsorship of my new employer
and will be working (mostly) as developer on cloudstac
Looks like a bug to me. Please file one in jira and if possible submit a PR to
fix it.
Thanks,
Koushik
On 13/01/17, 5:53 PM, "Wiesener, Erik" wrote:
Hello CloudStack development team,
It seems not very logical that the action : “delete Volume” is a
synchronous job. This may cause
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1819
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1889#discussion_r95973044
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java ---
@@ -206,7 +206,7 @@ public void execute() {
} else
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1889#discussion_r95973392
--- Diff: ui/scripts/ui-custom/migrate.js ---
@@ -0,0 +1,127 @@
+// Licensed to the Apache Software Foundation (ASF) under one
--- End diff
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1848
@rashmidixit Please provide screenshots for UI changes (better if you also
provide screenshot prior to the fix). Also for a cluster enabled/disabled and
managed/unmanaged are different
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1852
@rashmidixit Code LGTM. Please provide screenshots of the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1899
@rhtyd If you had checked #1812 you wouldn't have asked these questions :)
This config was introduced in #1812 and the scope was incorrectly put as
zone, the config is meant to
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1892
@sureshanaparti please post a screen shot of the UI change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1899
@rhtyd Tests are present in #1812
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1899
Merging this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95514039
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -350,6 +368,24 @@ public VMSnapshot allocVMSnapshot(Long vmId, String
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95515374
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -338,10 +354,12 @@ public VMSnapshot allocVMSnapshot(Long vmId, String
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95517419
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95517522
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -643,6 +679,65 @@ else if (jobResult instanceof Throwable
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95514745
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95517926
--- Diff: setup/db/db/schema-490to4910.sql ---
@@ -71,3 +71,17 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95516498
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95516609
--- Diff: engine/schema/src/com/cloud/vm/UserVmDetailVO.java ---
@@ -80,4 +80,8 @@ public boolean isDisplay() {
return display
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1812
@rhtyd Sure will let you know if trillian tests are needed. In this case XS
test results were already there from @cloudmonger. I used the git-pr script but
not sure why the merge commit
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1899
@ustcweizhou please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/1899
CLOUDSTACK-9650: Allow starting VMs regardless of cpu/memory cluster.â¦
â¦disablethreshold setting
Fixed the scope of configuration flag 'cluster.threshold.enabled'
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1812
Looks like this is ready for merge. None of the test failures are related
to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1886#discussion_r94721965
--- Diff: core/src/com/cloud/network/resource/TrafficSentinelResource.java
---
@@ -228,6 +239,7 @@ private DirectNetworkUsageAnswer
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1829
@pdube The description mentions about a way to workaround the problem,
thats the reason for not calling it a blocker. If you think the issue is
important for the current 4.9 release, please
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1882
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1861#discussion_r94206618
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -230,6 +230,7 @@
import
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1861#discussion_r94206556
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
---
@@ -123,12 +125,14 @@
import
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1861#discussion_r94206888
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -839,7 +840,12 @@ private int
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1844
LGTM. Unit tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1850
Code changes LGTM. Can you add some unit/marvin tests for the scenario that
you have mentioned?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1841
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
1 - 100 of 926 matches
Mail list logo
