Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1865#discussion_r103875741
--- Diff: server/src/com/cloud/api/ApiServer.java ---
@@ -430,8 +433,27 @@ public void handle(final HttpRequest request, final
HttpResponse response, final
if (!(responseType.equals(HttpUtils.RESPONSE_TYPE_JSON) ||
responseType.equals(HttpUtils.RESPONSE_TYPE_XML))) {
responseType = HttpUtils.RESPONSE_TYPE_XML;
}
-
try {
+ //verify that parameter is legit for passing via admin port
--- End diff --
Check if it makes sense to move this as a separate helper method. There are
also other places in code that reads the annotation on the API commands and
parameters. Check if some of them can be reused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
