[GitHub] cloudstack-www pull request: Improvements to survey.html

2015-10-12 Thread terbolous
GitHub user terbolous opened a pull request: https://github.com/apache/cloudstack-www/pull/16 Improvements to survey.html Made the survey.html agnostic to protocol used, previously the iframe was hardcoded with a http:// link and this breaks when visiting the site over https.

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828906 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java --- @@ -0,0 +1,147 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828868 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java --- @@ -0,0 +1,147 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828859 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java --- @@ -0,0 +1,132 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

2015-10-12 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/920#issuecomment-147607738 Following are the tests that run on Simulator basic and adv - separately, please add ".py" to the end. Simulator Basic - integration.smoke.test_affinity_group

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828291 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java --- @@ -0,0 +1,132 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828262 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java --- @@ -0,0 +1,132 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828211 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation (AS

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828218 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation (AS

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828178 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation (AS

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828171 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation (AS

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828125 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation (AS

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828093 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,444 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828072 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827968 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827959 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827948 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827796 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaStatementResponse.java --- @@ -0,0 +1,130 @@ +//Licensed to th

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827702 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827602 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827559 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827531 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827414 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827329 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java --- @@ -0,0 +1,147 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827287 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/UserVmDetailsDaoImpl.java --- @@ -0,0 +1,62 @@ +// Licensed to the Apache Sof

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827227 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java --- @@ -0,0 +1,86 @@ +// Licensed to the Apache S

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41826854 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,81 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41826803 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,137 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41826727 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,81 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-147540509 For classes implementing the ``equals`` and ``hashCode`` methods, please add a unit test case that utilizes Guava's EqualTester to verify their implementation. Ple

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807861 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspManagerClient.java --- @@ -0,0 +1,41 @@ +// +// Licensed to th

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807843 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspManagerClient.java --- @@ -0,0 +1,41 @@ +// +// Licensed to th

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807870 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspSyncClient.java --- @@ -21,7 +21,7 @@ public interface Nuag

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807853 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspManagerClient.java --- @@ -0,0 +1,41 @@ +// +// Licensed to th

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807829 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspManagerClient.java --- @@ -0,0 +1,41 @@ +// +// Licensed to th

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807836 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspManagerClient.java --- @@ -0,0 +1,41 @@ +// +// Licensed to th

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807756 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspGuruClient.java --- @@ -21,24 +21,22 @@ import java.util.Co

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807732 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspGuruClient.java --- @@ -21,24 +21,22 @@ import java.util.Co

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807766 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspGuruClient.java --- @@ -21,24 +21,22 @@ import java.util.Co

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807713 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspElementClient.java --- @@ -24,13 +24,18 @@ public interface

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807696 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspElementClient.java --- @@ -24,13 +24,18 @@ public interface

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807704 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspElementClient.java --- @@ -24,13 +24,18 @@ public interface

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807743 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspGuruClient.java --- @@ -21,24 +21,22 @@ import java.util.Co

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807645 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspApiClient.java --- @@ -21,10 +21,10 @@ public interface Nua

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807601 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java --- @@ -19,28 +19,86 @@ package net.nuage.

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807630 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspApiClient.java --- @@ -21,10 +21,10 @@ public interface Nua

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41807611 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java --- @@ -19,28 +19,86 @@ package net.nuage.

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41806397 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -437,31 +463,79 @@ private Answer executeReques

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41806385 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -441,6 +456,44 @@ private Answer executeRequest

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41806331 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -437,31 +463,79 @@ private Answer executeReques

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41806320 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -437,31 +463,79 @@ private Answer executeReques

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41806277 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -441,6 +456,44 @@ private Answer executeRequest

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41806251 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -424,9 +449,10 @@ private Answer executeRequest

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41806263 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -441,6 +456,44 @@ private Answer executeRequest

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41806186 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -403,20 +412,36 @@ private Answer executeReques

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41806223 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -424,9 +449,10 @@ private Answer executeRequest

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41806177 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -393,9 +401,10 @@ private Answer executeRequest

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41806130 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -360,32 +375,25 @@ private Answer executeReque

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41806067 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -360,32 +375,25 @@ private Answer executeReque

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41806010 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -262,15 +260,19 @@ public String getName() {

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41805940 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -285,60 +507,341 @@ public boolean deleteNua

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41805905 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -285,60 +507,341 @@ public boolean deleteNua

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41805880 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -285,60 +507,341 @@ public boolean deleteNua

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41805233 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -129,6 +145,18 @@ AgentManager _agentMgr

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41804947 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -285,60 +525,345 @@ public boolean deleteNua

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41804704 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -285,60 +525,345 @@ public boolean deleteNua

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41804441 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -247,6 +467,26 @@ public boolean deleteNuage

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41804334 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41804131 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41803966 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41803927 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41803706 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41803659 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41803532 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41803470 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41803394 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: Usage event fixes for deleted accounts

2015-10-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/924#issuecomment-147493625 Hi @nnesic, you can do that by force pushing your commits again to the PR branch. The tests will then run again. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41780424 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41780153 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -122,13 +213,13 @@ cmdList.add(D

[GitHub] cloudstack pull request: Usage event fixes for deleted accounts

2015-10-12 Thread nnesic
Github user nnesic commented on the pull request: https://github.com/apache/cloudstack/pull/924#issuecomment-147469015 Hi, could you please re-trigger the build, since it seems to have crashed? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41780040 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -109,12 +163,49 @@ @Inject

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41780074 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -109,12 +163,49 @@ @Inject

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41779445 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -358,19 +442,28 @@ private String getVirtua

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41779931 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -67,25 +74,76 @@ import com.cloud.networ

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41779432 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -358,19 +442,28 @@ private String getVirtua

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41779218 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -322,35 +389,52 @@ public void shutdown(Net

[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...

2015-10-12 Thread atrbgithub
GitHub user atrbgithub opened a pull request: https://github.com/apache/cloudstack/pull/925 Fix for CLOUDSTACK-8937 - XenServer migrations with storage failing i… …n clustered management server environment This pull request relates to the following Jira bug report: h

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41779077 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -129,66 +134,94 @@ public Network design(Ne

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41778993 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -129,66 +134,94 @@ public Network design(Ne

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41778939 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -129,66 +134,94 @@ public Network design(Ne

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41778777 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -114,7 +117,9 @@ public Network design(Netw

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41778652 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -454,6 +563,80 @@ protected boolean applyACLRules

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41778678 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -454,6 +563,80 @@ protected boolean applyACLRules

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41778623 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -447,13 +568,95 @@ protected boolean applyACLRule

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41778534 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -368,18 +492,15 @@ public boolean applyStaticNats

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41778472 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -303,13 +422,17 @@ protected boolean canHandle(Ne

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41778375 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -205,6 +250,75 @@ public boolean implement(Networ

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41778455 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -303,13 +422,17 @@ protected boolean canHandle(Ne

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41778327 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -205,9 +254,79 @@ public boolean implement(Networ

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41778039 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -205,9 +254,79 @@ public boolean implement(Networ

  1   2   >