Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41807704
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspElementClient.java
---
@@ -24,13 +24,18 @@
public interface NuageVspElementClient {
- public void applyStaticNats(String networkDomainUuid, String
vpcOrSubnetUuid, boolean isL3Network, List<Map<String, Object>>
staticNatDetails) throws Exception;
+ boolean implement(long networkId, String networkDomainUuid, String
networkUuid, String networkName, String vpcOrSubnetUuid, boolean isL2Network,
boolean isL3Network,
+ boolean isVpc, boolean isShared, String
domainTemplateName, boolean isFirewallServiceSupported, List<String>
dnsServers, List<Map<String, Object>> ingressFirewallRules,
+ List<Map<String, Object>>
egressFirewallRules, List<String> acsFipUuid, boolean egressDefaultPolicy)
throws Exception;
- public void applyAclRules(String networkUuid, String
networkDomainUuid, String vpcOrSubnetUuid, boolean isL3Network,
List<Map<String, Object>> aclRules, boolean isVpc, long networkId)
- throws Exception;
+ void applyStaticNats(String networkDomainUuid, String networkUuid,
String vpcOrSubnetUuid, boolean isL3Network, boolean isVpc,
+ List<Map<String, Object>>
staticNatDetails) throws Exception;
--- End diff --
This ``throws`` is too broad. Please enumerate the expected checked
exceptions to be thrown.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
