Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41778534
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -368,18 +492,15 @@ public boolean applyStaticNats(Network config, List<?
extends StaticNat> rules)
sourceNatDetails.add(sourceNatDetail);
}
try {
- try {
- HostVO nuageVspHost =
getNuageVspHost(config.getPhysicalNetworkId());
- ApplyStaticNatVspCommand cmd = new
ApplyStaticNatVspCommand(networkDomain.getUuid(), vpcOrSubnetUuid, isL3Network,
sourceNatDetails);
- ApplyStaticNatVspAnswer answer =
(ApplyStaticNatVspAnswer)_agentMgr.easySend(nuageVspHost.getId(), cmd);
- if (answer == null || !answer.getResult()) {
- s_logger.error("ApplyStaticNatNuageVspCommand for
network " + config.getUuid() + " failed");
- if ((null != answer) && (null != answer.getDetails()))
{
- throw new
ResourceUnavailableException(answer.getDetails(), Network.class,
config.getId());
- }
+ HostVO nuageVspHost =
getNuageVspHost(config.getPhysicalNetworkId());
+ ApplyStaticNatVspCommand.Builder cmdBuilder = new
ApplyStaticNatVspCommand.Builder().networkDomainUuid(networkDomain.getUuid())
+
.networkUuid(config.getUuid()).vpcOrSubnetUuid(vpcOrSubnetUuid).isL3Network(isL3Network).isVpc(vpcId
!= null).staticNatDetails(sourceNatDetails);
+ ApplyStaticNatVspAnswer answer =
(ApplyStaticNatVspAnswer)_agentMgr.easySend(nuageVspHost.getId(),
cmdBuilder.build());
+ if (answer == null || !answer.getResult()) {
+ s_logger.error("ApplyStaticNatNuageVspCommand for network
" + config.getUuid() + " failed");
+ if ((null != answer) && (null != answer.getDetails())) {
+ throw new
ResourceUnavailableException(answer.getDetails(), Network.class,
config.getId());
}
- } catch (Exception e) {
- s_logger.warn("Failed to apply static Nat in Vsp " +
e.getMessage());
}
} catch (Exception e) {
--- End diff --
Why are all checked and unchecked exceptions being caught here? Why not
catch the subset of expected checked exceptions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
