Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41806186
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -403,20 +412,36 @@ private Answer executeRequest(TrashNetworkVspCommand
cmd) {
private Answer executeRequest(ApplyStaticNatVspCommand cmd) {
try {
isNuageVspElementLoaded();
-
_nuageVspElementClient.applyStaticNats(cmd.getNetworkDomainUuid(),
cmd.getVpcOrSubnetUuid(), cmd.isL3Network(), cmd.getStaticNatDetails());
+
_nuageVspElementClient.applyStaticNats(cmd.getNetworkDomainUuid(),
cmd.getNetworkUuid(), cmd.getVpcOrSubnetUuid(), cmd.isL3Network(),
+ cmd.isVpc(), cmd.getStaticNatDetails());
return new ApplyStaticNatVspAnswer(cmd, true, "Applied Static
NAT to VSP network mapping to " + cmd.getVpcOrSubnetUuid());
} catch (Exception e) {
+ s_logger.error("Failure during " + cmd, e);
return new ApplyStaticNatVspAnswer(cmd, e);
}
}
+ private Answer executeRequest(ImplementVspCommand cmd) {
+ try {
+ isNuageVspElementLoaded();
+ boolean success =
_nuageVspElementClient.implement(cmd.getNetworkId(),
cmd.getNetworkDomainUuid(), cmd.getNetworkUuid(), cmd.getNetworkName(),
cmd.getVpcOrSubnetUuid(), cmd.isL2Network(),
+ cmd.isL3Network(), cmd.isVpc(), cmd.isShared(),
cmd.getDomainTemplateName(), cmd.isFirewallServiceSupported(),
cmd.getDnsServers(), cmd.getIngressFirewallRules(),
+ cmd.getEgressFirewallRules(), cmd.getAcsFipUuid(),
cmd.isEgressDefaultPolicy());
+ return new ImplementVspAnswer(cmd, success, "Implemented
network in VSP " + cmd.getNetworkUuid());
+ } catch (Exception e) {
--- End diff --
Why are all unchecked and checked exceptions being caught? It seems like
we should only be catching the expected checked exceptions, and allow unchecked
exceptions simply bubble out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
