[GitHub] jvrao commented on issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper

2017-06-28 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] jvrao commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-28 Thread git
gets written/scyned unless dedup is implemented. @sijie I am not sure what is the biggest concern about this. Are you worried about too many configuration parameters? or something else? This is an automated message from the Apach

[GitHub] jvrao commented on a change in pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy

2017-06-28 Thread git
only right? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.

[GitHub] jvrao commented on issue #200: Issue 209: Introduce Speculative Read/Read LAC policy

2017-06-28 Thread git
better organized as speculative reads has its own policy, but trying to understand what use-case drove you to this change at Twitter? This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] sijie commented on a change in pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy

2017-06-28 Thread git
automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] sijie commented on issue #200: Issue 209: Introduce Speculative Read/Read LAC policy

2017-06-28 Thread git
place. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure a

[GitHub] sijie commented on issue #200: Issue 209: Introduce Speculative Read/Read LAC policy

2017-06-28 Thread git
place. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure a

[GitHub] sijie commented on issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper

2017-06-28 Thread git
implement this with standard servlets. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] sijie commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-28 Thread git
he underneath problems and this flag will most likely be used anymore when we have the correct solution in place. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] jvrao commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-28 Thread git
> -- Jvrao --- First they ignore you, then they laugh at you, then they fight you, then you win. - Mahatma Gandhi This is an automated message from the Apache Git Service. To respond to the message

[GitHub] sijie commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-28 Thread git
aspects on the solutions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] sijie closed issue #216: Remove useless and misleading '&= true'

2017-06-28 Thread git
sijie closed issue #216: Remove useless and misleading '&= true' URL: https://github.com/apache/bookkeeper/issues/216 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] sijie closed pull request #215: Issue 216: Remove useless and misleading '&= true'

2017-06-28 Thread git
sijie closed pull request #215: Issue 216: Remove useless and misleading '&= true' URL: https://github.com/apache/bookkeeper/pull/215 This is an automated message from the Apache Git Service. To respond

[GitHub] sijie closed pull request #190: BOOKKEEPER-1034: Bookie start in RO when diskfull

2017-06-28 Thread git
sijie closed pull request #190: BOOKKEEPER-1034: Bookie start in RO when diskfull URL: https://github.com/apache/bookkeeper/pull/190 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] sijie commented on issue #81: BOOKKEEPER-753: Bookie should run garbage collection before startup when all directories became full

2017-06-28 Thread git
request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at

[GitHub] sijie closed pull request #193: BOOKKEEPER-1086: ZkUnderreplicationManager cache watcher

2017-06-28 Thread git
sijie closed pull request #193: BOOKKEEPER-1086: ZkUnderreplicationManager cache watcher URL: https://github.com/apache/bookkeeper/pull/193 This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie commented on issue #195: Update JMX documentation

2017-06-28 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] athanatos commented on issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher

2017-06-28 Thread git
? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git

[GitHub] athanatos commented on a change in pull request #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher

2017-06-28 Thread git
watch = guard; + readAssertChildren("/z/a", new String[]{}); +} catch (Exception e) { Review comment: No, the exception is meant to fire and the test is that the watch is canceled when it does (hence the assertNotFired below). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] sijie commented on issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher

2017-06-28 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] sijie commented on issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029

2017-06-28 Thread git
? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-06-28 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git

[GitHub] sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-06-28 Thread git
GPG_KEY" \ +#&& gpg --batch --verify "$DISTRO_NAME.tar.gz.asc" "$DISTRO_NAME.tar.gz" \ +&& tar -xzf "$DISTRO_NAME.tar.gz" \ +&& rm -r "$GNUPGHOME" "$DISTRO_NAME.tar.gz" "$DISTRO_NAME.tar.gz.asc" \

[GitHub] sijie commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-06-28 Thread git
message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] sijie commented on a change in pull request #213: Issue 212: change github PR template to adjust both issue# and jira#

2017-06-28 Thread git
request` Review comment: @eolivelli does this address your comment? do we need to call out 'BOOKKEEPER-#' explicility? This is an automated message from the Apache Git Service. To respond to the message, please log on GitH

[GitHub] sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-06-28 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] sijie commented on issue #198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException

2017-06-28 Thread git
leaking in current code base. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] reddycharan commented on issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029

2017-06-28 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With

[GitHub] sijie commented on a change in pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy

2017-06-28 Thread git
kay to you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastruct

[GitHub] jiazhai commented on issue #205: Issue 208: Improve ledger fence logic

2017-06-28 Thread git
jiazhai commented on issue #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#issuecomment-311847825 Seems there is conflict files. This is an automated message from the Apache Git

[GitHub] jiazhai commented on issue #205: Issue 208: Improve ledger fence logic

2017-06-28 Thread git
Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] eolivelli commented on issue #213: Issue 212: change github PR template to adjust both issue# and jira#

2017-06-29 Thread git
message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] eolivelli closed pull request #213: Issue 212: change github PR template to adjust both issue# and jira#

2017-06-29 Thread git
eolivelli closed pull request #213: Issue 212: change github PR template to adjust both issue# and jira# URL: https://github.com/apache/bookkeeper/pull/213 This is an automated message from the Apache Git Service. To

[GitHub] eolivelli closed issue #212: Change pull request template to adjust both issue# and jira#

2017-06-29 Thread git
eolivelli closed issue #212: Change pull request template to adjust both issue# and jira# URL: https://github.com/apache/bookkeeper/issues/212 This is an automated message from the Apache Git Service. To respond to the

[GitHub] eolivelli commented on a change in pull request #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder

2017-06-29 Thread git
License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +--- +- scm: +name: repo +scm: +- git: +

[GitHub] eolivelli commented on issue #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder

2017-06-29 Thread git
eestyle project" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With

[GitHub] sigee opened a new pull request #217: Code cleanups

2017-06-29 Thread git
findbugs:check`. - [ ] Replace `` in the title with the actual Issue/JIRA number. --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the

[GitHub] jvrao commented on a change in pull request #205: Issue 208: Improve ledger fence logic

2017-06-29 Thread git
edger directory to exclude. Review comment: Add new @param fallback here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment.

[GitHub] eolivelli commented on issue #217: Code cleanups

2017-06-29 Thread git
automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] jvrao commented on a change in pull request #205: Issue 208: Improve ledger fence logic

2017-06-29 Thread git
*NO* Checks to see the fullness of the randomly picked dir. Any consequences ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific

[GitHub] jvrao commented on a change in pull request #205: Issue 208: Improve ledger fence logic

2017-06-29 Thread git
: Comment is vague. Please reword it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] sigee commented on issue #217: Code cleanups

2017-06-29 Thread git
add maven checkstyle plugin and attache it to the validate goal if you would like. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific

[GitHub] jvrao commented on a change in pull request #205: Issue 208: Improve ledger fence logic

2017-06-29 Thread git
other logFenceResult here??? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please co

[GitHub] sigee commented on issue #217: Code cleanups

2017-06-29 Thread git
add maven checkstyle plugin and attache it to the validate goal if you would like. Or just make it runnable by ```mvn checkstyle:checkstyle``` This is an automated message from the Apache Git Service. To respond to the message

[GitHub] eolivelli commented on issue #217: Code cleanups

2017-06-29 Thread git
new thread This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] sijie commented on a change in pull request #205: Issue 208: Improve ledger fence logic

2017-06-29 Thread git
do. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us

[GitHub] sijie commented on a change in pull request #205: Issue 208: Improve ledger fence logic

2017-06-29 Thread git
ne 96.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] sijie commented on a change in pull request #205: Issue 208: Improve ledger fence logic

2017-06-29 Thread git
it is necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infras

[GitHub] reddycharan commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-29 Thread git
it is and just going to change the config variable name as we discussed earlier (from 'partition' to 'diskPartition') and resend the commit. This is an automated message from the Apache Git Service. To respond t

[GitHub] reddycharan commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-29 Thread git
t out. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure a

[GitHub] jvrao commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-29 Thread git
have only one journal dir right? @reddycharan what do you mean by " Will add check for journaldirectories " ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and u

[GitHub] reddycharan commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-29 Thread git
/123eccd435a4a96a9147ed4a24efbe9025fe79ba This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] sijie commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-29 Thread git
concerned. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastruct

[GitHub] sijie commented on issue #217: Code cleanups

2017-06-29 Thread git
build-tools/src/main/resources/distributedlog/checkstyle.xml This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries

[GitHub] sijie commented on issue #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder

2017-06-29 Thread git
? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org

[GitHub] sijie commented on a change in pull request #205: Issue 208: Improve ledger fence logic

2017-06-29 Thread git
. I have improved the comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] sijie commented on a change in pull request #205: Issue 208: Improve ledger fence logic

2017-06-29 Thread git
edger directory to exclude. Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] sijie commented on issue #205: Issue 208: Improve ledger fence logic

2017-06-29 Thread git
uests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure a

[GitHub] kishorekasi commented on issue #214: Fix ByteBuf refcount release

2017-06-29 Thread git
releasing ByteBuf. I don't see that in master code. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries

[GitHub] sijie opened a new issue #218: NPE at TestLongZkLedgerIdGenerator.testGenerateLedgerId

2017-06-29 Thread git
(LongZkLedgerIdGenerator.java:320) ` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] sijie commented on issue #198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException

2017-06-29 Thread git
close the connection, error out the pending requests and cleaning up the resources. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specif

[GitHub] sijie commented on a change in pull request #214: Fix ByteBuf refcount release

2017-06-29 Thread git
component, we can only release the buffer when the add operation is completed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific

[GitHub] eolivelli commented on issue #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder

2017-06-29 Thread git
, the trunk, of jenkins job builder, the latest released version is somehow buggy and does handle the email reporting plugin well This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] eolivelli commented on issue #198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException

2017-06-29 Thread git
that @merlimat suggestion is good. Can you give it a try? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries

[GitHub] sijie opened a new pull request #219: Issue 198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException

2017-06-29 Thread git
: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git

[GitHub] sijie closed issue #207: Change the HashSet to BitSet to handle duplicated bookies on reading entries

2017-06-29 Thread git
sijie closed issue #207: Change the HashSet to BitSet to handle duplicated bookies on reading entries URL: https://github.com/apache/bookkeeper/issues/207 This is an automated message from the Apache Git Service. To

[GitHub] sijie closed pull request #199: Issue 207: change the HashSet to BitSet to handle duplicated bookies on reading entries

2017-06-29 Thread git
sijie closed pull request #199: Issue 207: change the HashSet to BitSet to handle duplicated bookies on reading entries URL: https://github.com/apache/bookkeeper/pull/199 This is an automated message from the Apache Git

[GitHub] sijie closed pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy

2017-06-29 Thread git
sijie closed pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy URL: https://github.com/apache/bookkeeper/pull/200 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] sijie closed issue #209: Introduce a Speculative Read/Read LAC policy

2017-06-29 Thread git
sijie closed issue #209: Introduce a Speculative Read/Read LAC policy URL: https://github.com/apache/bookkeeper/issues/209 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] sijie closed pull request #202: BOOKKEEPER-759: Delay Ensemble Change & Disable Ensemble Change

2017-06-29 Thread git
sijie closed pull request #202: BOOKKEEPER-759: Delay Ensemble Change & Disable Ensemble Change URL: https://github.com/apache/bookkeeper/pull/202 This is an automated message from the Apache Git Service. To respond to

[GitHub] sijie opened a new pull request #220: BOOKKEEPER-1095: Server and Client Side Changes

2017-06-29 Thread git
also have a speculative mechanism for long poll reads. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] jiazhai closed pull request #219: Issue 198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException

2017-06-29 Thread git
from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] jiazhai closed issue #198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException

2017-06-29 Thread git
Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] sijie opened a new issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing

2017-06-29 Thread git
automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] sijie commented on a change in pull request #190: BOOKKEEPER-1034: Bookie start in RO when diskfull

2017-06-29 Thread git
case #221 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] reddycharan commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing

2017-06-30 Thread git
'1' for this failure. @eolivelli ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] reddycharan commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing

2017-06-30 Thread git
'1' for this failure. @eolivelli ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at:

[GitHub] sijie commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing

2017-06-30 Thread git
otent. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure a

[GitHub] eolivelli commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

2017-06-30 Thread git
observer) throws IOException; Review comment: same typo previoisLAC This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment

[GitHub] eolivelli commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

2017-06-30 Thread git
, long previoisLAC, Observer observer) throws IOException { Review comment: minor typo: previoisLAC This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to

[GitHub] eolivelli commented on issue #214: Fix ByteBuf refcount release

2017-06-30 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] eolivelli closed pull request #214: Fix ByteBuf refcount release

2017-06-30 Thread git
eolivelli closed pull request #214: Fix ByteBuf refcount release URL: https://github.com/apache/bookkeeper/pull/214 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] sijie opened a new pull request #222: Issue 221: Make netty server shutdown idempotent

2017-06-30 Thread git
) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] sijie commented on issue #222: Issue 221: Make netty server shutdown idempotent

2017-06-30 Thread git
sijie commented on issue #222: Issue 221: Make netty server shutdown idempotent URL: https://github.com/apache/bookkeeper/pull/222#issuecomment-312200766 /cc @reddycharan This is an automated message from the Apache Git

[GitHub] sijie commented on issue #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

2017-06-30 Thread git
s with the switch between normal reads and long poll reads when detecting lac is advancing. once this change is in, distributedlog should be compatible with current community master. This is an automated message from the Apache G

[GitHub] eolivelli commented on a change in pull request #222: Issue 221: Make netty server shutdown idempotent

2017-06-30 Thread git
e will not print twice "Shutting down" and doing to isRunning.set This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the spe

[GitHub] eolivelli commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation

2017-06-30 Thread git
this topic This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastruct

[GitHub] reddycharan commented on a change in pull request #222: Issue 221: Make netty server shutdown idempotent

2017-06-30 Thread git
the change This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.

[GitHub] eolivelli commented on issue #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

2017-06-30 Thread git
having it merged in BK ! Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] jiazhai commented on issue #217: Code cleanups

2017-06-30 Thread git
x" in the "[ ]". This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] jiazhai commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-06-30 Thread git
-alpine +MAINTAINER Francesco Caliumi + +# Install required packages +RUN apk add --no-cache \ +bash \ +su-exec + +ENV ZK_SERVERS= \ Review comment: +1. It is a great py. This is an automated message from the Apache Git

[GitHub] eolivelli commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing

2017-06-30 Thread git
methods should be idempotent too but if it is possible it is better to make the call to "close" once. It is cleaner and for the long term it is the best approch This is an automated message from the Apache Git Service. To

[GitHub] sigee opened a new issue #223: Clean up code rots

2017-06-30 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With

[GitHub] sigee commented on issue #217: Issue 223: Code cleanups

2017-06-30 Thread git
started working on the CheckStyle, but there are lots of errors, I started to fix, so it is in progress. I'll create an issue and a different PR for that at the weekend. This is an automated message from the Apache Git Servic

[GitHub] sijie commented on a change in pull request #222: Issue 221: Make netty server shutdown idempotent

2017-06-30 Thread git
be called twice, I would like to have logging to tell, so if we want to debug, we know what happened. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to

[GitHub] sijie commented on a change in pull request #222: Issue 221: Make netty server shutdown idempotent

2017-06-30 Thread git
d twice, I would like it to be set eventually. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this servi

[GitHub] eolivelli commented on issue #222: Issue 221: Make netty server shutdown idempotent

2017-06-30 Thread git
eolivelli commented on issue #222: Issue 221: Make netty server shutdown idempotent URL: https://github.com/apache/bookkeeper/pull/222#issuecomment-312301512 Ok for me This is an automated message from the Apache Git

[GitHub] sijie commented on issue #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

2017-06-30 Thread git
nt to provide the reopenable log. And thats one of the reasons that we think we want to merge the library back to provide an easier library for access. This is an automated message from the Apache Git Service. To respond to the me

[GitHub] sijie commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation

2017-06-30 Thread git
using on merging big feature changes to make sure 4.5 move forward. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment.

[GitHub] eolivelli commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation

2017-06-30 Thread git
just collected all the pieces and I am waiting to have the native BK library. I can wait This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the

  1   2   3   4   5   6   7   8   9   10   >