reddycharan commented on a change in pull request #222: Issue 221: Make netty server shutdown idempotent URL: https://github.com/apache/bookkeeper/pull/222#discussion_r124985739
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java ########## @@ -279,6 +280,12 @@ void start() { void shutdown() { LOG.info("Shutting down BookieNettyServer"); isRunning.set(false); + + if (!isClosed.compareAndSet(false, true)) { Review comment: +1 with the comment +1 with the change ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services