eolivelli commented on a change in pull request #222: Issue 221: Make netty
server shutdown idempotent
URL: https://github.com/apache/bookkeeper/pull/222#discussion_r124984858
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java
##########
@@ -279,6 +280,12 @@ void start() {
void shutdown() {
LOG.info("Shutting down BookieNettyServer");
isRunning.set(false);
+
+ if (!isClosed.compareAndSet(false, true)) {
Review comment:
IMHO maybe you can move this at the start of the method, so we will not
print twice "Shutting down" and doing to isRunning.set
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
