jvrao commented on a change in pull request #205: Issue 208: Improve ledger
fence logic
URL: https://github.com/apache/bookkeeper/pull/205#discussion_r124806429
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexPersistenceMgr.java
##########
@@ -177,7 +177,35 @@ private FileInfo putFileInfo(Long ledger, byte
masterKey[], File lf, boolean cre
*/
private File getNewLedgerIndexFile(Long ledger, File excludedDir)
throws NoWritableLedgerDirException {
- File dir = ledgerDirsManager.pickRandomWritableDir(excludedDir);
+ return getNewLedgerIndexFile(ledger, excludedDir, false);
Review comment:
Can you explain situations where fallback is not allowed and where it is OK.
Index files are small, but still it can push dirs to 100% and eventually
write can fail.
Looks like this change has *NO* Checks to see the fullness of the randomly
picked dir. Any consequences ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
