Re: Proposal: API changes to getTasksStatus

2014-05-30 Thread Suman Karumuri
The client would indeed be affected by that (config diffing when performing > job updates). However, there's nothing stopping us from defining a new RPC > and message to define exactly the fields we want to send for the UI. > > -=Bill > > > On Fri, May 30, 2014 at 11:22 AM, Su

Re: Proposal: API changes to getTasksStatus

2014-05-30 Thread Suman Karumuri
Looks like my earlier mail has bounced. Sending it again. Can you please add some explanation to AURORA-471 explaining where the time is being spent with some data and some micro benchmarks. As is it is unclear why thrift.flush should be taking so long. Is the default implementation of TServlet.do

Re: [DISCUSS] Javascript dependencies location and bower

2014-03-27 Thread Suman Karumuri
enses for the > remaining js dependency in src/ to the LICENSE file so its not an issue, > once we refactor the ui and remove them from the source or switch to #2 we > can clean up the LICENSE file. > > -Jake > > > On Thu, Mar 27, 2014 at 6:34 PM, Suman Karumuri wrote: >

Re: [DISCUSS] Javascript dependencies location and bower

2014-03-27 Thread Suman Karumuri
What are the 3 locations you speak of? With the UI refactor work, most of the dependencies in src/ for scheduler will be removed. If you can file me a ticket with the issues you are facing, I can make sure that #1 happens. We should definitely revisit #2 once #1 is done. On Thu, Mar 27, 2014 at 1

Re: Build failed in Jenkins: Aurora #165

2014-03-11 Thread Suman Karumuri
./build-support/jenkins/build.sh succeeds on my laptop. Is this an environment issue with the jenkins server? On Mon, Mar 10, 2014 at 11:31 PM, Apache Jenkins Server wrote: > See > > Changes: > > [skarumuri] Added getJobSummary API so it can be u

Re: Build failed in Jenkins: Aurora #150

2014-03-01 Thread Suman Karumuri
Fixed. On Fri, Feb 28, 2014 at 6:45 PM, Apache Jenkins Server wrote: > See > > Changes: > > [skarumuri] Added non-prod consumption info to getQuota call. > > -- > [...truncated 3583 lines...] > collecting .

[jira] [Commented] (AURORA-65) Add a thrift API to get quota information for a role

2014-01-24 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881566#comment-13881566 ] Suman Karumuri commented on AURORA-65: -- https://reviews.apache.org/r/17347/ >

[jira] [Commented] (AURORA-87) Display job diff in the scheduler when an update is in progress

2014-01-24 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881256#comment-13881256 ] Suman Karumuri commented on AURORA-87: -- [~wfarner] Is this a UI task? > Disp

[jira] [Commented] (AURORA-64) Add a thrift API to get job summary for a role

2014-01-23 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880782#comment-13880782 ] Suman Karumuri commented on AURORA-64: -- https://reviews.apache.org/r/17303/ >

[jira] [Created] (AURORA-70) Replace SchedulerzJob page with the Angular UI job page.

2014-01-21 Thread Suman Karumuri (JIRA)
Suman Karumuri created AURORA-70: Summary: Replace SchedulerzJob page with the Angular UI job page. Key: AURORA-70 URL: https://issues.apache.org/jira/browse/AURORA-70 Project: Aurora Issue

[jira] [Commented] (AURORA-39) Create a page that lists jobs for a role

2014-01-21 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877587#comment-13877587 ] Suman Karumuri commented on AURORA-39: -- I have implemented the UI with a mock

[jira] [Updated] (AURORA-24) Build a standalone UI

2014-01-21 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suman Karumuri updated AURORA-24: - Assignee: (was: Suman Karumuri) > Build a standalone

[jira] [Updated] (AURORA-17) Use promises for calling thrift end points

2014-01-21 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suman Karumuri updated AURORA-17: - Assignee: (was: Suman Karumuri) > Use promises for calling thrift end poi

[jira] [Commented] (AURORA-24) Build a standalone UI

2014-01-21 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877577#comment-13877577 ] Suman Karumuri commented on AURORA-24: -- I have implemented a stand alone versio

[jira] [Updated] (AURORA-68) Add an thrift API to get quota consumption info for a given role and environment

2014-01-21 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suman Karumuri updated AURORA-68: - Assignee: (was: Suman Karumuri) > Add an thrift API to get quota consumption info for a gi

[jira] [Created] (AURORA-68) Add an thrift API to get quota consumption info for a given role and environment

2014-01-21 Thread Suman Karumuri (JIRA)
Suman Karumuri created AURORA-68: Summary: Add an thrift API to get quota consumption info for a given role and environment Key: AURORA-68 URL: https://issues.apache.org/jira/browse/AURORA-68 Project

[jira] [Created] (AURORA-69) Implement a page to list jobs for a role/environment

2014-01-21 Thread Suman Karumuri (JIRA)
Suman Karumuri created AURORA-69: Summary: Implement a page to list jobs for a role/environment Key: AURORA-69 URL: https://issues.apache.org/jira/browse/AURORA-69 Project: Aurora Issue Type

[jira] [Created] (AURORA-67) Add a thrift API to get job summary for a role and environment

2014-01-21 Thread Suman Karumuri (JIRA)
Suman Karumuri created AURORA-67: Summary: Add a thrift API to get job summary for a role and environment Key: AURORA-67 URL: https://issues.apache.org/jira/browse/AURORA-67 Project: Aurora

[jira] [Created] (AURORA-66) Replace SchedulerRole servlet with UI client pages.

2014-01-21 Thread Suman Karumuri (JIRA)
Suman Karumuri created AURORA-66: Summary: Replace SchedulerRole servlet with UI client pages. Key: AURORA-66 URL: https://issues.apache.org/jira/browse/AURORA-66 Project: Aurora Issue Type

[jira] [Created] (AURORA-65) Add a thrift API to get quota information for a role

2014-01-21 Thread Suman Karumuri (JIRA)
Suman Karumuri created AURORA-65: Summary: Add a thrift API to get quota information for a role Key: AURORA-65 URL: https://issues.apache.org/jira/browse/AURORA-65 Project: Aurora Issue Type

[jira] [Created] (AURORA-64) Add a thrift API to get job summary for a role

2014-01-21 Thread Suman Karumuri (JIRA)
Suman Karumuri created AURORA-64: Summary: Add a thrift API to get job summary for a role Key: AURORA-64 URL: https://issues.apache.org/jira/browse/AURORA-64 Project: Aurora Issue Type: Task

[jira] [Closed] (AURORA-33) Show Job Summary by role on home page

2014-01-16 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suman Karumuri closed AURORA-33. > Show Job Summary by role on home page > - > >

[jira] [Closed] (AURORA-32) Replace old scheduler home page with the new page

2014-01-16 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suman Karumuri closed AURORA-32. > Replace old scheduler home page with the new p

[jira] [Updated] (AURORA-39) Create a page that lists jobs for a role

2014-01-15 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suman Karumuri updated AURORA-39: - Summary: Create a page that lists jobs for a role (was: List jobs per role) > Create a page t

[jira] [Created] (AURORA-39) List jobs per role

2014-01-15 Thread Suman Karumuri (JIRA)
Suman Karumuri created AURORA-39: Summary: List jobs per role Key: AURORA-39 URL: https://issues.apache.org/jira/browse/AURORA-39 Project: Aurora Issue Type: Task Components: UI

[jira] [Commented] (AURORA-17) Use promises for calling thrift end points

2014-01-15 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872405#comment-13872405 ] Suman Karumuri commented on AURORA-17: -- Considered using angular-thrift library

[jira] [Updated] (AURORA-17) Use promises for calling thrift end points

2014-01-15 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suman Karumuri updated AURORA-17: - Description: Wrap the thrift calls in $q and $http service for better error handling and UX

[jira] [Updated] (AURORA-17) Use promises for calling thrift end points

2014-01-15 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suman Karumuri updated AURORA-17: - Summary: Use promises for calling thrift end points (was: Migrate to angular-thrift) >

[jira] [Assigned] (AURORA-24) Build a standalone UI

2014-01-14 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suman Karumuri reassigned AURORA-24: Assignee: Suman Karumuri > Build a standalone

[jira] [Commented] (AURORA-18) Show an error message when the thrift call to scheduler fails

2014-01-14 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871749#comment-13871749 ] Suman Karumuri commented on AURORA-18: -- Implemented this feature today. Will send

[jira] [Commented] (AURORA-32) Replace old scheduler home page with the new page

2014-01-13 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870147#comment-13870147 ] Suman Karumuri commented on AURORA-32: -- https://reviews.apache.org/r/1

[jira] [Commented] (AURORA-33) Show Job Summary by role on home page

2014-01-13 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869852#comment-13869852 ] Suman Karumuri commented on AURORA-33: -- https://reviews.apache.org/r/16528/ &g

[jira] [Updated] (AURORA-16) Refactor Aurora UI

2014-01-13 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suman Karumuri updated AURORA-16: - Labels: refactor_aurora_ui (was: ) > Refactor Aurora

[jira] [Created] (AURORA-32) Replace old scheduler home page with the new page

2014-01-13 Thread Suman Karumuri (JIRA)
Suman Karumuri created AURORA-32: Summary: Replace old scheduler home page with the new page Key: AURORA-32 URL: https://issues.apache.org/jira/browse/AURORA-32 Project: Aurora Issue Type

[jira] [Updated] (AURORA-16) Refactor Aurora UI

2014-01-13 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suman Karumuri updated AURORA-16: - Issue Type: Epic (was: Story) > Refactor Aurora UI > -- > >

[jira] [Created] (AURORA-33) Show Job Summary by role on home page

2014-01-13 Thread Suman Karumuri (JIRA)
Suman Karumuri created AURORA-33: Summary: Show Job Summary by role on home page Key: AURORA-33 URL: https://issues.apache.org/jira/browse/AURORA-33 Project: Aurora Issue Type: Task

[jira] [Created] (AURORA-24) Build a standalone UI

2014-01-08 Thread Suman Karumuri (JIRA)
Suman Karumuri created AURORA-24: Summary: Build a standalone UI Key: AURORA-24 URL: https://issues.apache.org/jira/browse/AURORA-24 Project: Aurora Issue Type: Task Components: UI

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client

2014-01-07 Thread Suman Karumuri
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16528/#review31268 --- On Jan. 7, 2014, 8:10 a.m., Suman Karumuri wrote: > > --

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client

2014-01-07 Thread Suman Karumuri
dia/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png Thanks, Suman Karumuri

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client

2014-01-06 Thread Suman Karumuri
> On Jan. 2, 2014, 10:57 p.m., Bill Farner wrote: > > src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html, line 23 > > <https://reviews.apache.org/r/16528/diff/1/?file=407232#file407232line23> > > > > remove? seems superfluous > > Suma

Re: Review Request 16575: Replace StorageStarted event with TaskStateChange events.

2014-01-03 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16575/#review31200 --- Ship it! - Suman Karumuri On Jan. 3, 2014, 6:57 p.m., Bill

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client

2014-01-03 Thread Suman Karumuri
Home page https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png Thanks, Suman Karumuri

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client

2014-01-03 Thread Suman Karumuri
t; > the invocation above done. - Suman --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16528/#review31080 --- On Jan. 2, 2014, 10:48 p.m

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client

2014-01-02 Thread Suman Karumuri
-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png Thanks, Suman Karumuri

Re: Review Request 16576: Global import optimize.

2014-01-02 Thread Suman Karumuri
> On Jan. 2, 2014, 10:19 p.m., Suman Karumuri wrote: > > Ship It! Nice! - Suman --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16576/#re

Re: Review Request 16576: Global import optimize.

2014-01-02 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16576/#review31072 --- Ship it! Ship It! - Suman Karumuri On Jan. 2, 2014, 10:04 p.m

[jira] [Updated] (AURORA-16) Refactor Aurora UI

2014-01-02 Thread Suman Karumuri (JIRA)
[ https://issues.apache.org/jira/browse/AURORA-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suman Karumuri updated AURORA-16: - Description: Mostly copy-paste for posterity below: Right now the UI is implemented directly

[jira] [Created] (AURORA-18) Show an error message when the thrift call to scheduler fails

2014-01-02 Thread Suman Karumuri (JIRA)
Suman Karumuri created AURORA-18: Summary: Show an error message when the thrift call to scheduler fails Key: AURORA-18 URL: https://issues.apache.org/jira/browse/AURORA-18 Project: Aurora

[jira] [Created] (AURORA-17) Migrate to angular-thrift

2014-01-02 Thread Suman Karumuri (JIRA)
Suman Karumuri created AURORA-17: Summary: Migrate to angular-thrift Key: AURORA-17 URL: https://issues.apache.org/jira/browse/AURORA-17 Project: Aurora Issue Type: Task Components

[jira] [Created] (AURORA-16) Refactor Aurora UI

2014-01-02 Thread Suman Karumuri (JIRA)
Suman Karumuri created AURORA-16: Summary: Refactor Aurora UI Key: AURORA-16 URL: https://issues.apache.org/jira/browse/AURORA-16 Project: Aurora Issue Type: New Feature Components

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client

2013-12-31 Thread Suman Karumuri
) Home page https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png Thanks, Suman Karumuri

Review Request 16528: Scheduler home page new using AngularJS and UI client

2013-12-31 Thread Suman Karumuri
/roleLink.html PRE-CREATION Diff: https://reviews.apache.org/r/16528/diff/ Testing --- gradle clean build Tested the UI using the isolated scheduler. Thanks, Suman Karumuri

Re: Review Request 16192: Installing JQuery and bootstrap from bower

2013-12-26 Thread Suman Karumuri
view30884 --- On Dec. 19, 2013, 7:30 a.m., Suman Karumuri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 16267: Adding a script to run an isolated scheduler.

2013-12-26 Thread Suman Karumuri
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16267/#review30885 --- On Dec. 23, 2013, 11:19 p.m., Suman Karumuri wrote: > > --- >

Re: Review Request 16267: Adding a script to run an isolated scheduler.

2013-12-26 Thread Suman Karumuri
ore needs code changes. - Suman --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16267/#review30844 --- On Dec. 23, 2013,

Re: Review Request 16231: Added getJobSummary call to thrift API

2013-12-26 Thread Suman Karumuri
view30886 --- On Dec. 24, 2013, 1:39 a.m., Suman Karumuri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 16231: Added getJobSummary call to thrift API

2013-12-23 Thread Suman Karumuri
/test/java/com/twitter/aurora/scheduler/thrift/aop/ForwardingThrift.java 7c5100bd043273ca85e3ed9b54f9cd4f4725d83c Diff: https://reviews.apache.org/r/16231/diff/ Testing --- gradle clean build Thanks, Suman Karumuri

Re: Review Request 16231: Added getJobSummary call to thrift API

2013-12-23 Thread Suman Karumuri
/SchedulerThriftInterface.java <https://reviews.apache.org/r/16231/#comment59049> Done. src/main/java/com/twitter/aurora/scheduler/thrift/SchedulerThriftInterface.java <https://reviews.apache.org/r/16231/#comment59050> Changed. - Suman Karumuri On Dec. 13, 2013, 12:46 a.m., Suman Ka

Re: Review Request 16267: Adding a script to run an isolated scheduler.

2013-12-23 Thread Suman Karumuri
. Diffs (updated) - build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f Diff: https://reviews.apache.org/r/16267/diff/ Testing (updated) --- gradle clean run Thanks, Suman Karumuri

Re: Review Request 16192: Installing JQuery and bootstrap from bower

2013-12-18 Thread Suman Karumuri
://reviews.apache.org/r/16192/diff/ Testing --- Tested the UI using the isolated scheduler. gradle clean build. Thanks, Suman Karumuri

Re: Review Request 16344: Wholesale dependency updates.

2013-12-18 Thread Suman Karumuri
along with the twitter commons parts in vagrant first? - Suman Karumuri On Dec. 18, 2013, 6:06 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 16192: Installing JQuery and bootstrap from bower

2013-12-17 Thread Suman Karumuri
using the isolated scheduler. gradle clean build. Thanks, Suman Karumuri

Re: Review Request 16192: Installing JQuery and bootstrap from bower

2013-12-16 Thread Suman Karumuri
t: https://reviews.apache.org/r/16192/#review30396 --- On Dec. 14, 2013, 1:12 a.m., Suman Karumuri wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 16192: Installing JQuery and bootstrap from bower

2013-12-16 Thread Suman Karumuri
docs/developing-aurora-scheduler.md <https://reviews.apache.org/r/16192/#comment58319> done src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java <https://reviews.apache.org/r/16192/#comment58334> removed. - Suman Karumu

Re: Review Request 16195: Added a home page with a header for the new UI

2013-12-16 Thread Suman Karumuri
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16195/#review30474 --- On Dec. 16, 2013, 6:37 p.m., Suman Karumuri wrote: > > ---

Re: Review Request 16195: Added a home page with a header for the new UI

2013-12-16 Thread Suman Karumuri
2922f35df683ef3673c5fd83e391d7aba95415a7 src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION Diff: https://reviews.apache.org/r/16195/diff/ Testing --- Tested using local isolated scheduler. gradle clean build. Thanks, Suman Karumuri

Re: Review Request 16195: Added a home page with a header for the new UI

2013-12-16 Thread Suman Karumuri
ws.apache.org/r/16195/#comment58270> Removed. - Suman Karumuri On Dec. 14, 2013, 2:57 a.m., Suman Karumuri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 16195: Added a home page with a header for the new UI

2013-12-16 Thread Suman Karumuri
<https://reviews.apache.org/r/16195/#comment58204> This is a landing page with just the navbar. Updated the title and the description to remove any confusion. - Suman Karumuri On Dec. 14, 2013, 2:57 a.m., Suman Karumuri

Re: Review Request 16261: Now treating empty log file as new log file in test.

2013-12-16 Thread Suman Karumuri
view30423 --- On Dec. 16, 2013, 6:16 p.m., Suman Karumuri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 16261: Now treating empty log file as new log file in test.

2013-12-16 Thread Suman Karumuri
exited loop! UnresettableLogManager is ignoring a reset() request. I1213 22:58:27.002 THREAD14 com.twitter.common.application.ShutdownRegistry$ShutdownRegistryImpl.execute: Action controller has already completed, subsequent calls ignored. After the fix: No exception. Thanks, Suman Karumuri

Re: Review Request 16261: Now treating empty log file as new log file in test.

2013-12-16 Thread Suman Karumuri
ra/scheduler/log/testing/FileLogTest.java <https://reviews.apache.org/r/16261/#comment58263> Removed. Was making sure the files were indeed removed. - Suman Karumuri On Dec. 14, 2013, 3:44 a.m., Suman Karumuri wrote: > > --- > Th

Re: Review Request 16267: Adding a script to run an isolated scheduler.

2013-12-14 Thread Suman Karumuri
> On Dec. 14, 2013, 1:30 a.m., Bill Farner wrote: > > I would much rather see further investment in local runs through vagrant. > > Have you considered focusing there instead? > > Suman Karumuri wrote: > Yes, I have considered it and found vagrant to be too sl

Re: Review Request 16261: Now treating empty log file as new log file in test.

2013-12-13 Thread Suman Karumuri
t; Bill Farner wrote: > Also, while you're in here — mind validating this change with a unit > test? (Using a temporary file under a FileUtils.createTempDir().) > > Suman Karumuri wrote: > file length is not a reliable indicator for unicode files because of BOM

Re: Review Request 16261: Now treating empty log file as new log file in test.

2013-12-13 Thread Suman Karumuri
. Thanks, Suman Karumuri

Re: Review Request 16195: Added a home page with a header for the new UI

2013-12-13 Thread Suman Karumuri
/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7 src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION Diff: https://reviews.apache.org/r/16195/diff/ Testing --- Tested using local isolated scheduler. gradle clean build. Thanks, Suman

Re: Review Request 16261: Now treating empty log file as new log file in test.

2013-12-13 Thread Suman Karumuri
o reply, visit: https://reviews.apache.org/r/16261/#review30399 ------- On Dec. 13, 2013, 11:04 p.m., Suman Karumuri wrote: > > --- > This is an automatically generated e-

Re: Review Request 16163: Added extra_modules option to Scheduler.

2013-12-13 Thread Suman Karumuri
view30401 --- On Dec. 13, 2013, 10:23 p.m., Suman Karumuri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 16267: Adding a script to run an isolated scheduler.

2013-12-13 Thread Suman Karumuri
67/#review30394 --- On Dec. 14, 2013, 1:08 a.m., Suman Karumuri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 16192: Installing JQuery and bootstrap from bower

2013-12-13 Thread Suman Karumuri
--- Tested the UI using the isolated scheduler. gradle clean build. Thanks, Suman Karumuri

Review Request 16267: Adding a script to run an isolated scheduler.

2013-12-13 Thread Suman Karumuri
cheduler-isolated.sh works. Thanks, Suman Karumuri

Review Request 16261: Now treating empty log file as new log file in test.

2013-12-13 Thread Suman Karumuri
: Action controller has already completed, subsequent calls ignored. After the fix: No exception. Thanks, Suman Karumuri

Re: Review Request 16163: Added extra_modules option to Scheduler.

2013-12-13 Thread Suman Karumuri
) - src/main/java/com/twitter/aurora/scheduler/app/Modules.java PRE-CREATION src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java ec99e01dd4f982ed5b794ff86b65e6f58d2a0e27 Diff: https://reviews.apache.org/r/16163/diff/ Testing --- gradle clean build. Thanks, Suman Karumuri

Re: Review Request 16163: Added extra_modules option to Scheduler.

2013-12-13 Thread Suman Karumuri
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16163/#review30169 --- On Dec. 10, 2013, 8:48 p.m., Suman Karumuri wrote: > >

Review Request 16231: Added getJobSummary call to thrift API

2013-12-12 Thread Suman Karumuri
.java 7c5100bd043273ca85e3ed9b54f9cd4f4725d83c Diff: https://reviews.apache.org/r/16231/diff/ Testing --- gradle clean build Thanks, Suman Karumuri

Re: Review Request 16195: Added a header for the new UI

2013-12-12 Thread Suman Karumuri
/scheduler/http/ui/home.html PRE-CREATION Diff: https://reviews.apache.org/r/16195/diff/ Testing --- Tested using local isolated scheduler. gradle clean build. Thanks, Suman Karumuri

Re: Review Request 16195: Added a header for the new UI

2013-12-12 Thread Suman Karumuri
it: https://reviews.apache.org/r/16195/#review30265 --- On Dec. 13, 2013, 12:22 a.m., Suman Karumuri wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request 16195: Added a header for the new UI

2013-12-11 Thread Suman Karumuri
/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION Diff: https://reviews.apache.org/r/16195/diff/ Testing --- Tested using local isolated scheduler. gradle clean build. Thanks, Suman Karumuri

Re: Review Request 16192: Installing JQuery and bootstrap from bower

2013-12-11 Thread Suman Karumuri
/bower_components/jquery/jquery.js PRE-CREATION Diff: https://reviews.apache.org/r/16192/diff/ Testing --- Tested the UI using the isolated scheduler. gradle clean build. Thanks, Suman Karumuri

Re: Review Request 16192: Installing JQuery and bootstrap from bower

2013-12-11 Thread Suman Karumuri
--- Tested the UI using the isolated scheduler. gradle clean build. Thanks, Suman Karumuri

Review Request 16192: Installing JQuery and bootstrap from bower

2013-12-11 Thread Suman Karumuri
isolated scheduler. gradle clean build. Thanks, Suman Karumuri

Re: Review Request 16098: Remove ability to install a custom quota module.

2013-12-10 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16098/#review30124 --- Ship it! Ship It! - Suman Karumuri On Dec. 6, 2013, 11:26 p.m

Review Request 16163: Added extra_modules option to Scheduler.

2013-12-10 Thread Suman Karumuri
/aurora/scheduler/app/SchedulerMain.java 73b86a9f99cb1931ccce1db0baf7c6f56ba0b65d Diff: https://reviews.apache.org/r/16163/diff/ Testing --- gradle clean build. Thanks, Suman Karumuri

Re: Review Request 16054: Rewrite SchedulerLifecycle, employing a state machine.

2013-12-10 Thread Suman Karumuri
com/twitter/aurora/scheduler/SchedulerLifecycle.java <https://reviews.apache.org/r/16054/#comment57712> Since this is a critical piece of config, would it make sense to ensure that this number is greater than 0 and not in seconds? - Suman Karumuri On Dec. 9,

Re: Review Request 16054: Rewrite SchedulerLifecycle, employing a state machine.

2013-12-10 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16054/#review30150 --- Ship it! Ship It! - Suman Karumuri On Dec. 9, 2013, 8:11 p.m