> On Jan. 2, 2014, 10:19 p.m., Suman Karumuri wrote: > > Ship It!
Nice! - Suman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16576/#review31072 ----------------------------------------------------------- On Jan. 2, 2014, 10:04 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16576/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2014, 10:04 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > ------- > > This is the result of running 'Optimize imports' on the entire project. > Unfortunately it appears that while checkstyle _requires_ an empty line > between import groups, it doesn't care if there extraneous empty lines. I > double-checked our checkstyle config against docs, and don't see anything we > can tune here. > > > Diffs > ----- > > src/main/java/org/apache/aurora/GuiceUtils.java > f3f4a12ee999fac4b0d3def2eead25915f8b3cd1 > src/main/java/org/apache/aurora/scheduler/Driver.java > 8ba013ba619df7af45b529233d2630b303821523 > src/main/java/org/apache/aurora/scheduler/DriverFactory.java > ac2a091f1b69053c1f88150788278222afc4fd88 > src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java > 4323fa4672589ae6493692dea5beefb3b5484487 > src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java > 6a9e2d327002844c0c66bd6c691c2dcea22f9521 > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java > c8b1b5f53fba7c03aedc34c8af0a6d97e93f56a2 > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java > 1ba81d49e7e8886ee57a360ede829a2ef286cd59 > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java > 0fa86c6a8b80e5990396ed067aeacbd6f53171f4 > src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java > f7bc63ef35d632be47dcf561aa4b46fe75d659c4 > src/main/java/org/apache/aurora/scheduler/TaskVars.java > 6c35bfb762f2eb09ff1c962abb645fc8ce91c3f9 > src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java > 8c7764c944dbea4bd80b1d3140f5e3f08f352981 > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > c0eb72ee98d61199c9dde5d28dcc359169d6663d > src/main/java/org/apache/aurora/scheduler/app/Log4jConfigurator.java > b701e1b893662112caffc523253e54ff0ece566c > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 9ff0be85ff6c78595e347978390609c7bd77fbfe > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java > 217a4f7bc2f05f89c265536dc6a78d796734959b > src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java > 6c35ab668fbdfa8a9d02639c811c3203d40033e9 > src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java > 302a2fec05f9124d131aa78b024858b7f65c4ab9 > src/main/java/org/apache/aurora/scheduler/async/Preemptor.java > 774147cc3e1a0ece9f28edeaedba16f5c3cc6f8b > src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java > 92fdf35fff1a7993dd8aac4b3fc69f738d1f726a > src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java > 8747c5318371ebade9f7eb09c1c530d2837fa432 > src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java > bea1bfe32300ef54774fcd6a5b82c757425533a9 > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java > 7a09d1e34ee309308ff714bb56c6891b012165bd > src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java > c2a7704f01f1b72d70f63559528aac193f1fd897 > src/main/java/org/apache/aurora/scheduler/base/Conversions.java > c65be1f7978f4a79e24e1b93a3a375298bb6549a > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > e113306039277a370b7f1ed5fe6f6b190bc3db7b > src/main/java/org/apache/aurora/scheduler/configuration/Resources.java > 77f6cce482e436b3b5a55bfd287546d2fb6c3b45 > src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java > 0e9a49bc527fd28dc43164a702c1b8e1b6ede987 > > src/main/java/org/apache/aurora/scheduler/events/NotifyingMethodInterceptor.java > e5ddad0426b54d2eb620beafeb66b5f15999361b > > src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java > ca9ed10d7c4b9b796b1d0cc124e665b3690ebd4f > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java > 94ca02ad425ea67787149ae8733b19c0fea325ab > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java > 515edd7c3a213dc41a6a04ccae2a3fcd78644f70 > src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java > ae234ac274e22c55eca60fa8978db1563d7fd6ae > src/main/java/org/apache/aurora/scheduler/http/HttpStatsFilter.java > 29b22b9bc86f3b773f2ecc72d4084c7d40333e5b > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java > a9edc4352853c774b54440f0bce1b56500bd7b20 > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java > 315b48a3141af5d6a195652d03c9035306eac96b > src/main/java/org/apache/aurora/scheduler/http/Offers.java > e62990b37b8d4e464bef3d5bdb082ab46587be02 > src/main/java/org/apache/aurora/scheduler/http/Quotas.java > 8420689330620b4528f35c4120ca665ab884fa34 > src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java > 090f2726a990edc2a8271ccaf1abd21638538f32 > src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java > a1eb0fc6b69cde53ded34c1442e5b66c43182d2d > src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java > 8b4a03556bd0fc95b32c2a83be4f93125e1b4c90 > src/main/java/org/apache/aurora/scheduler/http/ServletModule.java > 22b1a89beb8c33d838089c9630350d899e61e3a9 > src/main/java/org/apache/aurora/scheduler/http/Slaves.java > a635d2bdf6eecc4adb45948f1253627a7be2e142 > src/main/java/org/apache/aurora/scheduler/http/StructDump.java > 7f5784f79abbc04113d964757c9ede088de2ea20 > src/main/java/org/apache/aurora/scheduler/http/Utilization.java > b24b6db83557dc63ab38c6291145335e4991d1a6 > src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java > 99635f34efe6ab93b8f2ddc2c12589391d2912c7 > > src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java > 30e4d425abfa4b0bfb5444b74c7e722a26218a66 > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java > 901f753ab9866a68d88e8eb28c774f6623b07bc2 > > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java > b6720a3fd6ec5b327d58399ba04859798b9d3174 > src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java > 0c5b8b27a160e9ce3b1c34ff04da987221c37b54 > > src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java > da766780dfb85f9b33bade2619efa99f1de96e19 > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java > 86ccd6e4afc74b50a1cf56f9e156b4e1723c1c7d > src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java > 30274b4ca50703b688ec5db7f470cef58335a035 > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java > d360fc1ee941aed96e1d992a261b1e14267b60cb > src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java > c7d87ffabcd9745559458b2e22655e199fc708f5 > src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java > 047ff610272c6383164254be4346305d5688755e > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java > e0bfb1e44f3cfda740bf48b78a5f6f023b8849bc > src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java > f17bd33e70fb385055103af36cb520b6b9170ecc > src/main/java/org/apache/aurora/scheduler/state/SideEffectStorage.java > f710cac6ff6d40122e04c486d4871981d889ad3f > src/main/java/org/apache/aurora/scheduler/state/StateManager.java > a0212bf1d01df4907cfdc5e05b42dd6ccf90d30f > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > b6db6c08181b15ee18ddc60cbcb15fb5957bed61 > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java > 95de7fd12301999f9b63c5982374dde8d240dda2 > src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java > 4fb3346ecbe3b27b2d7354bee05ce75e0a0a2358 > src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java > 7977beb38c14878f5867ea8ea1e9575644004db4 > src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java > 097b15a14f7650fd07d6ba7908cbff56a1c18c18 > > src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java > 00425391b644fe5d432890e5906592f76b57dc12 > src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java > e1f57b46ce1d75c3139d64006ba7f2ebcb379820 > src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java > 0316502819555181a2f51defc7280b925b125282 > src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java > 2a90cd3bfb8dc2737fe3623d6ba3b26f41ef8a32 > src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java > 15f64e5f86667b8279c740df5c754edeea27898c > > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java > 4948ab84628b39fc48df86ab5f9b61ed54e3f979 > src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java > 0e0d79fb03524679bf745db8c2a2e492da5d0e8a > src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java > dab2e1eb651e927f69d1774174644a778c1eb315 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > 2254733f573ecd8f12a6cd13623ea8efb06af723 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java > fc520d55b929f783f2745a84788df9aa84e569d4 > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java > bd5fd59cdb2bf5a9589faa515670d7cf11242b94 > > src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java > 6d46e504de2c3dadde18c01e117f97b400addeab > src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java > 84320b9fba44d7d716558b3b6aa9a9a7646e6258 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java > 6cde86c5ccf7bd833b697775fc6f7010d47d4b21 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > 64a8a4978e7ebe37de4e12d9d6bddd38e84ee004 > > src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > 012cb9b0222e1ee776e9bbe3d24bf509112749cd > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerAPIServlet.java > a305cedd7d6fc84172c86906fb78469cfe63dbe5 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 878ed682a699669dc4ed0e5ccf9a86d1bc59e9e3 > src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java > 6ad43134fb4d943985282b6f66c8e9a1db64d4de > src/main/java/org/apache/aurora/scheduler/thrift/ThriftServer.java > fe3e4363837f6dfb2ec7fbfc4f573a4dd339eefd > src/main/java/org/apache/aurora/scheduler/thrift/ThriftServerLauncher.java > d69b8d437c97624cc5f594bedf8b95fcfbf75bf3 > > src/main/java/org/apache/aurora/scheduler/thrift/aop/APIVersionInterceptor.java > c245f42ee7a2c2eb04c5eca208861d0e7182ece3 > src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java > f6fec30df3b85d35402517996f3249cb705c08cc > > src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java > 327933e46cfca99213688d6375b492dc67ffadda > > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java > d459372042fc54859067dbfddef39b46142db1ec > > src/main/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor.java > 9ccde4d50b5cac8d57a2eb0bef68c735c019ba85 > > src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java > e00a4859c788b58cc217185c971707857fcb02c7 > src/main/java/org/apache/aurora/scheduler/thrift/auth/ThriftAuthModule.java > 178a05327f50f59fcba4efe5111a8290335a751c > src/test/java/org/apache/aurora/GuiceUtilsTest.java > d8e8297ac64038493dc10990f340a15b26dbc68a > src/test/java/org/apache/aurora/codec/ThriftBinaryCodecTest.java > d03ae6583e2192e07c8d6289dd19252cad00a95c > src/test/java/org/apache/aurora/scheduler/DriverFactoryImplTest.java > 621d7b3a44f602a06e1afcf4ad43d2de10cdd2d0 > src/test/java/org/apache/aurora/scheduler/DriverTest.java > 1a21261eaf61c690a58c77695ef9419d7410b750 > src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java > 7527ed804e32442fa8c5ae23ed6021bf913df8b5 > src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java > 63d4162fa8de471142d50faa01f21b51a3e5800d > src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java > 3f4adfa9abdc4f895f42039f60da1657bee8aef7 > src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java > 8fe55c1741b2c1a1f0ec0fbdcbd8e48d91131d87 > src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java > 176f8c0ffe805b9567500dd71720e66ac78bc059 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > 241bc5e5567178e020d8411f6e0dc11c09aed369 > src/test/java/org/apache/aurora/scheduler/async/HistoryPrunerTest.java > 3e9309409643f0e91dd7da0e1019ec98f0fa21d3 > src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java > 2add9c4eaa6547262db4e6f4bac66fe537aab8dc > src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java > 87af50816b6031a10fcfb684f08b6d27ee3d7f15 > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java > 350dd07abe8588562cf9aa3da32ad1c7f21936f8 > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java > 1b0548730e44b144957ecc888cea95ff66123c1e > src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java > 70f47c4f12e48b2d32f838bc00a132d102bc64f5 > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > 2ecdbcfa1f5d45c7fff536dddafd5f01a06bc8d4 > src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java > 1c8a78148f1107881c66a82b87290753fe4be847 > src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java > 68c440bd271088957f7a640137539d5c7365a4f1 > > src/test/java/org/apache/aurora/scheduler/events/NotifyingMethodInterceptorTest.java > 824b0f23b426d8ebc2c8255e1456afe73d9fbdab > > src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java > efa8ed4b85c5b5500359e9b18e70e13d73f2616b > > src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java > 19717d2375a7e2a07eef3fae636794f4493a3b72 > src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java > 934ad95dcf138512dfbdc39e8e563d4ef6a1f046 > src/test/java/org/apache/aurora/scheduler/http/MnameTest.java > 088e8023eb96ce0810c5a31394c217772203f2f9 > src/test/java/org/apache/aurora/scheduler/http/SchedulerzRoleTest.java > 34efa9fee797ead1b401a378a2840d328e9c9a0b > src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java > 38b5f363abcf920cc0bf829a068ef785aedf9933 > src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java > 05148ae2964c4898f2077b211000529907535d18 > > src/test/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncherTest.java > 67f4dcb99daba147b24c17449513d3fb77c097e3 > > src/test/java/org/apache/aurora/scheduler/quota/QuotaComparisonResultTest.java > ed3c532d78bfa80267f096568094c298172d2034 > src/test/java/org/apache/aurora/scheduler/quota/QuotaFilterTest.java > c3ba5a5bb90c705ef0592d4454e75acb9e3f0aa4 > src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java > 37b3bf09ca5f26243010cc4f3423b88e32308e70 > > src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java > aa4818657d2d87328292fe8288a98b1b254cc6c0 > src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java > d5627b216f01b554a9cf4497543006a36f839021 > src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java > 264883d79d4ee0a0acc3c689268769e4b3156ac0 > > src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java > 005814b1ab289c254c29a32442deae120f10af23 > src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java > 0f2982553c20e413d3866cf077538d2d49624e8e > src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java > 122cb67a9d82a0049b031ffc1d2c2522347221fc > src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java > 1148d0bcf9e4d9b0d6d0aa375bf17029b07066d0 > src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java > cc6ca40d5dcf5b6f3e855d0b238b6bb48d21122c > > src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java > 24e00dd62c7f71be8acb4a2f1e5be71612c74098 > src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java > 6c0f3fb583dfb1f1a1939188277368ad05fc7f75 > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java > 5c12fbe5737d67877c0cde48ffa212a2e65a7e05 > > src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java > 12d7ad52a92971c640c07c2f29496a2080bea8ad > src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java > c5affcea31458c2047ceb5e55dd9521aa87c6bf7 > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > 81cf0472a0a483ee6b7c3f2269e893e2da9568f6 > > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java > a96b51b0a9e59e70deed37e3ac5af58e48215fbe > src/test/java/org/apache/aurora/scheduler/storage/mem/MemJobStoreTest.java > a9fbe7dd000b6f7224aa286e8f82c03b3c38f5f5 > src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java > 1a50b2c6b41ca902314ca4b5cdbff2adfece7b80 > src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java > 9bfafcec62b38e310bbe1f8a9382c66bf6f0dc05 > src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java > bc948985268d0f2d8d0a274a7f045d881203d27f > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 23e7f76cd131d640e7da9efc221c57904329c7c0 > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java > fcdcd716498686cfa78da8948832f965e74b84d2 > > src/test/java/org/apache/aurora/scheduler/thrift/aop/APIVersionInterceptorTest.java > 89bf9fae053344e5d7bda9d947474c37e9003f9b > src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java > 849397ccbc7ce7524dc686b4e4ccadec8aa58949 > > src/test/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptorTest.java > cc2a776cb8856570a9198189ce4e1d02cb5fbc4c > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java > 0c882fe4aa204f0b392766761f97fe09990627d1 > > src/test/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptorTest.java > cbee7cf73b7cebc1ade44a4c19f65b86062f2468 > > Diff: https://reviews.apache.org/r/16576/diff/ > > > Testing > ------- > > ./gradlew build > > > Thanks, > > Bill Farner > >
