> On Jan. 2, 2014, 10:57 p.m., Bill Farner wrote: > > src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html, line 23 > > <https://reviews.apache.org/r/16528/diff/1/?file=407232#file407232line23> > > > > remove? seems superfluous > > Suman Karumuri wrote: > For performance reasons and for progressive rendering, JS scripts are > always added to the end of the html file. > > Some people use this convention to signal the end of HTML in a file. > Beyond this point only scripts and other interactive stuff should be > included. Some scripts only work when they are included at the right places > in the html file. A tag like this also ensures that the scripts below are > well behaved. Following the convention here, so would like to keep it. > > Bill Farner wrote: > I was actually referring to the presence of "<!-- Scripts -->" as being > superfluous, not the placement of the script tags. Convention set in this > file and conventional wisdom seem to be good enough to make this extra > tag/line unnecessary.
Oh. Done. Removed. - Suman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16528/#review31080 ----------------------------------------------------------- On Jan. 3, 2014, 10:34 p.m., Suman Karumuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16528/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2014, 10:34 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Implemented new Scheduler home page using AngularJS. The UI queries the > backend using the thrift end point. This diff sets the basic foundation for > the page. Sending this out to get some early feedback and to keep the future > diffs small. > > The URLs in the new UI will redirect to the scheduler role pages. > > Dropped the option to select number of results to be shown to simplify the > interface. Now defaulting to 25 results per page. > > Cleaned up the UI to make it more light weight. > > Added a mock service to render dummy data on the page. Currently, this mock > service is manually wired during testing. Will created an isolated scheduler > page once we have a single page app. > > Updated build.gradle to generate thrift JS client. > > Installed Angular and smart-table from bower. Added thrift.js file to make > the calls to the backend. Will migrate to angular-thrift for more robust > implementation in coming diffs. > > > Diffs > ----- > > 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION > 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION > 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION > 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION > 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION > 3rdparty/javascript/bower_components/angular/angular.min.js.gzip > PRE-CREATION > 3rdparty/javascript/bower_components/angular/angular.min.js.map > PRE-CREATION > 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION > 3rdparty/javascript/thrift.js PRE-CREATION > build.gradle 7e33ed8c7c6f118908d24cb5a7e3a8a15e34e063 > src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java > 825e2e1eb442feb2bac1d8d7df20707fd23fc23d > src/main/resources/com/twitter/aurora/scheduler/http/ui/css/app.css > PRE-CREATION > src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html > PRE-CREATION > src/main/resources/com/twitter/aurora/scheduler/http/ui/js/app.js > PRE-CREATION > src/main/resources/com/twitter/aurora/scheduler/http/ui/js/controllers.js > PRE-CREATION > src/main/resources/com/twitter/aurora/scheduler/http/ui/js/directives.js > PRE-CREATION > src/main/resources/com/twitter/aurora/scheduler/http/ui/js/services.js > PRE-CREATION > src/main/resources/com/twitter/aurora/scheduler/http/ui/roleLink.html > PRE-CREATION > > Diff: https://reviews.apache.org/r/16528/diff/ > > > Testing > ------- > > gradle clean build > > Tested the UI using the isolated scheduler. > > > File Attachments > ---------------- > > Home page > > https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png > > > Thanks, > > Suman Karumuri > >
