Re: Review Request 16267: Adding a script to run an isolated scheduler.

> On Dec. 13, 2013, 5:30 p.m., Bill Farner wrote: > > I would much rather see further investment in local runs through vagrant. > > Have you considered focusing there instead? > > Suman Karumuri wrote: > Yes, I have considered it and found vagrant to be too slow for iterative > edit-build

Re: Tagging process

This process sounds good to me. So long as the process is automated I think we will be fine. Will the person who creates the release ("release czar"?) get to choose what lands on master before the release is cut? Also does this mean we need to keep the CHANGELOG updated as we commit new features s

Re: Review Request 16267: Adding a script to run an isolated scheduler.

+1 for local run On Fri, Dec 13, 2013 at 5:30 PM, Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16267/#review30394 >

Re: Review Request 16261: Now treating empty log file as new log file in test.

> On Dec. 14, 2013, 1:58 a.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/log/testing/FileLog.java, line 66 > > > > > > why not use logFile.length()? > > Bill Farner wrote: > Also, while you'

Re: Review Request 16261: Now treating empty log file as new log file in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16261/ --- (Updated Dec. 14, 2013, 3:44 a.m.) Review request for Aurora, Kevin Sweeney, Ma

Re: Review Request 16195: Added a home page with a header for the new UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16195/ --- (Updated Dec. 14, 2013, 2:57 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 16130: First steps towards aurora client v2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16130/#review30411 --- src/main/python/twitter/aurora/client/cli/jobs.py

Re: Review Request 16130: First steps towards aurora client v2

> On Dec. 12, 2013, 3:08 p.m., Mark Chu-Carroll wrote: > > ping? > > Mark Chu-Carroll wrote: > Hello? Is anybody out there? > sorry -- just realized i'm not subscribed to any of the groups yet so none of the e-mail notifications are being sent to me. - Brian ---

Re: Review Request 16130: First steps towards aurora client v2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16130/#review30409 --- I don't have ship powers, but wow. This is so readable. +10 http://

Re: Review Request 16261: Now treating empty log file as new log file in test.

> On Dec. 14, 2013, 1:58 a.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/log/testing/FileLog.java, line 66 > > > > > > why not use logFile.length()? > > Bill Farner wrote: > Also, while you'

Re: Review Request 16261: Now treating empty log file as new log file in test.

> On Dec. 14, 2013, 1:58 a.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/log/testing/FileLog.java, line 66 > > > > > > why not use logFile.length()? > > Bill Farner wrote: > Also, while you'

Re: Tagging process

I presume hotfixing would be a completely manual process where we would branch out from a tagged release? Thanks, Maxim On Dec 13, 2013, at 6:20 PM, Kevin Sweeney wrote: > Hey all, > > I think figuring out the tagging process sooner than later is in everyone's > best interest so that we ca

Re: Tagging process

This sounds good to me. -=Bill On Fri, Dec 13, 2013 at 6:20 PM, Kevin Sweeney wrote: > Hey all, > > I think figuring out the tagging process sooner than later is in > everyone's best interest so that we can get out of cherry-pick limbo. I'm > out next week, but if anyone wants to take a stab a

Re: Review Request 16268: Lock should be released if job does not exist

> On Dec. 14, 2013, 1:26 a.m., Bill Farner wrote: > > src/main/python/twitter/aurora/client/api/updater.py, line 376 > > > > > > I think this is unsafe. 'Error' is definitely too generic to determine > > that it's saf

Tagging process

Hey all, I think figuring out the tagging process sooner than later is in everyone's best interest so that we can get out of cherry-pick limbo. I'm out next week, but if anyone wants to take a stab at it (using https://reviews.apache.org/r/16265/ as a starting point or just throw it away, please f

Re: Review Request 16268: Lock should be released if job does not exist

> On Dec. 14, 2013, 1:26 a.m., Bill Farner wrote: > > src/main/python/twitter/aurora/client/api/updater.py, line 376 > > > > > > I think this is unsafe. 'Error' is definitely too generic to determine > > that it's saf

Re: Review Request 16195: Added a header for the new UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16195/#review30404 --- src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java

Re: Review Request 16231: Added getJobSummary call to thrift API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16231/#review30402 --- src/main/java/com/twitter/aurora/scheduler/thrift/SchedulerThriftIn

Re: Review Request 16163: Added extra_modules option to Scheduler.

> On Dec. 14, 2013, 2:03 a.m., Bill Farner wrote: > > Ship It! Thanks! - Suman --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16163/#review30401 -

Re: Review Request 16163: Added extra_modules option to Scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16163/#review30401 --- Ship it! Ship It! - Bill Farner On Dec. 13, 2013, 10:23 p.m., Su

Re: Review Request 16261: Now treating empty log file as new log file in test.

> On Dec. 14, 2013, 1:58 a.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/log/testing/FileLog.java, line 66 > > > > > > why not use logFile.length()? Also, while you're in here — mind validating

Re: Review Request 16261: Now treating empty log file as new log file in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16261/#review30399 --- src/main/java/com/twitter/aurora/scheduler/log/testing/FileLog.java

Re: Review Request 16232: Add offer reservations to preemption flow

> On Dec. 14, 2013, 12:36 a.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/async/TaskScheduler.java, line > > 225 > > > > > > Low-hanging fruit for performance: check if the old state was PENDIN

Re: Review Request 16192: Installing JQuery and bootstrap from bower

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16192/#review30396 --- It would be really nice to see the third-party sources placed in a d

Re: Review Request 16232: Add offer reservations to preemption flow

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16232/ --- (Updated Dec. 13, 2013, 5:49 p.m.) Review request for Aurora, Kevin Sweeney, Ma

Re: Review Request 16232: Add offer reservations to preemption flow

> On Dec. 13, 2013, 4:36 p.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/async/TaskScheduler.java, lines > > 130-131 > > > > > > You already cNN on these in the Reservations constructor (good).

Re: Review Request 16267: Adding a script to run an isolated scheduler.

> On Dec. 14, 2013, 1:30 a.m., Bill Farner wrote: > > I would much rather see further investment in local runs through vagrant. > > Have you considered focusing there instead? Yes, I have considered it and found vagrant to be too slow for iterative edit-build-run cycle. I prefer a local scrip

Re: Review Request 16268: Lock should be released if job does not exist

> On Dec. 14, 2013, 1:26 a.m., Bill Farner wrote: > > src/main/python/twitter/aurora/client/api/updater.py, line 376 > > > > > > I think this is unsafe. 'Error' is definitely too generic to determine > > that it's saf

Re: Review Request 16267: Adding a script to run an isolated scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16267/#review30394 --- I would much rather see further investment in local runs through vag

Re: Review Request 16268: Lock should be released if job does not exist

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16268/#review30393 --- src/main/python/twitter/aurora/client/api/updater.py

Review Request 16268: Lock should be released if job does not exist

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16268/ --- Review request for Aurora, Bill Farner and Brian Wickman. Repository: aurora

Re: Review Request 16192: Installing JQuery and bootstrap from bower

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16192/ --- (Updated Dec. 14, 2013, 1:12 a.m.) Review request for Aurora, Kevin Sweeney and

Review Request 16267: Adding a script to run an isolated scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16267/ --- Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner. R

Re: Review Request 16232: Add offer reservations to preemption flow

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16232/#review30385 --- src/main/java/com/twitter/aurora/scheduler/async/TaskScheduler.java

Re: Review Request 16266: Bumping up python thrift version to 0.9.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16266/#review30387 --- Ship it! Ship It! - Brian Wickman On Dec. 14, 2013, 12:26 a.m.,

Review Request 16266: Bumping up python thrift version to 0.9.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16266/ --- Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Repos

Re: Review Request 16232: Add offer reservations to preemption flow

> On Dec. 13, 2013, 1:35 a.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/async/TaskScheduler.java, line > > 146 > > > > > > There's a bit of a feature gap here — if the task _is_ assigned, the

Re: Review Request 16232: Add offer reservations to preemption flow

> On Dec. 12, 2013, 5:35 p.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/async/TaskScheduler.java, line > > 146 > > > > > > There's a bit of a feature gap here — if the task _is_ assigned, the

Re: Review Request 16232: Add offer reservations to preemption flow

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16232/ --- (Updated Dec. 13, 2013, 4:16 p.m.) Review request for Aurora, Kevin Sweeney, Ma

Re: Review Request 16232: Add offer reservations to preemption flow

> On Dec. 12, 2013, 5:35 p.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/async/AsyncModule.java, line 128 > > > > > > The help string could use some more detail, thinking out loud: > > > >

Re: Review Request 16265: Script for creating tags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16265/#review30382 --- build-support/tag-release

Review Request 16265: Script for creating tags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16265/ --- Review request for Aurora, Maxim Khutornenko, Bill Farner, and Brian Wickman. R

Review Request 16261: Now treating empty log file as new log file in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16261/ --- Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, Bill Farner, and Za

Re: Review Request 16163: Added extra_modules option to Scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16163/ --- (Updated Dec. 13, 2013, 10:23 p.m.) Review request for Aurora, Kevin Sweeney, M

Re: Review Request 16163: Added extra_modules option to Scheduler.

> On Dec. 11, 2013, 1:59 a.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java, line 141 > > > > > > please drop QUOTA from here, as i'm pulling that out in a separate > > revi

Re: Review Request 16257: Fix gradle to include same version as artifact in generated distribution tarball

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16257/#review30380 --- Thanks, submitted! - Kevin Sweeney On Dec. 13, 2013, 1:49 p.m., K

Re: Review Request 16257: Fix gradle to include same version as artifact in generated distribution tarball

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16257/#review30379 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 13, 2013, 9:49 p.m

Re: Review Request 16257: Fix gradle to include same version as artifact in generated distribution tarball

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16257/#review30378 --- Ship it! Ship It! - Zameer Manji On Dec. 13, 2013, 1:49 p.m., Ke

Review Request 16257: Fix gradle to include same version as artifact in generated distribution tarball

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16257/ --- Review request for Aurora, Maxim Khutornenko, Bill Farner, Brian Wickman, and Za

Re: Review Request 16054: Rewrite SchedulerLifecycle, employing a state machine.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16054/ --- (Updated Dec. 13, 2013, 8:09 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 16054: Rewrite SchedulerLifecycle, employing a state machine.

> On Dec. 13, 2013, 7:48 p.m., Kevin Sweeney wrote: > > Do you mind adding a stat for the current state? Something like > > > > scheduler_lifecycle_state_RUNNING 1 > > scheduler_lifecycle_state_* 0 > > Maxim Khutornenko wrote: > +1 A fine suggestion, done. - Bill --

Re: Review Request 16054: Rewrite SchedulerLifecycle, employing a state machine.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16054/#review30371 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 13, 2013, 7:39 p.m

Re: Review Request 16054: Rewrite SchedulerLifecycle, employing a state machine.

> On Dec. 13, 2013, 7:48 p.m., Kevin Sweeney wrote: > > Do you mind adding a stat for the current state? Something like > > > > scheduler_lifecycle_state_RUNNING 1 > > scheduler_lifecycle_state_* 0 +1 - Maxim --- This is an automatical

Re: Review Request 16247: Adding random jitter for the initial GC task scheduling to better spread GC execution over time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16247/#review30368 --- src/main/java/com/twitter/aurora/scheduler/PulseMonitor.java

Re: Review Request 16054: Rewrite SchedulerLifecycle, employing a state machine.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16054/#review30365 --- Do you mind adding a stat for the current state? Something like sch

Re: Review Request 16054: Rewrite SchedulerLifecycle, employing a state machine.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16054/ --- (Updated Dec. 13, 2013, 7:39 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 16246: Fixing usage in /structdump

> On Dec. 13, 2013, 6:10 p.m., Bill Farner wrote: > > Mind closing this in favor of https://reviews.apache.org/r/16062, and > > asking for the s/job/cron/ switch over there? > > Maxim Khutornenko wrote: > Sure, did not notice that RB. Looks like it was never committed. Yeah, it slipped thr

Re: Review Request 16054: Rewrite SchedulerLifecycle, employing a state machine.

> On Dec. 10, 2013, 11:30 p.m., Suman Karumuri wrote: > > src/main/java/com/twitter/aurora/scheduler/Driver.java, line 76 > > > > > > Does the comment need to be updated to "starts and runs the underlying > > driver ..

Re: Review Request 16054: Rewrite SchedulerLifecycle, employing a state machine.

> On Dec. 10, 2013, 11:53 p.m., Maxim Khutornenko wrote: > > src/main/java/com/twitter/aurora/scheduler/Driver.java, line 76 > > > > > > Mind adjusting the comments here to reflect run/start change? Done. > On Dec. 1

Review Request 16247: Adding random jitter for the initial GC task scheduling to better spread GC execution over time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16247/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Re: Review Request 16062: fixed structdump usage message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16062/#review30353 --- src/main/java/com/twitter/aurora/scheduler/http/StructDump.java

Re: Review Request 16246: Fixing usage in /structdump

> On Dec. 13, 2013, 6:10 p.m., Bill Farner wrote: > > Mind closing this in favor of https://reviews.apache.org/r/16062, and > > asking for the s/job/cron/ switch over there? Sure, did not notice that RB. Looks like it was never committed. - Maxim

Re: Review Request 16246: Fixing usage in /structdump

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16246/#review30349 --- Mind closing this in favor of https://reviews.apache.org/r/16062, an

Review Request 16246: Fixing usage in /structdump

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16246/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Re: Review Request 16130: First steps towards aurora client v2

> On Dec. 12, 2013, 10:08 a.m., Mark Chu-Carroll wrote: > > ping? Hello? Is anybody out there? - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16130/#review30259 --