> On Dec. 12, 2013, 5:35 p.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/async/TaskScheduler.java, line > > 146 > > <https://reviews.apache.org/r/16232/diff/1/?file=397101#file397101line146> > > > > There's a bit of a feature gap here — if the task _is_ assigned, the > > reservation should be cleared so we can promptly schedule others. It may > > be tempting to call the O(n) invalidateTask(), but i suggest adding the > > O(1) invalidateSlave(). > > > > Please write a failing test for this behavior, then fix. > > Zameer Manji wrote: > Pushing this to the next diff.
Actually not doing this just yet. This complicates the code because now it removes the reservation either when the taskState changes or when we assign the task. I strongly prefer keeping it simple and letting reservation removal occur via pubsub. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16232/#review30317 ----------------------------------------------------------- On Dec. 13, 2013, 4:16 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16232/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2013, 4:16 p.m.) > > > Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner. > > > Bugs: AURORA-11 > https://issues.apache.org/jira/browse/AURORA-11 > > > Repository: aurora > > > Description > ------- > > This patch adds a reservation system the preemption flow. > > The reservation associates a slave id with a task id for a fixed duration. If > the task attempts to schedule itself during that time period and an offer is > available from that slave then it will be scheduled. If another task attempts > to schedule itself then it will not use the reserved offer. > > > Diffs > ----- > > src/main/java/com/twitter/aurora/scheduler/async/AsyncModule.java > db07841543e554e269f6fe7b36d7f7232af21140 > src/main/java/com/twitter/aurora/scheduler/async/Preemptor.java > e5aeb8321e22c51eb3a5dad3d3dd1e26b7121b7d > src/main/java/com/twitter/aurora/scheduler/async/TaskGroups.java > f95f719c5a444b0f8faa4330852e251dd5de528e > src/main/java/com/twitter/aurora/scheduler/async/TaskScheduler.java > fbd82ff70235294cfd27c242f141a585d6bb2396 > src/test/java/com/twitter/aurora/scheduler/async/TaskSchedulerImplTest.java > PRE-CREATION > src/test/java/com/twitter/aurora/scheduler/async/TaskSchedulerTest.java > a747f2b1ecbad7263931aeec3b12711096d2469d > src/test/java/com/twitter/aurora/scheduler/state/PubsubTestUtil.java > f9d7fb64728008d0ea6eb424283b58e956e1d50a > > Diff: https://reviews.apache.org/r/16232/diff/ > > > Testing > ------- > > ./gradlew clean build > > > Thanks, > > Zameer Manji > >
