Otavio and I discussed this privately on IRC yesterday and I was able to
better articulate my reasons against the current patch.
Basically I don't think that CDDs should rely on preseeding to customize
the installer so fundamentally at run-time. If such customizing is needed
(and I do agree tha
Frans Pop <[EMAIL PROTECTED]> writes:
> On Saturday 12 August 2006 10:35, Otavio Salvador wrote:
>> Does anyone has comments about it?
>
> (Ignoring the debug stuff which was already removed in a later version of
> the patch.)
>
> This patch gives me the feeling that functionality is being added
On Saturday 12 August 2006 10:35, Otavio Salvador wrote:
> Does anyone has comments about it?
(Ignoring the debug stuff which was already removed in a later version of
the patch.)
This patch gives me the feeling that functionality is being added because
it is possible, not because it is really
Joey Hess <[EMAIL PROTECTED]> writes:
> Otavio Salvador wrote:
>> +# Set initial value to includes and excludes
>> +db_get base-installer/includes
>> +INCLUDES="$RET" || true
>> +
>> +db_get base-installer/excludes
>> +EXCLUDES="$RET" || true
>> +
>> +
>> log() {
>> logger -t base-installer
Otavio Salvador wrote:
> +# Set initial value to includes and excludes
> +db_get base-installer/includes
> +INCLUDES="$RET" || true
> +
> +db_get base-installer/excludes
> +EXCLUDES="$RET" || true
> +
> +
> log() {
> logger -t base-installer "$@"
> }
> @@ -125,11 +131,11 @@
>
Quoting Otavio Salvador ([EMAIL PROTECTED]):
> Christian Perrier <[EMAIL PROTECTED]> writes:
>
> > I'd recommend to put that string in the short description and the
> > whole description of the template purpose in the long description.
> >
> > The string is "for internal use"
>
> I refactored it
Frans Pop <[EMAIL PROTECTED]> writes:
> Or, if we want to avoid a change in lintian, we can try to incorporate
> "for internal use" somehow, maybe:
>"for internal use; can be preseeded".
I like this option. Is clear enough and simple.
--
O T A V I OS A L V A D O R
-
On Saturday 12 August 2006 15:25, Christian Perrier wrote:
> The string is "for internal use"
>
> See #368206
>
> Indeed, all our non translatable templates in D-I should be turned to
> use that short description.
Colin mentioned on IRC recently that strings that can be preseeded are not
really o
Christian Perrier <[EMAIL PROTECTED]> writes:
> I'd recommend to put that string in the short description and the
> whole description of the template purpose in the long description.
>
> The string is "for internal use"
I refactored it and I'm resending it for review. What do you think
now?
===
> Template: base-installer/debootstrap_script
> Type: string
> Description: Force use of a specific debootstrap script
> For preseeding only; not translated.
>
> Better now?
It's likely that lintian will warn on that template. Since a recent
version, it warns for writing style when templates are
Christian Perrier <[EMAIL PROTECTED]> writes:
>> +Template: base-installer/script
>> +Type: string
>> +Description: Script to use when different of suite codename
>> + For preseeding only; not translated.
>
> That one is not really clear. Can it be reworded? Even if
> untranslatable, I fear I woul
> === debian/base-installer.templates
> ==
> --- debian/base-installer.templates
> (/upstream/trunk/packages/base-installer) (revision 4217)
> +++ debian/base-installer.templates (/base-installer) (revision 4217)
> @@
Otavio Salvador <[EMAIL PROTECTED]> writes:
> -
> + exit 1
Yes, I noticed it and will remove before commit. Shame on me.
--
O T A V I OS A L V A D O R
-
E-mail: [EMAIL PROTECTED] UIN: 5906116
GNU/Linux User: 239058 GPG ID: 4
13 matches
Mail list logo
